Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/9030/?format=api
{ "id": 9030, "url": "http://patches.dpdk.org/api/patches/9030/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>", "list_archive_url": "https://inbox.dpdk.org/dev/1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it", "date": "2015-11-20T18:24:19", "name": "[dpdk-dev] ring: Fix memory leakage in rte_pmd_ring_devuninit", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "591421298f7f651e0def8b6fb018568e1c4742a6", "submitter": { "id": 375, "url": "http://patches.dpdk.org/api/people/375/?format=api", "name": "Mauricio Vasquez B", "email": "mauricio.vasquezbernal@studenti.polito.it" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/9030/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/9030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B5CE48DAF;\n\tFri, 20 Nov 2015 19:24:29 +0100 (CET)", "from compass.polito.it (compass.polito.it [130.192.55.110])\n\tby dpdk.org (Postfix) with ESMTP id 52E368DAC\n\tfor <dev@dpdk.org>; Fri, 20 Nov 2015 19:24:28 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n\tby compass.polito.it (Postfix) with ESMTP id 261121000EA;\n\tFri, 20 Nov 2015 19:24:28 +0100 (CET)", "from compass.polito.it ([127.0.0.1])\n\tby localhost (compass.polito.it [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id k5_rDDxNLtZx; Fri, 20 Nov 2015 19:24:27 +0100 (CET)", "from localhost.localdomain (unknown [93.56.117.174])\n\t(using TLSv1.2 with cipher AES128-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\t(Authenticated sender: s203403@studenti.polito.it)\n\tby compass.polito.it (Postfix) with ESMTPSA id 2486E1000DB;\n\tFri, 20 Nov 2015 19:24:27 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=\n\tstudenti.polito.it; h=references:in-reply-to:x-mailer:message-id\n\t:date:date:subject:subject:cc:to:from:from:received:received; s=\n\ty2k10; t=1448043867; bh=xxV1ocChqG+MPc+MSP8sgDSVUiJ73HnCK8sKsEUo\n\t998=; b=e0j8CBkq+gzfLoHy0IQdVcjZ4nNoCOrkEGfQdEA++eIPc8QLm00M1rUn\n\tPb9xIx8lHTojihZXa0vWK9QXUo5ssvoqNjD9OT+1q7EFWKKsBlLy7bgsck3wNYhA\n\tn/5rdzR7DKljwoo82F/DN/6OY/mvKnoXFMGS2BO+n3kKtIfc27M=", "X-Virus-Scanned": "amavisd-new at studenti.polito.it", "From": "Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>", "To": "dev@dpdk.org", "Date": "Fri, 20 Nov 2015 19:24:19 +0100", "Message-Id": "<1448043859-4326-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1447885757-13038-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>", "References": "<1447885757-13038-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it>", "Subject": "[dpdk-dev] [PATCH] ring: Fix memory leakage in\n\trte_pmd_ring_devuninit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When freeing the device it is also neccesary to free\nrx_queues and tx_queues\n\nSigned-off-by: Mauricio Vasquez B <mauricio.vasquezbernal@studenti.polito.it>\n---\nv2:\nAdded extra control before freeing members of eth_dev->data\n\n drivers/net/ring/rte_eth_ring.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 9a31bce..4ce0256 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -582,7 +582,12 @@ rte_pmd_ring_devuninit(const char *name)\n \t\treturn -ENODEV;\n \n \teth_dev_stop(eth_dev);\n-\trte_free(eth_dev->data->dev_private);\n+\n+\tif(eth_dev->data) {\n+\t\trte_free(eth_dev->data->rx_queues);\n+\t\trte_free(eth_dev->data->tx_queues);\n+\t\trte_free(eth_dev->data->dev_private);\n+\t}\n \trte_free(eth_dev->data);\n \n \trte_eth_dev_release_port(eth_dev);\n", "prefixes": [ "dpdk-dev" ] }