Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/90230/?format=api
{ "id": 90230, "url": "http://patches.dpdk.org/api/patches/90230/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1617184904-55349-7-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1617184904-55349-7-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1617184904-55349-7-git-send-email-humin29@huawei.com", "date": "2021-03-31T10:01:40", "name": "[06/10] net/hns3: fix flow counter not cleared when create", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b1724ff44c097533a99574dcd4d08c5e8134a3a3", "submitter": { "id": 1944, "url": "http://patches.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1617184904-55349-7-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 16009, "url": "http://patches.dpdk.org/api/series/16009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=16009", "date": "2021-03-31T10:01:38", "name": "some bugfixes for hns3 PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/16009/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/90230/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/90230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB021A034F;\n\tWed, 31 Mar 2021 12:02:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD633140EC5;\n\tWed, 31 Mar 2021 12:01:40 +0200 (CEST)", "from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35])\n by mails.dpdk.org (Postfix) with ESMTP id ED66E140E53\n for <dev@dpdk.org>; Wed, 31 Mar 2021 12:01:26 +0200 (CEST)", "from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4F9MGt120tz9v02\n for <dev@dpdk.org>; Wed, 31 Mar 2021 17:59:18 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id\n 14.3.498.0; Wed, 31 Mar 2021 18:01:19 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>", "Date": "Wed, 31 Mar 2021 18:01:40 +0800", "Message-ID": "<1617184904-55349-7-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1617184904-55349-1-git-send-email-humin29@huawei.com>", "References": "<1617184904-55349-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 06/10] net/hns3: fix flow counter not cleared\n when create", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Chengwen Feng <fengchengwen@huawei.com>\n\nUser could create flow rules with specified counter by the action of\nRTE_FLOW_ACTION_TYPE_COUNT, but the counter may retain the original\nvalue when create.\n\nThis patch fix the bug by read the counter when creating the rule\nbecause the counter is read-clear.\n\nFixes: fcba820d9b9e (\"net/hns3: support flow director\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_flow.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)", "diff": "diff --git a/drivers/net/hns3/hns3_flow.c b/drivers/net/hns3/hns3_flow.c\nindex 0c4e911..84ab819 100644\n--- a/drivers/net/hns3/hns3_flow.c\n+++ b/drivers/net/hns3/hns3_flow.c\n@@ -158,7 +158,10 @@ hns3_counter_new(struct rte_eth_dev *dev, uint32_t shared, uint32_t id,\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_pf *pf = &hns->pf;\n+\tstruct hns3_hw *hw = &hns->hw;\n \tstruct hns3_flow_counter *cnt;\n+\tuint64_t value;\n+\tint ret;\n \n \tcnt = hns3_counter_lookup(dev, id);\n \tif (cnt) {\n@@ -171,6 +174,13 @@ hns3_counter_new(struct rte_eth_dev *dev, uint32_t shared, uint32_t id,\n \t\treturn 0;\n \t}\n \n+\t/* Clear the counter by read ops because the counter is read-clear */\n+\tret = hns3_get_count(hw, id, &value);\n+\tif (ret)\n+\t\treturn rte_flow_error_set(error, EIO,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_HANDLE, NULL,\n+\t\t\t\t\t \"Clear counter failed!\");\n+\n \tcnt = rte_zmalloc(\"hns3 counter\", sizeof(*cnt), 0);\n \tif (cnt == NULL)\n \t\treturn rte_flow_error_set(error, ENOMEM,\n", "prefixes": [ "06/10" ] }