Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 89900,
    "url": "http://patches.dpdk.org/api/patches/89900/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210326082223.1398-1-gabriel.ganne@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210326082223.1398-1-gabriel.ganne@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210326082223.1398-1-gabriel.ganne@6wind.com",
    "date": "2021-03-26T08:22:23",
    "name": "[v3] meson: remove unnecessary explicit link to libpcap",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "7c232c909d1c791a6c4b28c8e8c597ea9703672e",
    "submitter": {
        "id": 2140,
        "url": "http://patches.dpdk.org/api/people/2140/?format=api",
        "name": "Gabriel Ganne",
        "email": "gabriel.ganne@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210326082223.1398-1-gabriel.ganne@6wind.com/mbox/",
    "series": [
        {
            "id": 15899,
            "url": "http://patches.dpdk.org/api/series/15899/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15899",
            "date": "2021-03-26T08:22:23",
            "name": "[v3] meson: remove unnecessary explicit link to libpcap",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/15899/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/89900/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/89900/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 983D4A0A02;\n\tFri, 26 Mar 2021 09:22:36 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0E64640685;\n\tFri, 26 Mar 2021 09:22:36 +0100 (CET)",
            "from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com\n [62.23.145.76]) by mails.dpdk.org (Postfix) with ESMTP id 545204067B\n for <dev@dpdk.org>; Fri, 26 Mar 2021 09:22:35 +0100 (CET)",
            "from localhost (unknown [10.16.0.62])\n by proxy.6wind.com (Postfix) with ESMTP id 1F0D49175CE;\n Fri, 26 Mar 2021 09:22:35 +0100 (CET)"
        ],
        "From": "Gabriel Ganne <gabriel.ganne@6wind.com>",
        "To": "Bruce Richardson <bruce.richardson@intel.com>",
        "Cc": "thierry.herbelot@6wind.com, dev@dpdk.org,\n Gabriel Ganne <gabriel.ganne@6wind.com>",
        "Date": "Fri, 26 Mar 2021 09:22:23 +0100",
        "Message-Id": "<20210326082223.1398-1-gabriel.ganne@6wind.com>",
        "X-Mailer": "git-send-email 2.29.2",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to\n libpcap",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "libpcap is already found and registered as a dependency by meson, and\nthe dependency is already correctly used in librte_port. This line is\njust unnecessary.\n\nIt also has the side effect of messing with the meson link line: dpdk\nlink will be declared twice: manually and then through pkg-config. If\nyou configure meson to prefer static linking over dynamic, this will\ncause the build to fail on librte_port, since the pcap deps are not yet\nseen by the linker.\n\nSigned-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>\n---\n config/meson.build | 1 -\n 1 file changed, 1 deletion(-)",
    "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 66a2edcc47f5..95777cf33169 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -183,7 +183,6 @@ if not pcap_dep.found()\n endif\n if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)\n \tdpdk_conf.set('RTE_PORT_PCAP', 1)\n-\tdpdk_extra_ldflags += '-lpcap'\n endif\n \n # for clang 32-bit compiles we need libatomic for 64-bit atomic ops\n",
    "prefixes": [
        "v3"
    ]
}