Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89890/?format=api
http://patches.dpdk.org/api/patches/89890/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/1616735292-74549-3-git-send-email-zhiminx.huang@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1616735292-74549-3-git-send-email-zhiminx.huang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1616735292-74549-3-git-send-email-zhiminx.huang@intel.com", "date": "2021-03-26T05:08:12", "name": "[V1,2/2] tests/flexible: add pkg check and remove reload ice", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "4d1c8024b5454f1e058645d8c9154d3804594321", "submitter": { "id": 1685, "url": "http://patches.dpdk.org/api/people/1685/?format=api", "name": "Huang, ZhiminX", "email": "zhiminx.huang@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/1616735292-74549-3-git-send-email-zhiminx.huang@intel.com/mbox/", "series": [ { "id": 15892, "url": "http://patches.dpdk.org/api/series/15892/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=15892", "date": "2021-03-26T05:08:10", "name": "remove reload ice and add pkg check", "version": 1, "mbox": "http://patches.dpdk.org/series/15892/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89890/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/89890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0626EA0A02;\n\tFri, 26 Mar 2021 06:20:51 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F22C0140DAA;\n\tFri, 26 Mar 2021 06:20:50 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id B52B5140DAA\n for <dts@dpdk.org>; Fri, 26 Mar 2021 06:20:48 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2021 22:20:48 -0700", "from unknown (HELO dpdk-huangzm-d.sh.intel.com) ([10.240.183.72])\n by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Mar 2021 22:20:47 -0700" ], "IronPort-SDR": [ "\n RdfJHOrfzTFv+w5Ory2Vha2nrXCietqx/ZZErNBF+pQMyWiQ9aiXKvqg8w7uw2acENXa5JAGDA\n lnEPUkOsSZhA==", "\n ALveJUCtVVYvtVUwzYrd7RPzKW74fdLxGMiPlot4bWOmHJcq1i+zl1a/ilBs9KXtbUlbZS8V9w\n WMbmsV8wAvDA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9934\"; a=\"252434533\"", "E=Sophos;i=\"5.81,279,1610438400\"; d=\"scan'208\";a=\"252434533\"", "E=Sophos;i=\"5.81,279,1610438400\"; d=\"scan'208\";a=\"416376115\"" ], "From": "Zhimin Huang <zhiminx.huang@intel.com>", "To": "dts@dpdk.org", "Cc": "Zhimin Huang <zhiminx.huang@intel.com>", "Date": "Fri, 26 Mar 2021 13:08:12 +0800", "Message-Id": "<1616735292-74549-3-git-send-email-zhiminx.huang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1616735292-74549-1-git-send-email-zhiminx.huang@intel.com>", "References": "<1616735292-74549-1-git-send-email-zhiminx.huang@intel.com>", "Subject": "[dts] [PATCH V1 2/2] tests/flexible: add pkg check and remove\n reload ice", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "*.flexible pf and vf suite add decorator to support pkg check\n\nSigned-off-by: Zhimin Huang <zhiminx.huang@intel.com>\n---\n tests/TestSuite_flexible_rxd.py | 26 +++++++++++++-------------\n tests/TestSuite_iavf_flexible_descriptor.py | 21 +++++++++++++--------\n 2 files changed, 26 insertions(+), 21 deletions(-)", "diff": "diff --git a/tests/TestSuite_flexible_rxd.py b/tests/TestSuite_flexible_rxd.py\nindex 648173e..45eb603 100644\n--- a/tests/TestSuite_flexible_rxd.py\n+++ b/tests/TestSuite_flexible_rxd.py\n@@ -32,11 +32,12 @@\n \n \n import time\n-from test_case import TestCase\n+from test_case import TestCase, skip_unsupported_pkg, check_supported_nic\n from flexible_common import FlexibleRxdBase\n import rte_flow_common as rfc\n \n class TestFlexibleRxd(TestCase, FlexibleRxdBase):\n+ supported_nic = ['columbiaville_100g', 'columbiaville_25g', 'columbiaville_25gx2', 'foxville']\n \n def preset_compilation(self):\n \"\"\"\n@@ -65,17 +66,11 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):\n [self.dut.send_expect(cmd, \"#\", 15, alt_session=True) for cmd in cmds]\n self.dut.build_install_dpdk(self.dut.target)\n \n+ @check_supported_nic(supported_nic)\n def set_up_all(self):\n \"\"\"\n run at the start of each test suite.\n \"\"\"\n- support_nics = [\n- \"columbiaville_25g\",\n- \"columbiaville_100g\",\n- \"foxville\",\n- ]\n- self.verify(self.nic in support_nics,\n- \"flexible rxd only supports CVL NIC.\")\n self.dut_ports = self.dut.get_ports(self.nic)\n self.verify(len(self.dut_ports) >= 1, \"Insufficient ports for testing\")\n self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])\n@@ -85,17 +80,12 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):\n self.pci = self.dut.ports_info[0]['pci']\n self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])\n self.init_base(self.pci, self.dst_mac, 'pf')\n- self.ddp_dir = \"/lib/firmware/updates/intel/ice/ddp/\"\n- self.suite_config = rfc.get_suite_config(self)\n- self.os_default_pkg = self.suite_config[\"os_default_package_file_location\"]\n- self.comms_pkg = self.suite_config[\"comms_package_file_location\"]\n \n def tear_down_all(self):\n \"\"\"\n Run after each test suite.\n \"\"\"\n self.restore_compilation()\n- self.replace_pkg(pkg='comms')\n \n def set_up(self):\n \"\"\"\n@@ -111,60 +101,70 @@ class TestFlexibleRxd(TestCase, FlexibleRxdBase):\n time.sleep(2)\n self.dut.kill_all()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_single_VLAN_fields_in_RXD_8021Q(self):\n \"\"\"\n Check single VLAN fields in RXD (802.1Q)\n \"\"\"\n self.check_single_VLAN_fields_in_RXD_8021Q()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag(self):\n \"\"\"\n Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag\n \"\"\"\n self.check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag(self):\n \"\"\"\n Check double VLAN fields in RXD (802.1Q) 2 VLAN tags\n \"\"\"\n self.check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_double_VLAN_fields_in_RXD_8021ad(self):\n \"\"\"\n Check double VLAN fields in RXD (802.1ad)\n \"\"\"\n self.check_double_VLAN_fields_in_RXD_8021ad()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv4_fields_in_RXD(self):\n \"\"\"\n Check IPv4 fields in RXD\n \"\"\"\n self.check_IPv4_fields_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv6_fields_in_RXD(self):\n \"\"\"\n Check IPv6 fields in RXD\n \"\"\"\n self.check_IPv6_fields_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv6_flow_field_in_RXD(self):\n \"\"\"\n Check IPv6 flow field in RXD\n \"\"\"\n self.check_IPv6_flow_field_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_TCP_fields_in_IPv4_in_RXD(self):\n \"\"\"\n Check TCP fields in IPv4 in RXD\n \"\"\"\n self.check_TCP_fields_in_IPv4_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_TCP_fields_in_IPv6_in_RXD(self):\n \"\"\"\n Check TCP fields in IPv6 in RXD\n \"\"\"\n self.check_TCP_fields_in_IPv6_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv4_IPv6_TCP_fields_in_RXD_on_specific_queues(self):\n \"\"\"\n Check IPv4, IPv6, TCP fields in RXD on specific queues\ndiff --git a/tests/TestSuite_iavf_flexible_descriptor.py b/tests/TestSuite_iavf_flexible_descriptor.py\nindex 3bfd5b9..41d227a 100644\n--- a/tests/TestSuite_iavf_flexible_descriptor.py\n+++ b/tests/TestSuite_iavf_flexible_descriptor.py\n@@ -35,11 +35,12 @@ import time\n import traceback\n \n \n-from test_case import TestCase\n+from test_case import TestCase, skip_unsupported_pkg, check_supported_nic\n from flexible_common import FlexibleRxdBase\n \n \n class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):\n+ supported_nic = ['columbiaville_100g', 'columbiaville_25g', 'columbiaville_25gx2', 'foxville']\n \n def preset_compilation(self):\n \"\"\"\n@@ -100,17 +101,11 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):\n except Exception as e:\n self.logger.info(traceback.format_exc())\n \n+ @check_supported_nic(supported_nic)\n def set_up_all(self):\n \"\"\"\n run at the start of each test suite.\n \"\"\"\n- support_nics = [\n- \"columbiaville_25g\",\n- \"columbiaville_100g\",\n- \"foxville\",\n- ]\n- self.verify(self.nic in support_nics,\n- \"flexible rxd only supports CVL NIC.\")\n self.dut_ports = self.dut.get_ports(self.nic)\n self.verify(len(self.dut_ports) >= 1, \"Insufficient ports for testing\")\n self.preset_compilation()\n@@ -139,18 +134,21 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):\n time.sleep(2)\n self.dut.kill_all()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_single_VLAN_fields_in_RXD_8021Q(self):\n \"\"\"\n Check single VLAN fields in RXD (802.1Q)\n \"\"\"\n self.check_single_VLAN_fields_in_RXD_8021Q()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_single_VLAN_fields_in_RXD_8021ad(self):\n \"\"\"\n Check single VLAN fields in RXD (802.1ad)\n \"\"\"\n self.check_single_VLAN_fields_in_RXD_8021ad()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_double_VLAN_fields_in_RXD_8021Q_1_VLAN_tag(self):\n \"\"\"\n Check double VLAN fields in RXD (802.1Q) only 1 VLAN tag\n@@ -163,42 +161,49 @@ class TestIavfFlexibleDescriptor(TestCase, FlexibleRxdBase):\n \"\"\"\n self.check_double_VLAN_fields_in_RXD_8021Q_2_VLAN_tag()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_double_VLAN_fields_in_RXD_8021ad(self):\n \"\"\"\n Check double VLAN fields in RXD (802.1ad)\n \"\"\"\n self.check_double_VLAN_fields_in_RXD_8021ad()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv4_fields_in_RXD(self):\n \"\"\"\n Check IPv4 fields in RXD\n \"\"\"\n self.check_IPv4_fields_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv6_fields_in_RXD(self):\n \"\"\"\n Check IPv6 fields in RXD\n \"\"\"\n self.check_IPv6_fields_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv6_flow_field_in_RXD(self):\n \"\"\"\n Check IPv6 flow field in RXD\n \"\"\"\n self.check_IPv6_flow_field_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_TCP_fields_in_IPv4_in_RXD(self):\n \"\"\"\n Check TCP fields in IPv4 in RXD\n \"\"\"\n self.check_TCP_fields_in_IPv4_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_TCP_fields_in_IPv6_in_RXD(self):\n \"\"\"\n Check TCP fields in IPv6 in RXD\n \"\"\"\n self.check_TCP_fields_in_IPv6_in_RXD()\n \n+ @skip_unsupported_pkg('os default')\n def test_check_IPv4_IPv6_TCP_fields_in_RXD_on_specific_queues(self):\n \"\"\"\n Check IPv4, IPv6, TCP fields in RXD on specific queues\n", "prefixes": [ "V1", "2/2" ] }{ "id": 89890, "url": "