Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89783/?format=api
{ "id": 89783, "url": "http://patches.dpdk.org/api/patches/89783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210325030139.2486-3-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210325030139.2486-3-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210325030139.2486-3-yong.liu@intel.com", "date": "2021-03-25T03:01:39", "name": "[3/3] vhost: fix potential buffer overflow when batch dequeue", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0b4a137acd29b783d0280339a5fdd193bdb13806", "submitter": { "id": 17, "url": "http://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210325030139.2486-3-yong.liu@intel.com/mbox/", "series": [ { "id": 15393, "url": "http://patches.dpdk.org/api/series/15393/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15393", "date": "2021-02-26T07:33:21", "name": "vhost: fix potential buffer overflow", "version": 1, "mbox": "http://patches.dpdk.org/series/15393/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89783/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EE61DA0A02;\n\tThu, 25 Mar 2021 04:03:53 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 927C1140DA2;\n\tThu, 25 Mar 2021 04:03:49 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 1BE1640147;\n Thu, 25 Mar 2021 04:03:45 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Mar 2021 20:03:39 -0700", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.108])\n by orsmga008.jf.intel.com with ESMTP; 24 Mar 2021 20:03:38 -0700" ], "IronPort-SDR": [ "\n BAEmOzRpN/aWNAxmTXkdlw15s0ozRBeVKy9u5CwG5FEq9OYYkIjhCqUMKX31oRh7c8t7IugRSI\n KKpkVlxXMiUg==", "\n vOsGwhMMcyoL5/j2Ya0AV7AzwWrBRToOIq2XjYmvq1zDlKHTWKN3cZdhaB3YmH7WaX4XRAAtsp\n FB5mDqaoKXzA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9933\"; a=\"177953067\"", "E=Sophos;i=\"5.81,276,1610438400\"; d=\"scan'208\";a=\"177953067\"", "E=Sophos;i=\"5.81,276,1610438400\"; d=\"scan'208\";a=\"415765165\"" ], "X-ExtLoop1": "1", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 25 Mar 2021 11:01:39 +0800", "Message-Id": "<20210325030139.2486-3-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210325030139.2486-1-yong.liu@intel.com>", "References": "<20210226073321.66996-1-yong.liu@intel.com>\n <20210325030139.2486-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/3] vhost: fix potential buffer overflow when\n batch dequeue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Similar as single dequeue, the multiple accesses of descriptor length\nwill lead to potential risk. One-time access of descriptor length can\neliminate this risk.\n\nFixes: 75ed51697820 (\"vhost: add packed ring batch dequeue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex de43686522..0a7d008a91 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -2318,7 +2318,7 @@ vhost_reserve_avail_batch_packed(struct virtio_net *dev,\n \t}\n \n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {\n-\t\tpkts[i]->pkt_len = descs[avail_idx + i].len - buf_offset;\n+\t\tpkts[i]->pkt_len = lens[i] - buf_offset;\n \t\tpkts[i]->data_len = pkts[i]->pkt_len;\n \t\tids[i] = descs[avail_idx + i].id;\n \t}\n", "prefixes": [ "3/3" ] }