Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 8975,
    "url": "http://patches.dpdk.org/api/patches/8975/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1447843689-32315-2-git-send-email-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1447843689-32315-2-git-send-email-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1447843689-32315-2-git-send-email-harry.van.haaren@intel.com",
    "date": "2015-11-18T10:48:07",
    "name": "[dpdk-dev,v2,1/3] e1000: remove crc size from all byte counters",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "71dabd68fd4e3fdc8bf699e220bd31316a7c423f",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1447843689-32315-2-git-send-email-harry.van.haaren@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/8975/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/8975/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 81A798DA1;\n\tWed, 18 Nov 2015 11:48:32 +0100 (CET)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E03E28D99\n\tfor <dev@dpdk.org>; Wed, 18 Nov 2015 11:48:30 +0100 (CET)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP; 18 Nov 2015 02:48:30 -0800",
            "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby orsmga003.jf.intel.com with ESMTP; 18 Nov 2015 02:48:24 -0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.20,312,1444719600\"; d=\"scan'208\";a=\"688363522\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 18 Nov 2015 10:48:07 +0000",
        "Message-Id": "<1447843689-32315-2-git-send-email-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "In-Reply-To": "<1447843689-32315-1-git-send-email-harry.van.haaren@intel.com>",
        "References": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>\n\t<1447843689-32315-1-git-send-email-harry.van.haaren@intel.com>",
        "Cc": "shemming@brocade.com",
        "Subject": "[dpdk-dev] [PATCH v2 1/3] e1000: remove crc size from all byte\n\tcounters",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch removes the crc bytes from byte counter statistics.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/e1000/igb_ethdev.c | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 88995b0..bf4c2a5 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -1480,6 +1480,13 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats)\n {\n \tint pause_frames;\n \n+\tuint64_t old_gprc  = stats->gprc;\n+\tuint64_t old_gptc  = stats->gptc;\n+\tuint64_t old_tpr   = stats->tpr;\n+\tuint64_t old_tpt   = stats->tpt;\n+\tuint64_t old_rpthc = stats->rpthc;\n+\tuint64_t old_hgptc = stats->hgptc;\n+\n \tif(hw->phy.media_type == e1000_media_type_copper ||\n \t    (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) {\n \t\tstats->symerrs +=\n@@ -1521,10 +1528,13 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats)\n \t/* For the 64-bit byte counters the low dword must be read first. */\n \t/* Both registers clear on the read of the high dword */\n \n+\t/* Workaround CRC bytes included in size, take away 4 bytes/packet */\n \tstats->gorc += E1000_READ_REG(hw, E1000_GORCL);\n \tstats->gorc += ((uint64_t)E1000_READ_REG(hw, E1000_GORCH) << 32);\n+\tstats->gorc -= (stats->gprc - old_gprc) * ETHER_CRC_LEN;\n \tstats->gotc += E1000_READ_REG(hw, E1000_GOTCL);\n \tstats->gotc += ((uint64_t)E1000_READ_REG(hw, E1000_GOTCH) << 32);\n+\tstats->gotc -= (stats->gptc - old_gptc) * ETHER_CRC_LEN;\n \n \tstats->rnbc += E1000_READ_REG(hw, E1000_RNBC);\n \tstats->ruc += E1000_READ_REG(hw, E1000_RUC);\n@@ -1532,13 +1542,16 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats)\n \tstats->roc += E1000_READ_REG(hw, E1000_ROC);\n \tstats->rjc += E1000_READ_REG(hw, E1000_RJC);\n \n+\tstats->tpr += E1000_READ_REG(hw, E1000_TPR);\n+\tstats->tpt += E1000_READ_REG(hw, E1000_TPT);\n+\n \tstats->tor += E1000_READ_REG(hw, E1000_TORL);\n \tstats->tor += ((uint64_t)E1000_READ_REG(hw, E1000_TORH) << 32);\n+\tstats->tor -= (stats->tpr - old_tpr) * ETHER_CRC_LEN;\n \tstats->tot += E1000_READ_REG(hw, E1000_TOTL);\n \tstats->tot += ((uint64_t)E1000_READ_REG(hw, E1000_TOTH) << 32);\n+\tstats->tot -= (stats->tpt - old_tpt) * ETHER_CRC_LEN;\n \n-\tstats->tpr += E1000_READ_REG(hw, E1000_TPR);\n-\tstats->tpt += E1000_READ_REG(hw, E1000_TPT);\n \tstats->ptc64 += E1000_READ_REG(hw, E1000_PTC64);\n \tstats->ptc127 += E1000_READ_REG(hw, E1000_PTC127);\n \tstats->ptc255 += E1000_READ_REG(hw, E1000_PTC255);\n@@ -1571,8 +1584,10 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats)\n \tstats->htcbdpc += E1000_READ_REG(hw, E1000_HTCBDPC);\n \tstats->hgorc += E1000_READ_REG(hw, E1000_HGORCL);\n \tstats->hgorc += ((uint64_t)E1000_READ_REG(hw, E1000_HGORCH) << 32);\n+\tstats->hgorc -= (stats->rpthc - old_rpthc) * ETHER_CRC_LEN;\n \tstats->hgotc += E1000_READ_REG(hw, E1000_HGOTCL);\n \tstats->hgotc += ((uint64_t)E1000_READ_REG(hw, E1000_HGOTCH) << 32);\n+\tstats->hgotc -= (stats->hgptc - old_hgptc) * ETHER_CRC_LEN;\n \tstats->lenerrs += E1000_READ_REG(hw, E1000_LENERRS);\n \tstats->scvpc += E1000_READ_REG(hw, E1000_SCVPC);\n \tstats->hrmpc += E1000_READ_REG(hw, E1000_HRMPC);\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "1/3"
    ]
}