Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89725/?format=api
http://patches.dpdk.org/api/patches/89725/?format=api", "web_url": "http://patches.dpdk.org/project/dts/patch/20210324112443.29319-2-weix.xie@intel.com/", "project": { "id": 3, "url": "http://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20210324112443.29319-2-weix.xie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20210324112443.29319-2-weix.xie@intel.com", "date": "2021-03-24T11:24:42", "name": "[1/2] tests/rxtx_offload: adapt to CVL NIC", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "7be65a88728dc60a6e478a2a52e89ddbe7a86b68", "submitter": { "id": 1686, "url": "http://patches.dpdk.org/api/people/1686/?format=api", "name": "Xie, WeiX", "email": "weix.xie@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dts/patch/20210324112443.29319-2-weix.xie@intel.com/mbox/", "series": [ { "id": 15842, "url": "http://patches.dpdk.org/api/series/15842/?format=api", "web_url": "http://patches.dpdk.org/project/dts/list/?series=15842", "date": "2021-03-24T11:24:41", "name": "adapt to CVL NIC", "version": 1, "mbox": "http://patches.dpdk.org/series/15842/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89725/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/89725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1E832A0A0C;\n\tWed, 24 Mar 2021 04:00:37 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9E53640689;\n\tWed, 24 Mar 2021 04:00:36 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 995C940151\n for <dts@dpdk.org>; Wed, 24 Mar 2021 04:00:35 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Mar 2021 20:00:35 -0700", "from unknown (HELO localhost.localdomain) ([10.240.183.103])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Mar 2021 20:00:33 -0700" ], "IronPort-SDR": [ "\n 4nQBPDcUdfqSqwcA3nMpIKi8MpgMTCaTFV8fcxFQMCYTCSdixAhOXOF2Mqjtgxb6VlptD70iro\n u7GLj62bCF+A==", "\n CVCIvcnrL1jzSP54Z78JGtf8NPQ580I2HCAcefMuhu3ND4rOkXrcKtzSC44p5ijCYWVCGNAyRv\n Ct5Y7Du0sTHQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9932\"; a=\"210708945\"", "E=Sophos;i=\"5.81,272,1610438400\"; d=\"scan'208\";a=\"210708945\"", "E=Sophos;i=\"5.81,272,1610438400\"; d=\"scan'208\";a=\"607958927\"" ], "From": "xiewei <weix.xie@intel.com>", "To": "dts@dpdk.org", "Cc": "xiewei <weix.xie@intel.com>", "Date": "Wed, 24 Mar 2021 19:24:42 +0800", "Message-Id": "<20210324112443.29319-2-weix.xie@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210324112443.29319-1-weix.xie@intel.com>", "References": "<20210324112443.29319-1-weix.xie@intel.com>", "Subject": "[dts] [PATCH 1/2] tests/rxtx_offload: adapt to CVL NIC", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "for CVL NIC,\na.rxtx_offload/rxoffload_port: disable jumboframe per-queue will change the RSS key, then pkt can be distributed to queues by RSS.\nb.rxtx_offload/txoffload_queue: it failed to enable mbuf_fast_free per_queue.\n\nSigned-off-by: xiewei <weix.xie@intel.com>\n---\n tests/TestSuite_rxtx_offload.py | 23 ++++++++++++++++++-----\n 1 file changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/tests/TestSuite_rxtx_offload.py b/tests/TestSuite_rxtx_offload.py\nindex 0e70526f..f7481089 100644\n--- a/tests/TestSuite_rxtx_offload.py\n+++ b/tests/TestSuite_rxtx_offload.py\n@@ -314,7 +314,10 @@ class TestRxTx_Offload(TestCase):\n scanner = re.compile(result_scanner, re.DOTALL)\n m = scanner.search(outstring)\n queue_id = m.group(1)\n- self.verify(int(expect_queue) == int(queue_id), \"the offload setting doesn't take effect.\")\n+ if self.nic in ['columbiaville_25g', 'columbiaville_100g']:\n+ self.verify(int(queue_id) in [0, 1, 2, 3], \"the offload setting doesn't take effect.\")\n+ else:\n+ self.verify(int(expect_queue) == int(queue_id), \"the offload setting doesn't take effect.\")\n \n def start_tcpdump(self, rxItf):\n \n@@ -346,10 +349,16 @@ class TestRxTx_Offload(TestCase):\n pkt2_queue = self.get_queue_number(self.jumbo_pkt2)\n \n # Failed to disable jumboframe per_queue, foxvillee 2.5g not support\n- if self.nic != 'foxville':\n+ if self.nic in ['columbiaville_25g', 'columbiaville_100g']:\n self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n- self.dut.send_expect(\"port 0 rxq %s rx_offload jumbo_frame off\" % pkt1_queue, \"testpmd> \")\n+ for i in range(4):\n+ self.dut.send_expect(\"port 0 rxq %s rx_offload jumbo_frame off\" % i, \"testpmd> \")\n self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)\n+ else:\n+ if self.nic != 'foxville':\n+ self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n+ self.dut.send_expect(\"port 0 rxq %s rx_offload jumbo_frame off\" % pkt1_queue, \"testpmd> \")\n+ self.verify_result(self.jumbo_pkt1, 1, pkt1_queue)\n \n # Succeed to disable jumboframe per_port\n self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n@@ -698,8 +707,12 @@ class TestRxTx_Offload(TestCase):\n self.dut.send_expect(\"port 0 txq 1 tx_offload mbuf_fast_free on\", \"testpmd> \")\n self.dut.send_expect(\"port 0 txq 2 tx_offload mbuf_fast_free on\", \"testpmd> \")\n self.dut.send_expect(\"port 0 txq 3 tx_offload mbuf_fast_free on\", \"testpmd> \")\n- offload = [\"mbuf_fast_free\", \"mbuf_fast_free\", \"mbuf_fast_free\", \"mbuf_fast_free\"]\n- self.check_queue_config(\"tx\", offload)\n+ if self.nic in ['columbiaville_25g', 'columbiaville_100g']:\n+ out = self.dut.send_expect(\"port start 0\", \"testpmd> \")\n+ self.verify(\"Fail to configure port 0 tx queues\" in out, \"mbuf_fast_free can be set by queue.\")\n+ else:\n+ offload = [\"mbuf_fast_free\", \"mbuf_fast_free\", \"mbuf_fast_free\", \"mbuf_fast_free\"]\n+ self.check_queue_config(\"tx\", offload)\n \n # Disable mbuf_fast_free per_queue.\n self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n", "prefixes": [ "1/2" ] }{ "id": 89725, "url": "