Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89678/?format=api
{ "id": 89678, "url": "http://patches.dpdk.org/api/patches/89678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210323101928.2403-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210323101928.2403-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210323101928.2403-3-david.marchand@redhat.com", "date": "2021-03-23T10:19:27", "name": "[2/3] log: track log level changes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5bddd0289652411961ecb644f68c433cb0124c71", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210323101928.2403-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 15828, "url": "http://patches.dpdk.org/api/series/15828/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15828", "date": "2021-03-23T10:19:25", "name": "Track log level changes", "version": 1, "mbox": "http://patches.dpdk.org/series/15828/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89678/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7A41BA0562;\n\tTue, 23 Mar 2021 11:20:17 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 94301140D08;\n\tTue, 23 Mar 2021 11:20:14 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 74514140D1C\n for <dev@dpdk.org>; Tue, 23 Mar 2021 11:20:13 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-254-939x4Lb2OrqbRU11foW8SA-1; Tue, 23 Mar 2021 06:20:09 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20B951084D6B;\n Tue, 23 Mar 2021 10:20:08 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.233])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 96EE960C5D;\n Tue, 23 Mar 2021 10:20:06 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1616494813;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6DWuOrUyy1Cj7YM8SMgLF5eavLKDDw+SH2P4CmtfuC8=;\n b=g26/vijmWQLB3XGj2kW4ff5Abea3flTwTJCWhQTH96kBipFHVSpIgt11zFRDaUNbVKNbiV\n 2Wegcpx50+e89pkBqugdMftBGmqc43Qh5a98fKER02PRVIjVE8HdLvPhX2SCCzLITXGTDC\n jQ95wsQAeoaqLqPVOU9cSE+ahfjG28Q=", "X-MC-Unique": "939x4Lb2OrqbRU11foW8SA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "arybchenko@solarflare.com, l.wojciechow@partner.samsung.com,\n Ilya Maximets <i.maximets@ovn.org>", "Date": "Tue, 23 Mar 2021 11:19:27 +0100", "Message-Id": "<20210323101928.2403-3-david.marchand@redhat.com>", "In-Reply-To": "<20210323101928.2403-1-david.marchand@redhat.com>", "References": "<20200626114751.22523-1-david.marchand@redhat.com>\n <20210323101928.2403-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 2/3] log: track log level changes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add a log message when changing log levels.\n\nExample:\n$ DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 \\\n --log-level=lib.eal:debug\n...\nRTE>>logs_autotest\n== dynamic log types\nEAL: logtype1 logtype level changed from disabled to info\nEAL: logtype2 logtype level changed from disabled to info\nEAL: logtype1 logtype level changed from info to error\nEAL: logtype3 logtype level changed from error to emerg\nEAL: logtype2 logtype level changed from info to emerg\nEAL: logtype3 logtype level changed from emerg to debug\nEAL: logtype1 logtype level changed from error to debug\nEAL: logtype2 logtype level changed from emerg to debug\nerror message\ncritical message\ncritical message\nerror message\n== static log types\nTESTAPP1: error message\nTESTAPP1: critical message\nTESTAPP2: critical message\nTESTAPP1: error message\nTest OK\n\nSuggested-by: Ilya Maximets <i.maximets@ovn.org>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>\n---\n lib/librte_eal/common/eal_common_log.c | 113 +++++++++++++------------\n 1 file changed, 58 insertions(+), 55 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex c5554badb2..b64a1b9381 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -135,6 +135,38 @@ rte_log_can_log(uint32_t logtype, uint32_t level)\n \treturn true;\n }\n \n+static const char *\n+loglevel_to_string(uint32_t level)\n+{\n+\tswitch (level) {\n+\tcase 0: return \"disabled\";\n+\tcase RTE_LOG_EMERG: return \"emerg\";\n+\tcase RTE_LOG_ALERT: return \"alert\";\n+\tcase RTE_LOG_CRIT: return \"critical\";\n+\tcase RTE_LOG_ERR: return \"error\";\n+\tcase RTE_LOG_WARNING: return \"warning\";\n+\tcase RTE_LOG_NOTICE: return \"notice\";\n+\tcase RTE_LOG_INFO: return \"info\";\n+\tcase RTE_LOG_DEBUG: return \"debug\";\n+\tdefault: return \"unknown\";\n+\t}\n+}\n+\n+static void\n+logtype_set_level(uint32_t type, uint32_t level)\n+{\n+\tuint32_t current = rte_logs.dynamic_types[type].loglevel;\n+\n+\tif (current != level) {\n+\t\trte_logs.dynamic_types[type].loglevel = level;\n+\t\tRTE_LOG(DEBUG, EAL, \"%s logtype level changed from %s to %s\\n\",\n+\t\t\trte_logs.dynamic_types[type].name == NULL ?\n+\t\t\t\t\"\" : rte_logs.dynamic_types[type].name,\n+\t\t\tloglevel_to_string(current),\n+\t\t\tloglevel_to_string(level));\n+\t}\n+}\n+\n int\n rte_log_set_level(uint32_t type, uint32_t level)\n {\n@@ -143,7 +175,7 @@ rte_log_set_level(uint32_t type, uint32_t level)\n \tif (level > RTE_LOG_DEBUG)\n \t\treturn -1;\n \n-\trte_logs.dynamic_types[type].loglevel = level;\n+\tlogtype_set_level(type, level);\n \n \treturn 0;\n }\n@@ -166,7 +198,7 @@ rte_log_set_level_regexp(const char *regex, uint32_t level)\n \t\t\tcontinue;\n \t\tif (regexec(&r, rte_logs.dynamic_types[i].name, 0,\n \t\t\t\tNULL, 0) == 0)\n-\t\t\trte_logs.dynamic_types[i].loglevel = level;\n+\t\t\tlogtype_set_level(i, level);\n \t}\n \n \tregfree(&r);\n@@ -226,7 +258,7 @@ rte_log_set_level_pattern(const char *pattern, uint32_t level)\n \t\t\tcontinue;\n \n \t\tif (fnmatch(pattern, rte_logs.dynamic_types[i].name, 0) == 0)\n-\t\t\trte_logs.dynamic_types[i].loglevel = level;\n+\t\t\tlogtype_set_level(i, level);\n \t}\n \n \treturn 0;\n@@ -264,29 +296,11 @@ rte_log_lookup(const char *name)\n \treturn -1;\n }\n \n-/* register an extended log type, assuming table is large enough, and id\n- * is not yet registered.\n- */\n static int\n-__rte_log_register(const char *name, int id)\n-{\n-\tchar *dup_name = strdup(name);\n-\n-\tif (dup_name == NULL)\n-\t\treturn -ENOMEM;\n-\n-\trte_logs.dynamic_types[id].name = dup_name;\n-\trte_logs.dynamic_types[id].loglevel = RTE_LOG_INFO;\n-\n-\treturn id;\n-}\n-\n-/* register an extended log type */\n-int\n-rte_log_register(const char *name)\n+__rte_log_register(const char *name, uint32_t level)\n {\n \tstruct rte_log_dynamic_type *new_dynamic_types;\n-\tint id, ret;\n+\tint id;\n \n \tid = rte_log_lookup(name);\n \tif (id >= 0)\n@@ -299,13 +313,24 @@ rte_log_register(const char *name)\n \t\treturn -ENOMEM;\n \trte_logs.dynamic_types = new_dynamic_types;\n \n-\tret = __rte_log_register(name, rte_logs.dynamic_types_len);\n-\tif (ret < 0)\n-\t\treturn ret;\n+\tid = rte_logs.dynamic_types_len;\n+\tmemset(&rte_logs.dynamic_types[id], 0,\n+\t\tsizeof(rte_logs.dynamic_types[id]));\n+\trte_logs.dynamic_types[id].name = strdup(name);\n+\tif (rte_logs.dynamic_types[id].name == NULL)\n+\t\treturn -ENOMEM;\n+\tlogtype_set_level(id, level);\n \n \trte_logs.dynamic_types_len++;\n \n-\treturn ret;\n+\treturn id;\n+}\n+\n+/* register an extended log type */\n+int\n+rte_log_register(const char *name)\n+{\n+\treturn __rte_log_register(name, RTE_LOG_INFO);\n }\n \n /* Register an extended log type and try to pick its level from EAL options */\n@@ -314,11 +339,6 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)\n {\n \tstruct rte_eal_opt_loglevel *opt_ll;\n \tuint32_t level = level_def;\n-\tint type;\n-\n-\ttype = rte_log_register(name);\n-\tif (type < 0)\n-\t\treturn type;\n \n \tTAILQ_FOREACH(opt_ll, &opt_loglevel_list, next) {\n \t\tif (opt_ll->level > RTE_LOG_DEBUG)\n@@ -333,9 +353,7 @@ rte_log_register_type_and_pick_level(const char *name, uint32_t level_def)\n \t\t}\n \t}\n \n-\trte_logs.dynamic_types[type].loglevel = level;\n-\n-\treturn type;\n+\treturn __rte_log_register(name, level);\n }\n \n struct logtype {\n@@ -388,30 +406,15 @@ RTE_INIT_PRIO(rte_log_init, LOG)\n \t\treturn;\n \n \t/* register legacy log types */\n-\tfor (i = 0; i < RTE_DIM(logtype_strings); i++)\n-\t\t__rte_log_register(logtype_strings[i].logtype,\n-\t\t\t\tlogtype_strings[i].log_id);\n+\tfor (i = 0; i < RTE_DIM(logtype_strings); i++) {\n+\t\trte_logs.dynamic_types[logtype_strings[i].log_id].name =\n+\t\t\tstrdup(logtype_strings[i].logtype);\n+\t\tlogtype_set_level(logtype_strings[i].log_id, RTE_LOG_INFO);\n+\t}\n \n \trte_logs.dynamic_types_len = RTE_LOGTYPE_FIRST_EXT_ID;\n }\n \n-static const char *\n-loglevel_to_string(uint32_t level)\n-{\n-\tswitch (level) {\n-\tcase 0: return \"disabled\";\n-\tcase RTE_LOG_EMERG: return \"emerg\";\n-\tcase RTE_LOG_ALERT: return \"alert\";\n-\tcase RTE_LOG_CRIT: return \"critical\";\n-\tcase RTE_LOG_ERR: return \"error\";\n-\tcase RTE_LOG_WARNING: return \"warning\";\n-\tcase RTE_LOG_NOTICE: return \"notice\";\n-\tcase RTE_LOG_INFO: return \"info\";\n-\tcase RTE_LOG_DEBUG: return \"debug\";\n-\tdefault: return \"unknown\";\n-\t}\n-}\n-\n /* dump global level and registered log types */\n void\n rte_log_dump(FILE *f)\n", "prefixes": [ "2/3" ] }