Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89677/?format=api
{ "id": 89677, "url": "http://patches.dpdk.org/api/patches/89677/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210323101928.2403-2-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210323101928.2403-2-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210323101928.2403-2-david.marchand@redhat.com", "date": "2021-03-23T10:19:26", "name": "[1/3] test/log: check levels", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ab7c9bcc34d1c5074dff4b8499bffb74c1455124", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210323101928.2403-2-david.marchand@redhat.com/mbox/", "series": [ { "id": 15828, "url": "http://patches.dpdk.org/api/series/15828/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15828", "date": "2021-03-23T10:19:25", "name": "Track log level changes", "version": 1, "mbox": "http://patches.dpdk.org/series/15828/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89677/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89677/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 098A6A0562;\n\tTue, 23 Mar 2021 11:20:05 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E302B140D17;\n\tTue, 23 Mar 2021 11:20:04 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by mails.dpdk.org (Postfix) with ESMTP id 9CA82140D04\n for <dev@dpdk.org>; Tue, 23 Mar 2021 11:20:02 +0100 (CET)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-405--exyjwGGOpqKp12D_bVJRQ-1; Tue, 23 Mar 2021 06:19:59 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E6F383DD22;\n Tue, 23 Mar 2021 10:19:58 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.193.233])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 9483A437F;\n Tue, 23 Mar 2021 10:19:57 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1616494801;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=CWPw8sCxC6Yj1hO/7SS47M5XEGCV1AWq4ZpIMSacwQA=;\n b=YIi7HFxGpGIvczF8bmbgO21Mpio3bhHDIQJOOx6jHUCNh7/neOxya81NbzBCfJdRPWfZLA\n 7sPcRIf4F8uLcRPraM0ZdpKcaTjHabEL0uyYPA42K/p6zBx4YMT2NopApwdgmSA5oRYSZX\n WXKPGeI/1nyNifOgAGwmlIovDc8Cmog=", "X-MC-Unique": "-exyjwGGOpqKp12D_bVJRQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "arybchenko@solarflare.com,\n\tl.wojciechow@partner.samsung.com", "Date": "Tue, 23 Mar 2021 11:19:26 +0100", "Message-Id": "<20210323101928.2403-2-david.marchand@redhat.com>", "In-Reply-To": "<20210323101928.2403-1-david.marchand@redhat.com>", "References": "<20200626114751.22523-1-david.marchand@redhat.com>\n <20210323101928.2403-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/3] test/log: check levels", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add checks on log levels:\n- default values for rte_log_register and RTE_LOG_REGISTER,\n- level changes with rte_log_set_level and consorts\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_logs.c | 53 +++++++++++++++++++++++++++++++++++++++++---\n 1 file changed, 50 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_logs.c b/app/test/test_logs.c\nindex 425ae03cb9..db754465c0 100644\n--- a/app/test/test_logs.c\n+++ b/app/test/test_logs.c\n@@ -20,6 +20,10 @@\n #define RTE_LOGTYPE_TESTAPP1 RTE_LOGTYPE_USER1\n #define RTE_LOGTYPE_TESTAPP2 RTE_LOGTYPE_USER2\n \n+static int logtype1;\n+static int logtype2;\n+RTE_LOG_REGISTER(logtype3, logtype3, ERR)\n+\n /*\n * Logs\n * ====\n@@ -61,9 +65,24 @@ test_legacy_logs(void)\n static int\n test_logs(void)\n {\n-\tint logtype1, logtype2;\n \tint ret;\n \n+#define CHECK_LEVELS(exp_logtype1, exp_logtype2, exp_logtype3) do \\\n+{ \\\n+\tret = rte_log_get_level(logtype1); \\\n+\tTEST_ASSERT_EQUAL(ret, exp_logtype1, \\\n+\t\t\"%s:%d, invalid level for logtype1 %d, expecting %d\\n\", \\\n+\t\t__FILE__, __LINE__, ret, exp_logtype1); \\\n+\tret = rte_log_get_level(logtype2); \\\n+\tTEST_ASSERT_EQUAL(ret, exp_logtype2, \\\n+\t\t\"%s:%d, invalid level for logtype2 %d, expecting %d\\n\", \\\n+\t\t__FILE__, __LINE__, ret, exp_logtype2); \\\n+\tret = rte_log_get_level(logtype3); \\\n+\tTEST_ASSERT_EQUAL(ret, exp_logtype3, \\\n+\t\t\"%s:%d, invalid level for logtype3 %d, expecting %d\\n\", \\\n+\t\t__FILE__, __LINE__, ret, exp_logtype3); \\\n+} while (0)\n+\n \tprintf(\"== dynamic log types\\n\");\n \n \tlogtype1 = rte_log_register(\"logtype1\");\n@@ -71,15 +90,41 @@ test_logs(void)\n \t\tprintf(\"Cannot register logtype1\\n\");\n \t\treturn -1;\n \t}\n+\tret = rte_log_get_level(logtype1);\n+\tTEST_ASSERT_EQUAL(ret, RTE_LOG_INFO,\n+\t\t\"invalid default level for logtype1 %d, expecting %d\\n\",\n+\t\tret, RTE_LOG_INFO);\n+\n \tlogtype2 = rte_log_register(\"logtype2\");\n \tif (logtype2 < 0) {\n \t\tprintf(\"Cannot register logtype2\\n\");\n \t\treturn -1;\n \t}\n+\tret = rte_log_get_level(logtype2);\n+\tTEST_ASSERT_EQUAL(ret, RTE_LOG_INFO,\n+\t\t\"invalid default level for logtype2 %d, expecting %d\\n\",\n+\t\tret, RTE_LOG_INFO);\n+\n+\tret = rte_log_get_level(logtype3);\n+\tTEST_ASSERT_EQUAL(ret, RTE_LOG_ERR,\n+\t\t\"invalid default level for logtype3 %d, expecting %d\\n\",\n+\t\tret, RTE_LOG_ERR);\n+\n+\trte_log_set_level(logtype1, RTE_LOG_ERR);\n+\tCHECK_LEVELS(RTE_LOG_ERR, RTE_LOG_INFO, RTE_LOG_ERR);\n+\n+\trte_log_set_level_regexp(\"type$\", RTE_LOG_EMERG);\n+\tCHECK_LEVELS(RTE_LOG_ERR, RTE_LOG_INFO, RTE_LOG_ERR);\n+\n+\trte_log_set_level_regexp(\"type[23]\", RTE_LOG_EMERG);\n+\tCHECK_LEVELS(RTE_LOG_ERR, RTE_LOG_EMERG, RTE_LOG_EMERG);\n+\n+\trte_log_set_level_pattern(\"logtype\", RTE_LOG_DEBUG);\n+\tCHECK_LEVELS(RTE_LOG_ERR, RTE_LOG_EMERG, RTE_LOG_EMERG);\n \n \t/* set logtype level low to so we can test global level */\n-\trte_log_set_level(logtype1, RTE_LOG_DEBUG);\n-\trte_log_set_level(logtype2, RTE_LOG_DEBUG);\n+\trte_log_set_level_pattern(\"logtype*\", RTE_LOG_DEBUG);\n+\tCHECK_LEVELS(RTE_LOG_DEBUG, RTE_LOG_DEBUG, RTE_LOG_DEBUG);\n \n \t/* log in error level */\n \trte_log_set_global_level(RTE_LOG_ERR);\n@@ -103,6 +148,8 @@ test_logs(void)\n \tif (ret < 0)\n \t\treturn ret;\n \n+#undef CHECK_LEVELS\n+\n \treturn 0;\n }\n \n", "prefixes": [ "1/3" ] }