Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89508/?format=api
{ "id": 89508, "url": "http://patches.dpdk.org/api/patches/89508/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210318195213.683281-1-lance.richardson@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210318195213.683281-1-lance.richardson@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210318195213.683281-1-lance.richardson@broadcom.com", "date": "2021-03-18T19:52:13", "name": "[1/1] net/bnxt: fix Rx buffer posting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f8261a6db4ea3fb76dfe45a2840f0acf1772978a", "submitter": { "id": 1323, "url": "http://patches.dpdk.org/api/people/1323/?format=api", "name": "Lance Richardson", "email": "lance.richardson@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210318195213.683281-1-lance.richardson@broadcom.com/mbox/", "series": [ { "id": 15777, "url": "http://patches.dpdk.org/api/series/15777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15777", "date": "2021-03-18T19:52:13", "name": "[1/1] net/bnxt: fix Rx buffer posting", "version": 1, "mbox": "http://patches.dpdk.org/series/15777/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89508/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B48EFA0561;\n\tThu, 18 Mar 2021 20:52:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 344B1140F27;\n\tThu, 18 Mar 2021 20:52:21 +0100 (CET)", "from mail-pj1-f49.google.com (mail-pj1-f49.google.com\n [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 300AF40698\n for <dev@dpdk.org>; Thu, 18 Mar 2021 20:52:19 +0100 (CET)", "by mail-pj1-f49.google.com with SMTP id\n f2-20020a17090a4a82b02900c67bf8dc69so5563217pjh.1\n for <dev@dpdk.org>; Thu, 18 Mar 2021 12:52:19 -0700 (PDT)", "from localhost.localdomain ([192.19.231.250])\n by smtp.gmail.com with ESMTPSA id c193sm3318237pfc.180.2021.03.18.12.52.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 18 Mar 2021 12:52:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:mime-version;\n bh=gJ4Iw32LyEJoCXhlbZkYrXPVVlRIOQ6XNf7siOOC8tU=;\n b=VJr9rbFmJzRycW+dZLsQYQhZk+ddC9VeTpIrW1B9KNepIj7J9uuzgOuLQa1PAl1c4U\n 6ZLYUGghnRXzV3fQWsWPG6QCTnuzYfBlSfmKck8jgsn1IVe7vww8j+R3nRps/evyhho3\n 8N9CnI4nhE53d0eTBj0RYLIxAHHnTDzUTttB8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version;\n bh=gJ4Iw32LyEJoCXhlbZkYrXPVVlRIOQ6XNf7siOOC8tU=;\n b=tYFTLDURoho/22rd3YzCKtRGtQqfcvyRa4jC+scgLpQ5wRMq7MEX6+6C/PGaQPmt7/\n JyukmxgXokLdlJZrBWu/VfYB7XflHq6YQg8tWtf6w3Q1wd7aB1c3IH/8tCqS21I8QZRk\n YC/ZYhHNW0jMspVyGlirPmHGEySJwnlx+uWbUPm36EmUxBsgk5bQ1JSMOuOvWwihLW4K\n 7lgKibFh5kt355mSW7soeXlhF2IamOdoWc5jiorMR56llecXzmn7+9DXXHH4MdcKlS39\n 5xPQUwN8nuy+l1jc+/muSnqQT344xa/+KC9dDMF8cL2rsdMPzdeYDbACYsEP3/K0GUGs\n xVQA==", "X-Gm-Message-State": "AOAM5319uSy1BWtZHHgy5Xy1mljf8nomhMkILUH5iIAesSxo2yIw8Vm8\n sK6emznUUCZgAZ2+Jxk7L4z1/g==", "X-Google-Smtp-Source": "\n ABdhPJxYMCdWbjOgZCye+TOO+cn2lQLK+zlrjS/dmOltrtVTuSmN0bllYQQBIC0TkLNL0yd/blY3og==", "X-Received": "by 2002:a17:90a:9f4a:: with SMTP id\n q10mr6075578pjv.129.1616097138189;\n Thu, 18 Mar 2021 12:52:18 -0700 (PDT)", "From": "Lance Richardson <lance.richardson@broadcom.com>", "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>", "Cc": "dev@dpdk.org,\n\tstable@dpdk.org", "Date": "Thu, 18 Mar 2021 15:52:13 -0400", "Message-Id": "<20210318195213.683281-1-lance.richardson@broadcom.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000dd827a05bdd4eff1\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.29", "Subject": "[dpdk-dev] [PATCH 1/1] net/bnxt: fix Rx buffer posting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove early buffer posting logic from burst receive loop to address\nseveral issues:\n - Posting receive descriptors without first posting completion\n entries risks overflowing the completion queue.\n - Posting receive descriptors without updating rx_raw_prod\n creates the possibility that the receive descriptor doorbell\n can be written twice with the same value.\n - Having this logic in the inner descriptor processing loop\n can impact performance.\n\nFixes: 637e34befd9c (\"net/bnxt: optimize Rx processing\")\nFixes: 04067844a3e9 (\"net/bnxt: reduce CQ queue size without aggregation ring\")\nCc: stable@dpdk.org\n\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_rxr.c | 3 ---\n drivers/net/bnxt/bnxt_rxr.h | 2 --\n 2 files changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex c72545ada7..7179c6cb30 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -1018,9 +1018,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\traw_cons = NEXT_RAW_CMP(raw_cons);\n \t\tif (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)\n \t\t\tbreak;\n-\t\t/* Post some Rx buf early in case of larger burst processing */\n-\t\tif (nb_rx_pkts == BNXT_RX_POST_THRESH)\n-\t\t\tbnxt_db_write(&rxr->rx_db, rxr->rx_raw_prod);\n \t}\n \n \tcpr->cp_raw_cons = raw_cons;\ndiff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h\nindex a6fdd7767a..b43256e03e 100644\n--- a/drivers/net/bnxt/bnxt_rxr.h\n+++ b/drivers/net/bnxt/bnxt_rxr.h\n@@ -41,8 +41,6 @@ static inline uint16_t bnxt_tpa_start_agg_id(struct bnxt *bp,\n \t(((cmp)->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK) >> \\\n \t\tRX_PKT_CMPL_AGG_BUFS_SFT)\n \n-#define BNXT_RX_POST_THRESH\t32\n-\n /* Number of descriptors to process per inner loop in vector mode. */\n #define RTE_BNXT_DESCS_PER_LOOP\t\t4U\n \n", "prefixes": [ "1/1" ] }