Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8944/?format=api
{ "id": 8944, "url": "http://patches.dpdk.org/api/patches/8944/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1447670117-17723-4-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1447670117-17723-4-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1447670117-17723-4-git-send-email-harry.van.haaren@intel.com", "date": "2015-11-16T10:35:16", "name": "[dpdk-dev,3/4] i40e: fix rx/tx size mismatch, remove crc bytes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "184802a6063bd9cd07bd44454fda9ffcbe7c09af", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1447670117-17723-4-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/8944/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/8944/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E43AC5A69;\n\tMon, 16 Nov 2015 11:35:42 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 3D9E75937\n\tfor <dev@dpdk.org>; Mon, 16 Nov 2015 11:35:40 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Nov 2015 02:35:40 -0800", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby fmsmga002.fm.intel.com with ESMTP; 16 Nov 2015 02:35:38 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,302,1444719600\"; d=\"scan'208\";a=\"851905803\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 16 Nov 2015 10:35:16 +0000", "Message-Id": "<1447670117-17723-4-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>", "Cc": "shemming@brocade.com", "Subject": "[dpdk-dev] [PATCH 3/4] i40e: fix rx/tx size mismatch,\n\tremove crc bytes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch removes the crc bytes from byte counter statistics.\n\nDoing so fixes a bug that CRC bytes were included on TX but not\non RX, causing mismatch of bytes recieved / sent.\n\nFixes: 9aace75fc82e (\"i40e: fix statistics\")\n\nReported-by: Weichun Chen <weichunx.chen@intel.com>\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 33 ++++++++++++++++++++++-----------\n 1 file changed, 22 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 2c51a0b..c0c268d 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1870,11 +1870,11 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \tunsigned int i;\n \tstruct i40e_hw_port_stats *ns = &pf->stats; /* new stats */\n \tstruct i40e_hw_port_stats *os = &pf->stats_offset; /* old stats */\n-\t/* Get statistics of struct i40e_eth_stats */\n-\ti40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port),\n-\t\t\t I40E_GLPRT_GORCL(hw->port),\n-\t\t\t pf->offset_loaded, &os->eth.rx_bytes,\n-\t\t\t &ns->eth.rx_bytes);\n+\n+\t/* Workaround: CRC size should not be included in byte statistics,\n+\t * so we add 4 bytes to the offset, causing the resulting byte\n+\t * counters to be 4 bytes smaller.\n+\t */\n \ti40e_stat_update_48(hw, I40E_GLPRT_UPRCH(hw->port),\n \t\t\t I40E_GLPRT_UPRCL(hw->port),\n \t\t\t pf->offset_loaded, &os->eth.rx_unicast,\n@@ -1887,6 +1887,15 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \t\t\t I40E_GLPRT_BPRCL(hw->port),\n \t\t\t pf->offset_loaded, &os->eth.rx_broadcast,\n \t\t\t &ns->eth.rx_broadcast);\n+\n+\t/* Get statistics of struct i40e_eth_stats */\n+\ti40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port),\n+\t\t\t I40E_GLPRT_GORCL(hw->port),\n+\t\t\t pf->offset_loaded, &os->eth.rx_bytes,\n+\t\t\t &ns->eth.rx_bytes);\n+\tns->eth.rx_bytes -= (ns->eth.rx_unicast + ns->eth.rx_multicast +\n+\t\tns->eth.rx_broadcast) * 4;\n+\n \ti40e_stat_update_32(hw, I40E_GLPRT_RDPC(hw->port),\n \t\t\t pf->offset_loaded, &os->eth.rx_discards,\n \t\t\t &ns->eth.rx_discards);\n@@ -1896,10 +1905,6 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \t\t\t pf->offset_loaded,\n \t\t\t &os->eth.rx_unknown_protocol,\n \t\t\t &ns->eth.rx_unknown_protocol);\n-\ti40e_stat_update_48(hw, I40E_GLPRT_GOTCH(hw->port),\n-\t\t\t I40E_GLPRT_GOTCL(hw->port),\n-\t\t\t pf->offset_loaded, &os->eth.tx_bytes,\n-\t\t\t &ns->eth.tx_bytes);\n \ti40e_stat_update_48(hw, I40E_GLPRT_UPTCH(hw->port),\n \t\t\t I40E_GLPRT_UPTCL(hw->port),\n \t\t\t pf->offset_loaded, &os->eth.tx_unicast,\n@@ -1912,6 +1917,12 @@ i40e_read_stats_registers(struct i40e_pf *pf, struct i40e_hw *hw)\n \t\t\t I40E_GLPRT_BPTCL(hw->port),\n \t\t\t pf->offset_loaded, &os->eth.tx_broadcast,\n \t\t\t &ns->eth.tx_broadcast);\n+\ti40e_stat_update_48(hw, I40E_GLPRT_GOTCH(hw->port),\n+\t\t\t I40E_GLPRT_GOTCL(hw->port),\n+\t\t\t pf->offset_loaded, &os->eth.tx_bytes,\n+\t\t\t &ns->eth.tx_bytes);\n+\tns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +\n+\t\tns->eth.tx_broadcast) * 4;\n \t/* GLPRT_TEPC not supported */\n \n \t/* additional port specific stats */\n@@ -2069,8 +2080,8 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \tstats->opackets = pf->main_vsi->eth_stats.tx_unicast +\n \t\t\tpf->main_vsi->eth_stats.tx_multicast +\n \t\t\tpf->main_vsi->eth_stats.tx_broadcast;\n-\tstats->ibytes = pf->main_vsi->eth_stats.rx_bytes;\n-\tstats->obytes = pf->main_vsi->eth_stats.tx_bytes;\n+\tstats->ibytes = ns->eth.rx_bytes;\n+\tstats->obytes = ns->eth.tx_bytes;\n \tstats->oerrors = ns->eth.tx_errors +\n \t\t\tpf->main_vsi->eth_stats.tx_errors;\n \tstats->imcasts = pf->main_vsi->eth_stats.rx_multicast;\n", "prefixes": [ "dpdk-dev", "3/4" ] }