Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/8943/?format=api
{ "id": 8943, "url": "http://patches.dpdk.org/api/patches/8943/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1447670117-17723-3-git-send-email-harry.van.haaren@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1447670117-17723-3-git-send-email-harry.van.haaren@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1447670117-17723-3-git-send-email-harry.van.haaren@intel.com", "date": "2015-11-16T10:35:15", "name": "[dpdk-dev,2/4] ixgbe: remove crc size from all byte counters", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "46642e82107e382a3cb201138d052504fb83bca4", "submitter": { "id": 317, "url": "http://patches.dpdk.org/api/people/317/?format=api", "name": "Van Haaren, Harry", "email": "harry.van.haaren@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1447670117-17723-3-git-send-email-harry.van.haaren@intel.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/8943/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/8943/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 25F605A31;\n\tMon, 16 Nov 2015 11:35:42 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 7A1F55937\n\tfor <dev@dpdk.org>; Mon, 16 Nov 2015 11:35:39 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 16 Nov 2015 02:35:39 -0800", "from sie-lab-212-222.ir.intel.com (HELO\n\tsilpixa00366884.ir.intel.com) ([10.237.212.222])\n\tby fmsmga002.fm.intel.com with ESMTP; 16 Nov 2015 02:35:37 -0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.20,302,1444719600\"; d=\"scan'208\";a=\"851905791\"", "From": "Harry van Haaren <harry.van.haaren@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 16 Nov 2015 10:35:15 +0000", "Message-Id": "<1447670117-17723-3-git-send-email-harry.van.haaren@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>", "References": "<1447670117-17723-1-git-send-email-harry.van.haaren@intel.com>", "Cc": "shemming@brocade.com", "Subject": "[dpdk-dev] [PATCH 2/4] ixgbe: remove crc size from all byte counters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch removes the crc bytes from byte counter statistics.\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 47 ++++++++++++++++++++++++++++++----------\n 1 file changed, 35 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 80801f0..3ccfd89 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -2331,12 +2331,14 @@ ixgbe_dev_close(struct rte_eth_dev *dev)\n }\n \n static void\n-ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n-\t\t\t\t\t\t *hw_stats, uint64_t *total_missed_rx,\n-\t\t\t\t\t\t uint64_t *total_qbrc, uint64_t *total_qprc,\n-\t\t\t\t\t\t uint64_t *total_qprdc)\n+ixgbe_read_stats_registers(struct ixgbe_hw *hw,\n+\t\t\t struct ixgbe_hw_stats *hw_stats,\n+\t\t\t uint64_t *total_missed_rx, uint64_t *total_qbrc,\n+\t\t\t uint64_t *total_qprc, uint64_t *total_qprdc)\n {\n \tuint32_t bprc, lxon, lxoff, total;\n+\tuint32_t delta_gprc = 0;\n+\tuint32_t delta_gptc = 0;\n \tunsigned i;\n \n \thw_stats->crcerrs += IXGBE_READ_REG(hw, IXGBE_CRCERRS);\n@@ -2372,26 +2374,41 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \t\t IXGBE_READ_REG(hw, IXGBE_PXOFFTXC(i));\n \t}\n \tfor (i = 0; i < IXGBE_QUEUE_STAT_COUNTERS; i++) {\n-\t\thw_stats->qprc[i] += IXGBE_READ_REG(hw, IXGBE_QPRC(i));\n-\t\thw_stats->qptc[i] += IXGBE_READ_REG(hw, IXGBE_QPTC(i));\n+\t\tuint32_t delta_qprc = IXGBE_READ_REG(hw, IXGBE_QPRC(i));\n+\t\tuint32_t delta_qptc = IXGBE_READ_REG(hw, IXGBE_QPTC(i));\n+\t\tuint32_t delta_qprdc = IXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n+\n+\t\tdelta_gprc += delta_qprc;\n+\t\tdelta_gptc += delta_qptc;\n+\n+\t\thw_stats->qprc[i] += delta_qprc;\n+\t\thw_stats->qptc[i] += delta_qptc;\n+\n \t\thw_stats->qbrc[i] += IXGBE_READ_REG(hw, IXGBE_QBRC_L(i));\n \t\thw_stats->qbrc[i] +=\n \t\t ((uint64_t)IXGBE_READ_REG(hw, IXGBE_QBRC_H(i)) << 32);\n+\t\thw_stats->qbrc[i] -= delta_qprc * 4;\n+\n \t\thw_stats->qbtc[i] += IXGBE_READ_REG(hw, IXGBE_QBTC_L(i));\n \t\thw_stats->qbtc[i] +=\n \t\t ((uint64_t)IXGBE_READ_REG(hw, IXGBE_QBTC_H(i)) << 32);\n-\t\t*total_qprdc += hw_stats->qprdc[i] +=\n-\t\t\t\tIXGBE_READ_REG(hw, IXGBE_QPRDC(i));\n+\n+\t\thw_stats->qprdc[i] += delta_qprdc;\n+\t\t*total_qprdc += hw_stats->qprdc[i];\n \n \t\t*total_qprc += hw_stats->qprc[i];\n \t\t*total_qbrc += hw_stats->qbrc[i];\n \t}\n+\n \thw_stats->mlfc += IXGBE_READ_REG(hw, IXGBE_MLFC);\n \thw_stats->mrfc += IXGBE_READ_REG(hw, IXGBE_MRFC);\n \thw_stats->rlec += IXGBE_READ_REG(hw, IXGBE_RLEC);\n \n-\t/* Note that gprc counts missed packets */\n-\thw_stats->gprc += IXGBE_READ_REG(hw, IXGBE_GPRC);\n+\t/*\n+\t * An errata states that gprc actually counts good + missed packets:\n+\t * Workaround to set gprc to summated queue packet recieves\n+\t */\n+\thw_stats->gprc = *total_qprc;\n \n \tif (hw->mac.type != ixgbe_mac_82598EB) {\n \t\thw_stats->gorc += IXGBE_READ_REG(hw, IXGBE_GORCL);\n@@ -2410,6 +2427,14 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \t\thw_stats->gotc += IXGBE_READ_REG(hw, IXGBE_GOTCH);\n \t\thw_stats->tor += IXGBE_READ_REG(hw, IXGBE_TORH);\n \t}\n+\tuint64_t old_tpr = hw_stats->tpr;\n+\n+\thw_stats->tpr += IXGBE_READ_REG(hw, IXGBE_TPR);\n+\thw_stats->tpt += IXGBE_READ_REG(hw, IXGBE_TPT);\n+\n+\thw_stats->gorc -= delta_gprc * 4;\n+\thw_stats->gotc -= delta_gptc * 4;\n+\thw_stats->tor -= (hw_stats->tpr - old_tpr) * 4;\n \n \t/*\n \t * Workaround: mprc hardware is incorrectly counting\n@@ -2449,8 +2474,6 @@ ixgbe_read_stats_registers(struct ixgbe_hw *hw, struct ixgbe_hw_stats\n \thw_stats->mngprc += IXGBE_READ_REG(hw, IXGBE_MNGPRC);\n \thw_stats->mngpdc += IXGBE_READ_REG(hw, IXGBE_MNGPDC);\n \thw_stats->mngptc += IXGBE_READ_REG(hw, IXGBE_MNGPTC);\n-\thw_stats->tpr += IXGBE_READ_REG(hw, IXGBE_TPR);\n-\thw_stats->tpt += IXGBE_READ_REG(hw, IXGBE_TPT);\n \thw_stats->ptc127 += IXGBE_READ_REG(hw, IXGBE_PTC127);\n \thw_stats->ptc255 += IXGBE_READ_REG(hw, IXGBE_PTC255);\n \thw_stats->ptc511 += IXGBE_READ_REG(hw, IXGBE_PTC511);\n", "prefixes": [ "dpdk-dev", "2/4" ] }