Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89386/?format=api
{ "id": 89386, "url": "http://patches.dpdk.org/api/patches/89386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210317111551.2215332-4-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210317111551.2215332-4-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210317111551.2215332-4-qi.z.zhang@intel.com", "date": "2021-03-17T11:15:45", "name": "[v3,3/9] net/fm10k: refine debug build option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b2645e51e1a08b85f78b9d7aedeb5f0b84ca6d16", "submitter": { "id": 504, "url": "http://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210317111551.2215332-4-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 15738, "url": "http://patches.dpdk.org/api/series/15738/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15738", "date": "2021-03-17T11:15:42", "name": "ether: refine debug build option", "version": 3, "mbox": "http://patches.dpdk.org/series/15738/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89386/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89386/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8171FA00C2;\n\tWed, 17 Mar 2021 12:12:38 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 81DE1140EF8;\n\tWed, 17 Mar 2021 12:12:31 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 21E61140EB2\n for <dev@dpdk.org>; Wed, 17 Mar 2021 12:12:26 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Mar 2021 04:12:16 -0700", "from dpdk51.sh.intel.com ([10.67.111.142])\n by orsmga007.jf.intel.com with ESMTP; 17 Mar 2021 04:12:13 -0700" ], "IronPort-SDR": [ "\n 5S9Cwrmvr4U9/F3uvE0lotaGaHt1QcjQ6yqDvCHE1hRiK9H6sup3xCFrLPBXi+sb+rGSc0dAZO\n +tcr8LgzMpcg==", "\n 9qZy0C4ZDtLZXZa88b04nT8Dk7tFYas0hl0+NtXXrBpGmuQ3X0l/BbekkEJaW+/0ZRQe7uhhEA\n ms4DPKC1Sdww==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9925\"; a=\"176570697\"", "E=Sophos;i=\"5.81,256,1610438400\"; d=\"scan'208\";a=\"176570697\"", "E=Sophos;i=\"5.81,256,1610438400\"; d=\"scan'208\";a=\"411428985\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, bruce.richardson@intel.com,\n xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com,\n jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com,\n Qi Zhang <qi.z.zhang@intel.com>", "Date": "Wed, 17 Mar 2021 19:15:45 +0800", "Message-Id": "<20210317111551.2215332-4-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210317111551.2215332-1-qi.z.zhang@intel.com>", "References": "<20210310121626.2019863-1-qi.z.zhang@intel.com>\n <20210317111551.2215332-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 3/9] net/fm10k: refine debug build option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "1. replace RTE_LIBRTE_FM10K_DEBUG_RX with RTE_ETHDEV_DEBUG_RX.\n2. replace RTE_LIBRTE_FM10K_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX.\n3. merge RTE_LIBRTE_FM10K_DEBUG_TX_FREE and RTE_ETHDEV_DEBUG\n into RTE_ETHDEV_DEBUG_TX\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 7 ++-----\n drivers/net/fm10k/fm10k_logs.h | 13 ++-----------\n drivers/net/fm10k/fm10k_rxtx.c | 8 ++++----\n 3 files changed, 8 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex fd471c415e..0a557acbef 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -3287,12 +3287,9 @@ RTE_PMD_REGISTER_PCI_TABLE(net_fm10k, pci_id_fm10k_map);\n RTE_PMD_REGISTER_KMOD_DEP(net_fm10k, \"* igb_uio | uio_pci_generic | vfio-pci\");\n RTE_LOG_REGISTER(fm10k_logtype_init, pmd.net.fm10k.init, NOTICE);\n RTE_LOG_REGISTER(fm10k_logtype_driver, pmd.net.fm10k.driver, NOTICE);\n-#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n RTE_LOG_REGISTER(fm10k_logtype_rx, pmd.net.fm10k.rx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_FM10K_DEBUG_TX\n+#ifdef RTE_ETHDEV_DEBUG_TX\n RTE_LOG_REGISTER(fm10k_logtype_tx, pmd.net.fm10k.tx, DEBUG);\n #endif\n-#ifdef RTE_LIBRTE_FM10K_DEBUG_TX_FREE\n-RTE_LOG_REGISTER(fm10k_logtype_tx_free, pmd.net.fm10k.tx_free, DEBUG);\n-#endif\ndiff --git a/drivers/net/fm10k/fm10k_logs.h b/drivers/net/fm10k/fm10k_logs.h\nindex 9ae743d806..4f039f8beb 100644\n--- a/drivers/net/fm10k/fm10k_logs.h\n+++ b/drivers/net/fm10k/fm10k_logs.h\n@@ -14,7 +14,7 @@ extern int fm10k_logtype_init;\n \n #define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, \" >>\")\n \n-#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n extern int fm10k_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, fm10k_logtype_rx,\t\\\n@@ -23,7 +23,7 @@ extern int fm10k_logtype_rx;\n #define PMD_RX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_FM10K_DEBUG_TX\n+#ifdef RTE_ETHDEV_DEBUG_TX\n extern int fm10k_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...)\t\t\t\\\n \trte_log(RTE_LOG_ ## level, fm10k_logtype_tx,\t\\\n@@ -32,15 +32,6 @@ extern int fm10k_logtype_tx;\n #define PMD_TX_LOG(level, fmt, args...) do { } while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_FM10K_DEBUG_TX_FREE\n-extern int fm10k_logtype_tx_free;\n-#define PMD_TX_FREE_LOG(level, fmt, args...)\t\t\t\\\n-\trte_log(RTE_LOG_ ## level, fm10k_logtype_tx_free,\t\\\n-\t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n-#else\n-#define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)\n-#endif\n-\n extern int fm10k_logtype_driver;\n #define PMD_DRV_LOG_RAW(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, fm10k_logtype_driver, \"%s(): \" fmt, \\\ndiff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c\nindex fbf07bc225..0a9a27aa5a 100644\n--- a/drivers/net/fm10k/fm10k_rxtx.c\n+++ b/drivers/net/fm10k/fm10k_rxtx.c\n@@ -16,7 +16,7 @@\n #define rte_packet_prefetch(p) do {} while (0)\n #endif\n \n-#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n static inline void dump_rxd(union fm10k_rx_desc *rxd)\n {\n \tPMD_RX_LOG(DEBUG, \"+----------------|----------------+\");\n@@ -115,7 +115,7 @@ fm10k_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tbreak;\n \t\tmbuf = q->sw_ring[next_dd];\n \t\tdesc = q->hw_ring[next_dd];\n-#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n \t\tdump_rxd(&desc);\n #endif\n \t\trte_pktmbuf_pkt_len(mbuf) = desc.w.length;\n@@ -229,7 +229,7 @@ fm10k_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t\tbreak;\n \t\tmbuf = q->sw_ring[next_dd];\n \t\tdesc = q->hw_ring[next_dd];\n-#ifdef RTE_LIBRTE_FM10K_DEBUG_RX\n+#ifdef RTE_ETHDEV_DEBUG_RX\n \t\tdump_rxd(&desc);\n #endif\n \n@@ -710,7 +710,7 @@ fm10k_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\treturn i;\n \t\t}\n \n-#ifdef RTE_ETHDEV_DEBUG\n+#ifdef RTE_ETHDEV_DEBUG_TX\n \t\tret = rte_validate_tx_offload(m);\n \t\tif (ret != 0) {\n \t\t\trte_errno = -ret;\n", "prefixes": [ "v3", "3/9" ] }