Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/89289/?format=api
{ "id": 89289, "url": "http://patches.dpdk.org/api/patches/89289/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210316221857.2254-13-timothy.mcdaniel@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210316221857.2254-13-timothy.mcdaniel@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210316221857.2254-13-timothy.mcdaniel@intel.com", "date": "2021-03-16T22:18:44", "name": "[12/25] event/dlb2: add DLB v2.5 support to start domain", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "85753bef8c144a53f4568dc6649dbb3e526dcaef", "submitter": { "id": 826, "url": "http://patches.dpdk.org/api/people/826/?format=api", "name": "Timothy McDaniel", "email": "timothy.mcdaniel@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210316221857.2254-13-timothy.mcdaniel@intel.com/mbox/", "series": [ { "id": 15709, "url": "http://patches.dpdk.org/api/series/15709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15709", "date": "2021-03-16T22:18:32", "name": "Add Support for DLB v2.5", "version": 1, "mbox": "http://patches.dpdk.org/series/15709/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/89289/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/89289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 51B95A054F;\n\tTue, 16 Mar 2021 23:21:24 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ED710242ACA;\n\tTue, 16 Mar 2021 23:20:10 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 36D75242A9D\n for <dev@dpdk.org>; Tue, 16 Mar 2021 23:20:02 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Mar 2021 15:19:56 -0700", "from txasoft-yocto.an.intel.com ([10.123.72.192])\n by fmsmga005.fm.intel.com with ESMTP; 16 Mar 2021 15:19:55 -0700" ], "IronPort-SDR": [ "\n 4MOsXkn3qjxPLValDYMThq5U54ggbjaK/jajVaci/v/fiu8ICE88/0WaUEjzps79hrLAoXqXO5\n vKbHT05Jaqwg==", "\n Uz+8rtywASwdEbLix70g7wM+HXfAvl2oElFKWJHE5Nez3ExGEBl+GfldNp3MIeBSVdLGL9yJwO\n QIw5ReD2cRNA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9925\"; a=\"253359255\"", "E=Sophos;i=\"5.81,254,1610438400\"; d=\"scan'208\";a=\"253359255\"", "E=Sophos;i=\"5.81,254,1610438400\"; d=\"scan'208\";a=\"605440248\"" ], "X-ExtLoop1": "1", "From": "Timothy McDaniel <timothy.mcdaniel@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com, harry.van.haaren@intel.com, mdr@ashroe.eu,\n nhorman@tuxdriver.com, nikhil.rao@intel.com, erik.g.carrillo@intel.com,\n abhinandan.gujjar@intel.com, pbhagavatula@marvell.com,\n hemant.agrawal@nxp.com, mattias.ronnblom@ericsson.com,\n peter.mccarthy@intel.com", "Date": "Tue, 16 Mar 2021 17:18:44 -0500", "Message-Id": "<20210316221857.2254-13-timothy.mcdaniel@intel.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20210316221857.2254-1-timothy.mcdaniel@intel.com>", "References": "<20210316221857.2254-1-timothy.mcdaniel@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 12/25] event/dlb2: add DLB v2.5 support to start\n domain", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update low level functions to account for new register map\nand hardware access macros.\n\nSigned-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>\n---\n drivers/event/dlb2/pf/base/dlb2_resource.c | 123 -----------------\n .../event/dlb2/pf/base/dlb2_resource_new.c | 130 ++++++++++++++++++\n 2 files changed, 130 insertions(+), 123 deletions(-)", "diff": "diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c\nindex 02c2836ad..6b5c8ba01 100644\n--- a/drivers/event/dlb2/pf/base/dlb2_resource.c\n+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c\n@@ -1246,129 +1246,6 @@ dlb2_get_domain_ldb_queue(u32 id,\n \treturn NULL;\n }\n \n-static int dlb2_verify_start_domain_args(struct dlb2_hw *hw,\n-\t\t\t\t\t u32 domain_id,\n-\t\t\t\t\t struct dlb2_cmd_response *resp,\n-\t\t\t\t\t bool vdev_req,\n-\t\t\t\t\t unsigned int vdev_id)\n-{\n-\tstruct dlb2_hw_domain *domain;\n-\n-\tdomain = dlb2_get_domain_from_id(hw, domain_id, vdev_req, vdev_id);\n-\n-\tif (domain == NULL) {\n-\t\tresp->status = DLB2_ST_INVALID_DOMAIN_ID;\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (!domain->configured) {\n-\t\tresp->status = DLB2_ST_DOMAIN_NOT_CONFIGURED;\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tif (domain->started) {\n-\t\tresp->status = DLB2_ST_DOMAIN_STARTED;\n-\t\treturn -EINVAL;\n-\t}\n-\n-\treturn 0;\n-}\n-\n-static void dlb2_log_start_domain(struct dlb2_hw *hw,\n-\t\t\t\t u32 domain_id,\n-\t\t\t\t bool vdev_req,\n-\t\t\t\t unsigned int vdev_id)\n-{\n-\tDLB2_HW_DBG(hw, \"DLB2 start domain arguments:\\n\");\n-\tif (vdev_req)\n-\t\tDLB2_HW_DBG(hw, \"(Request from vdev %d)\\n\", vdev_id);\n-\tDLB2_HW_DBG(hw, \"\\tDomain ID: %d\\n\", domain_id);\n-}\n-\n-/**\n- * dlb2_hw_start_domain() - Lock the domain configuration\n- * @hw:\tContains the current state of the DLB2 hardware.\n- * @domain_id: Domain ID\n- * @arg: User-provided arguments (unused, here for ioctl callback template).\n- * @resp: Response to user.\n- * @vdev_req: Request came from a virtual device.\n- * @vdev_id: If vdev_req is true, this contains the virtual device's ID.\n- *\n- * Return: returns < 0 on error, 0 otherwise. If the driver is unable to\n- * satisfy a request, resp->status will be set accordingly.\n- */\n-int\n-dlb2_hw_start_domain(struct dlb2_hw *hw,\n-\t\t u32 domain_id,\n-\t\t struct dlb2_start_domain_args *arg,\n-\t\t struct dlb2_cmd_response *resp,\n-\t\t bool vdev_req,\n-\t\t unsigned int vdev_id)\n-{\n-\tstruct dlb2_list_entry *iter;\n-\tstruct dlb2_dir_pq_pair *dir_queue;\n-\tstruct dlb2_ldb_queue *ldb_queue;\n-\tstruct dlb2_hw_domain *domain;\n-\tint ret;\n-\tRTE_SET_USED(arg);\n-\tRTE_SET_USED(iter);\n-\n-\tdlb2_log_start_domain(hw, domain_id, vdev_req, vdev_id);\n-\n-\tret = dlb2_verify_start_domain_args(hw,\n-\t\t\t\t\t domain_id,\n-\t\t\t\t\t resp,\n-\t\t\t\t\t vdev_req,\n-\t\t\t\t\t vdev_id);\n-\tif (ret)\n-\t\treturn ret;\n-\n-\tdomain = dlb2_get_domain_from_id(hw, domain_id, vdev_req, vdev_id);\n-\tif (domain == NULL) {\n-\t\tDLB2_HW_ERR(hw,\n-\t\t\t \"[%s():%d] Internal error: domain not found\\n\",\n-\t\t\t __func__, __LINE__);\n-\t\treturn -EFAULT;\n-\t}\n-\n-\t/*\n-\t * Enable load-balanced and directed queue write permissions for the\n-\t * queues this domain owns. Without this, the DLB2 will drop all\n-\t * incoming traffic to those queues.\n-\t */\n-\tDLB2_DOM_LIST_FOR(domain->used_ldb_queues, ldb_queue, iter) {\n-\t\tunion dlb2_sys_ldb_vasqid_v r0 = { {0} };\n-\t\tunsigned int offs;\n-\n-\t\tr0.field.vasqid_v = 1;\n-\n-\t\toffs = domain->id.phys_id * DLB2_MAX_NUM_LDB_QUEUES +\n-\t\t\tldb_queue->id.phys_id;\n-\n-\t\tDLB2_CSR_WR(hw, DLB2_SYS_LDB_VASQID_V(offs), r0.val);\n-\t}\n-\n-\tDLB2_DOM_LIST_FOR(domain->used_dir_pq_pairs, dir_queue, iter) {\n-\t\tunion dlb2_sys_dir_vasqid_v r0 = { {0} };\n-\t\tunsigned int offs;\n-\n-\t\tr0.field.vasqid_v = 1;\n-\n-\t\toffs = domain->id.phys_id * DLB2_MAX_NUM_DIR_PORTS(hw->ver) +\n-\t\t\tdir_queue->id.phys_id;\n-\n-\t\tDLB2_CSR_WR(hw, DLB2_SYS_DIR_VASQID_V(offs), r0.val);\n-\t}\n-\n-\tdlb2_flush_csr(hw);\n-\n-\tdomain->started = true;\n-\n-\tresp->status = 0;\n-\n-\treturn 0;\n-}\n-\n static void dlb2_log_get_dir_queue_depth(struct dlb2_hw *hw,\n \t\t\t\t\t u32 domain_id,\n \t\t\t\t\t u32 queue_id,\ndiff --git a/drivers/event/dlb2/pf/base/dlb2_resource_new.c b/drivers/event/dlb2/pf/base/dlb2_resource_new.c\nindex 6f35a9118..850312a10 100644\n--- a/drivers/event/dlb2/pf/base/dlb2_resource_new.c\n+++ b/drivers/event/dlb2/pf/base/dlb2_resource_new.c\n@@ -5775,3 +5775,133 @@ int dlb2_hw_pending_port_unmaps(struct dlb2_hw *hw,\n \n \treturn 0;\n }\n+\n+static int dlb2_verify_start_domain_args(struct dlb2_hw *hw,\n+\t\t\t\t\t u32 domain_id,\n+\t\t\t\t\t struct dlb2_cmd_response *resp,\n+\t\t\t\t\t bool vdev_req,\n+\t\t\t\t\t unsigned int vdev_id,\n+\t\t\t\t\t struct dlb2_hw_domain **out_domain)\n+{\n+\tstruct dlb2_hw_domain *domain;\n+\n+\tdomain = dlb2_get_domain_from_id(hw, domain_id, vdev_req, vdev_id);\n+\n+\tif (!domain) {\n+\t\tresp->status = DLB2_ST_INVALID_DOMAIN_ID;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!domain->configured) {\n+\t\tresp->status = DLB2_ST_DOMAIN_NOT_CONFIGURED;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (domain->started) {\n+\t\tresp->status = DLB2_ST_DOMAIN_STARTED;\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t*out_domain = domain;\n+\n+\treturn 0;\n+}\n+\n+static void dlb2_log_start_domain(struct dlb2_hw *hw,\n+\t\t\t\t u32 domain_id,\n+\t\t\t\t bool vdev_req,\n+\t\t\t\t unsigned int vdev_id)\n+{\n+\tDLB2_HW_DBG(hw, \"DLB2 start domain arguments:\\n\");\n+\tif (vdev_req)\n+\t\tDLB2_HW_DBG(hw, \"(Request from vdev %d)\\n\", vdev_id);\n+\tDLB2_HW_DBG(hw, \"\\tDomain ID: %d\\n\", domain_id);\n+}\n+\n+/**\n+ * dlb2_hw_start_domain() - start a scheduling domain\n+ * @hw: dlb2_hw handle for a particular device.\n+ * @domain_id: domain ID.\n+ * @arg: start domain arguments.\n+ * @resp: response structure.\n+ * @vdev_req: indicates whether this request came from a vdev.\n+ * @vdev_id: If vdev_req is true, this contains the vdev's ID.\n+ *\n+ * This function starts a scheduling domain, which allows applications to send\n+ * traffic through it. Once a domain is started, its resources can no longer be\n+ * configured (besides QID remapping and port enable/disable).\n+ *\n+ * A vdev can be either an SR-IOV virtual function or a Scalable IOV virtual\n+ * device.\n+ *\n+ * Return:\n+ * Returns 0 upon success, < 0 otherwise. If an error occurs, resp->status is\n+ * assigned a detailed error code from enum dlb2_error.\n+ *\n+ * Errors:\n+ * EINVAL - the domain is not configured, or the domain is already started.\n+ */\n+int\n+dlb2_hw_start_domain(struct dlb2_hw *hw,\n+\t\t u32 domain_id,\n+\t\t struct dlb2_start_domain_args *args,\n+\t\t struct dlb2_cmd_response *resp,\n+\t\t bool vdev_req,\n+\t\t unsigned int vdev_id)\n+{\n+\tstruct dlb2_list_entry *iter;\n+\tstruct dlb2_dir_pq_pair *dir_queue;\n+\tstruct dlb2_ldb_queue *ldb_queue;\n+\tstruct dlb2_hw_domain *domain;\n+\tint ret;\n+\tRTE_SET_USED(args);\n+\tRTE_SET_USED(iter);\n+\n+\tdlb2_log_start_domain(hw, domain_id, vdev_req, vdev_id);\n+\n+\tret = dlb2_verify_start_domain_args(hw,\n+\t\t\t\t\t domain_id,\n+\t\t\t\t\t resp,\n+\t\t\t\t\t vdev_req,\n+\t\t\t\t\t vdev_id,\n+\t\t\t\t\t &domain);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\t/*\n+\t * Enable load-balanced and directed queue write permissions for the\n+\t * queues this domain owns. Without this, the DLB2 will drop all\n+\t * incoming traffic to those queues.\n+\t */\n+\tDLB2_DOM_LIST_FOR(domain->used_ldb_queues, ldb_queue, iter) {\n+\t\tu32 vasqid_v = 0;\n+\t\tunsigned int offs;\n+\n+\t\tDLB2_BIT_SET(vasqid_v, DLB2_SYS_LDB_VASQID_V_VASQID_V);\n+\n+\t\toffs = domain->id.phys_id * DLB2_MAX_NUM_LDB_QUEUES +\n+\t\t\tldb_queue->id.phys_id;\n+\n+\t\tDLB2_CSR_WR(hw, DLB2_SYS_LDB_VASQID_V(offs), vasqid_v);\n+\t}\n+\n+\tDLB2_DOM_LIST_FOR(domain->used_dir_pq_pairs, dir_queue, iter) {\n+\t\tu32 vasqid_v = 0;\n+\t\tunsigned int offs;\n+\n+\t\tDLB2_BIT_SET(vasqid_v, DLB2_SYS_DIR_VASQID_V_VASQID_V);\n+\n+\t\toffs = domain->id.phys_id * DLB2_MAX_NUM_DIR_PORTS(hw->ver) +\n+\t\t\tdir_queue->id.phys_id;\n+\n+\t\tDLB2_CSR_WR(hw, DLB2_SYS_DIR_VASQID_V(offs), vasqid_v);\n+\t}\n+\n+\tdlb2_flush_csr(hw);\n+\n+\tdomain->started = true;\n+\n+\tresp->status = 0;\n+\n+\treturn 0;\n+}\n", "prefixes": [ "12/25" ] }