Patch Comment List
List patch comments
GET /api/patches/89/comments/?format=api
[ { "id": 226, "web_url": "http://patches.dpdk.org/comment/226/", "msgid": "<9589603.4uh6CsY5aa@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/9589603.4uh6CsY5aa@xps13", "date": "2014-07-24T07:59:23", "subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-24 14:42, Helin Zhang:\n> Toeplitz and simple XOR hash functions are supported by\n> hardware, code changes are to tell the hardware which hash\n> function is selected according to the configuration.\n> \n> Signed-off-by: Helin Zhang <helin.zhang@intel.com>\n\n> +CONFIG_RTE_LIBRTE_I40E_HASH_FUNC_TOEPLITZ=y\n\nIs it really a good idea to configure this kind of thing at build time?\nMaybe yes, I'm not sure.", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-wg0-f50.google.com (mail-wg0-f50.google.com\n\t[74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 662C1B347\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 09:58:06 +0200 (CEST)", "by mail-wg0-f50.google.com with SMTP id n12so2286592wgh.33\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 00:59:33 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\ta13sm13635294wjs.12.2014.07.24.00.59.32 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Jul 2014 00:59:32 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=LAsAi2QTTa55aheaCDj+czVxr5rCDBZCYVZYYeFGv5k=;\n\tb=S273jRk5jP6BdyYG684UdPuT4Wy3nsHL6MUfLcYUPYKVk10v1pwACp/0+DV5o7MWOx\n\twkLds+JhUVAz1VeI2papQR0AA3QmhmPcnuojlCucGoPmKGTs2qma2w9ncH0bsvucoPKN\n\t6cR4VI9nYuGtLfY4jjO3u3H7OGk9tjNW/dHy6jvVdeT7uKzhGA8zwJOG7acHkiNH9aFf\n\t2YHda/aa44neQy7uEID+SIrT72gfJinHt/2y+wRQxo565+Wi5auBGNoF+nOLzLRc2ogr\n\tNIcd6qwO4hJQ0XpNoiXfc9cAyGE+48PBZvxzMHWuZZeEDgJHfEfzKcIXz3IJ+SM/1RU1\n\tgArQ==", "X-Gm-Message-State": "ALoCoQnQyEsi9vrTGZ5+eb4eBXu8iZBxQbhJTkvPrHya763yEidnsWbU19ZzdWTn9WJaNxIuKfX8", "X-Received": "by 10.180.20.15 with SMTP id j15mr6959576wie.60.1406188773495;\n\tThu, 24 Jul 2014 00:59:33 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Helin Zhang <helin.zhang@intel.com>", "Date": "Thu, 24 Jul 2014 09:59:23 +0200", "Message-ID": "<9589603.4uh6CsY5aa@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<1406184149-11531-4-git-send-email-helin.zhang@intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-4-git-send-email-helin.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 07:58:07 -0000" }, "addressed": null }, { "id": 227, "web_url": "http://patches.dpdk.org/comment/227/", "msgid": "<20140724080113.GB21277@mhcomputing.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20140724080113.GB21277@mhcomputing.net", "date": "2014-07-24T08:01:13", "subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote:\n> Is it really a good idea to configure this kind of thing at build time?\n> Maybe yes, I'm not sure.\n\nWhether it's safe to set at runtime probably depends what happens to the card \nif it gets changed. Do you have to reset the card or the port? Or is it OK if \nit's more dynamic?\n\nMatthew.", "headers": { "Return-Path": "<mhall@mhcomputing.net>", "Received": [ "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id 731EA594D\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:00:21 +0200 (CEST)", "by mail.mhcomputing.net (Postfix, from userid 1000)\n\tid A563380C764; Thu, 24 Jul 2014 01:01:13 -0700 (PDT)" ], "Date": "Thu, 24 Jul 2014 01:01:13 -0700", "From": "Matthew Hall <mhall@mhcomputing.net>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Message-ID": "<20140724080113.GB21277@mhcomputing.net>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<1406184149-11531-4-git-send-email-helin.zhang@intel.com>\n\t<9589603.4uh6CsY5aa@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<9589603.4uh6CsY5aa@xps13>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:00:21 -0000" }, "addressed": null }, { "id": 228, "web_url": "http://patches.dpdk.org/comment/228/", "msgid": "<1454201.eyrodsIZYi@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1454201.eyrodsIZYi@xps13", "date": "2014-07-24T08:07:37", "subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "submitter": { "id": 1, "url": "http://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-07-24 01:01, Matthew Hall:\n> On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote:\n> > Is it really a good idea to configure this kind of thing at build time?\n> > Maybe yes, I'm not sure.\n> \n> Whether it's safe to set at runtime probably depends what happens to the card \n> if it gets changed. Do you have to reset the card or the port? Or is it OK if \n> it's more dynamic?\n\nNo, we can change configuration with rte_eth_dev_configure() before\ninitializing port. So it is truly configurable.\nRequiring recompilation means it's not really configurable between 2 runs.\nAnd it breaks binary packaging for Linux distributions.\n\nMany things in DPDK are configured at build time. But we should wonder if\nit's really a good design.", "headers": { "Return-Path": "<thomas.monjalon@6wind.com>", "Received": [ "from mail-we0-f171.google.com (mail-we0-f171.google.com\n\t[74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 21C8C5930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:06:21 +0200 (CEST)", "by mail-we0-f171.google.com with SMTP id p10so2384825wes.2\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 01:07:48 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tes9sm9588845wjd.1.2014.07.24.01.07.46 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 24 Jul 2014 01:07:47 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=/lRIjLe7dw2NlF4Ylguga2GMEI8pXdc90HRa16ZYIV0=;\n\tb=Dl5Jqzbq4j8MNZqwS0uQ5vjgdjmJRL8TLgo/l+hMBVY64exBAh+e/qfa7xMhL5rmXM\n\ts7MkwLJ1qPxd78RKVxlkEdaTki3P6hsrvGg459diFj1ZAHcWLeatqIvg/Syy0xFBlXVW\n\tuzXtsXlScJVVXMg6LF8Mizu1yFbmqM+29f1rQ1f2gvNXQD5Il8dcFTOorbF1hADBHaO5\n\tbGRvSwgvH/iy8Of07PQ41/2DnYcGOS6dtGKKwhcxhSeB46DpWDdvk3wAHGZpiFK4uyPo\n\tw9kmikpu3cdzfxJMyEuHutrUPOwTkEabbblxLlqq9EQYkPyUpXMYkNvsseX0WCwcBNNK\n\tssRA==", "X-Gm-Message-State": "ALoCoQnOlzjesE46/pwlehJD/6UdarLDpCPiwyU6YlVPL35rac/4dGuDlCFO0IAvFAEdN2TlAZRE", "X-Received": "by 10.194.6.10 with SMTP id w10mr9501185wjw.51.1406189268290;\n\tThu, 24 Jul 2014 01:07:48 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Matthew Hall <mhall@mhcomputing.net>, Helin Zhang <helin.zhang@intel.com>", "Date": "Thu, 24 Jul 2014 10:07:37 +0200", "Message-ID": "<1454201.eyrodsIZYi@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.2 (Linux/3.15.5-2-ARCH; KDE/4.13.2; x86_64; ; )", "In-Reply-To": "<20140724080113.GB21277@mhcomputing.net>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:06:21 -0000" }, "addressed": null }, { "id": 230, "web_url": "http://patches.dpdk.org/comment/230/", "msgid": "<0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com", "date": "2014-07-24T08:14:44", "subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "submitter": { "id": 37, "url": "http://patches.dpdk.org/api/people/37/?format=api", "name": "Matthew Hall", "email": "mhall@mhcomputing.net" }, "content": "If no reboot of the card is needed then it's probably better to add it to one of the ethtool style APIs...", "headers": { "Return-Path": "<mhall@mhcomputing.net>", "Received": [ "from mail.mhcomputing.net (master.mhcomputing.net [74.208.46.186])\n\tby dpdk.org (Postfix) with ESMTP id 1FCB6B34B\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:13:30 +0200 (CEST)", "from android-fb5fc4f6ed62fb42\n\t(172-3-139-73.lightspeed.sntcca.sbcglobal.net [172.3.139.73])\n\tby mail.mhcomputing.net (Postfix) with ESMTPSA id 0AB5F80C764;\n\tThu, 24 Jul 2014 01:14:21 -0700 (PDT)" ], "User-Agent": "K-9 Mail for Android", "In-Reply-To": "<1454201.eyrodsIZYi@xps13>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net>\n\t<1454201.eyrodsIZYi@xps13>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain;\n charset=UTF-8", "From": "Matthew Hall <mhall@mhcomputing.net>", "Date": "Thu, 24 Jul 2014 01:14:44 -0700", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>,\n\tHelin Zhang <helin.zhang@intel.com>", "Message-ID": "<0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com>", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:13:30 -0000" }, "addressed": null }, { "id": 234, "web_url": "http://patches.dpdk.org/comment/234/", "msgid": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A762888@SHSMSX104.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/F35DEAC7BCE34641BA9FAC6BCA4A12E70A762888@SHSMSX104.ccr.corp.intel.com", "date": "2014-07-24T08:54:23", "subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "submitter": { "id": 14, "url": "http://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "content": "> -----Original Message-----\r\n> From: Matthew Hall [mailto:mhall@mhcomputing.net]\r\n> Sent: Thursday, July 24, 2014 4:15 PM\r\n> To: Thomas Monjalon; Zhang, Helin\r\n> Cc: dev@dpdk.org\r\n> Subject: Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions\r\n> \r\n> If no reboot of the card is needed then it's probably better to add it to one of\r\n> the ethtool style APIs...\r\n> --\r\n> Sent from my mobile device.\r\n> \r\n> On July 24, 2014 1:07:37 AM PDT, Thomas Monjalon\r\n> <thomas.monjalon@6wind.com> wrote:\r\n> >2014-07-24 01:01, Matthew Hall:\r\n> >> On Thu, Jul 24, 2014 at 09:59:23AM +0200, Thomas Monjalon wrote:\r\n> >> > Is it really a good idea to configure this kind of thing at build\r\n> >time?\r\n> >> > Maybe yes, I'm not sure.\r\n> >>\r\n> >> Whether it's safe to set at runtime probably depends what happens to\r\n> >the card\r\n> >> if it gets changed. Do you have to reset the card or the port? Or is\r\n> >it OK if\r\n> >> it's more dynamic?\r\n> >\r\n> >No, we can change configuration with rte_eth_dev_configure() before\r\n> >initializing port. So it is truly configurable.\r\n> >Requiring recompilation means it's not really configurable between 2\r\n> >runs.\r\n> >And it breaks binary packaging for Linux distributions.\r\n> >\r\n> >Many things in DPDK are configured at build time. But we should wonder\r\n> >if it's really a good design.\r\n\r\n\r\nHi Thomas, Matt\r\n\r\nGood points! Thank you guys!\r\n\r\nRegards,\r\nHelin", "headers": { "Return-Path": "<helin.zhang@intel.com>", "Received": [ "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 123615930\n\tfor <dev@dpdk.org>; Thu, 24 Jul 2014 10:53:00 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 24 Jul 2014 01:54:26 -0700", "from fmsmsx108.amr.corp.intel.com ([10.19.9.228])\n\tby fmsmga002.fm.intel.com with ESMTP; 24 Jul 2014 01:54:26 -0700", "from fmsmsx154.amr.corp.intel.com (10.18.116.70) by\n\tFMSMSX108.amr.corp.intel.com (10.19.9.228) with Microsoft SMTP Server\n\t(TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:54:26 -0700", "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tFMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP\n\tServer (TLS) id 14.3.123.3; Thu, 24 Jul 2014 01:54:26 -0700", "from shsmsx104.ccr.corp.intel.com ([169.254.5.204]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.188]) with mapi id\n\t14.03.0123.003; Thu, 24 Jul 2014 16:54:23 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,722,1400050800\"; d=\"scan'208\";a=\"574689237\"", "From": "\"Zhang, Helin\" <helin.zhang@intel.com>", "To": "Matthew Hall <mhall@mhcomputing.net>, Thomas Monjalon\n\t<thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "Thread-Index": "AQHPpxU/M304Ja8FoUuw06aWdQ2qcJuuVpiAgAAByoCAAAH9AIAAkLtA", "Date": "Thu, 24 Jul 2014 08:54:23 +0000", "Message-ID": "<F35DEAC7BCE34641BA9FAC6BCA4A12E70A762888@SHSMSX104.ccr.corp.intel.com>", "References": "<1406184149-11531-1-git-send-email-helin.zhang@intel.com>\n\t<9589603.4uh6CsY5aa@xps13> <20140724080113.GB21277@mhcomputing.net>\n\t<1454201.eyrodsIZYi@xps13>\n\t<0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com>", "In-Reply-To": "<0344b116-248f-4f64-9ef7-31be52ba8632@email.android.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 3/5] i40e: support selecting hash functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Thu, 24 Jul 2014 08:53:01 -0000" }, "addressed": null } ]