Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88718/?format=api
{ "id": 88718, "url": "http://patches.dpdk.org/api/patches/88718/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210308222855.823670-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210308222855.823670-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210308222855.823670-2-thomas@monjalon.net", "date": "2021-03-08T22:28:53", "name": "[1/3] net/mlx4: enable debug logs dynamically", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e33b607e7fbce4e7dc12e3576d3ec870c08fb1c1", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210308222855.823670-2-thomas@monjalon.net/mbox/", "series": [ { "id": 15538, "url": "http://patches.dpdk.org/api/series/15538/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15538", "date": "2021-03-08T22:28:52", "name": "adjust mlx debug logs", "version": 1, "mbox": "http://patches.dpdk.org/series/15538/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88718/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88718/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD97BA0566;\n\tMon, 8 Mar 2021 23:29:08 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3208222A4EC;\n\tMon, 8 Mar 2021 23:29:07 +0100 (CET)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1519622A4E3\n for <dev@dpdk.org>; Mon, 8 Mar 2021 23:29:06 +0100 (CET)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.nyi.internal (Postfix) with ESMTP id BCB9E5C0121;\n Mon, 8 Mar 2021 17:29:05 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Mon, 08 Mar 2021 17:29:05 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 2F0531080057;\n Mon, 8 Mar 2021 17:29:05 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm3; bh=3Se3GeOxNt+e7\n 9fg3grJsMHrBxAKl5BFY5/ociXjq7g=; b=QGaGuKkwsb3hOB3LVCQlJW5AEvnz6\n BodzpK7OoCkDvCgZNb9/N/ID52Hbv+UgcVJmN2RlMgD/GKC/uBhzsvzhdljzDuCo\n RA6Vu2JWw5EsbNUnDkYCZSrhKKJ0TlOkIKtnwiKampAKjRrVDl+Ngu5b++P/ANEs\n 0FmBXp3yIodv9ZvFDWEg7mY7dr6Z6y95J1LFkiTeD/zm4QYyZvarAdh5/soSAKRr\n uhMPRbXJt7fVsQQ3rTXybUKmGFb+VM11t0li9e60nRMIErJnhZ667A2u7oUSDbzN\n lxaOu/Oi87t/uUcc0IvLo3NktkcXDZStEXSaJU3ygDuPLJdOYjtO+4moA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm2; bh=3Se3GeOxNt+e79fg3grJsMHrBxAKl5BFY5/ociXjq7g=; b=A+/ecbek\n byJhQaw5C4BVex38kPNuRgWunuFclsV1cn7azRiAzza8NwFuA15HwAmYnLuGQ09O\n sMeEwe53MM8Zp5dgckNxhs/Tq95exlPJ62cjX8SOvFTj9tjHdxbzKa2h0FRv+sRu\n UeVagL2I2yzVxWocECn2I7tH3PBjuu1h9xbqxVoB+FJHdeteBXaAErLhbN/jI6u8\n iCx5c5z+aNJ8ulxWftuBdrf6GKTuaSknnuJFsTK/cG9iJCijg9+7bzuu3nyrEWcR\n pQB6rK08F9GDXW6b/apKIN7yIFSYv9d8CRo3N4yRt9VfLeYALZvP376kKGbwCCO6\n VNi8mWgxThppkw==" ], "X-ME-Sender": "<xms:MaVGYAeJNQiBBlRBP9afdWVltIrhAPcPuBrnJPBTvUVeouQndBIpDg>\n <xme:MaVGYJGIiBfq87bZ6DdK92aDgc7YHNwNcpQ-TPKM_ynGE0vHPXMG8l8tjBbhgoh2Q\n phhxSLs4TSJV3alWw>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledruddugedgledvucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepheefieekleefieeljedtvdehgeejvdevfedufeetleejfeethfel\n gfffudektdeunecuffhomhgrihhnpehpmhgurdhnvghtnecukfhppeejjedrudefgedrvd\n dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr\n ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:MaVGYJ3-kvYxeKPlFQvWLxrbQLDCkZai6DAe__4vQ_fqPOahl1HcIg>\n <xmx:MaVGYBmhtHFMpdFc0jeWiEEjFbuzaq7hYGualU4fDB1OSYpqMK14FA>\n <xmx:MaVGYJ_KxhgZG73__GtK4boLouFshGUBUhiU72gH8xWFjAtrOd9L3w>\n <xmx:MaVGYCwPgHVCnMlIX0uwtgw3pzAY_iANeBfcLq-t9e9GFBzvqCzJRA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Matan Azrad <matan@nvidia.com>,\n\tShahaf Shuler <shahafs@nvidia.com>", "Date": "Mon, 8 Mar 2021 23:28:53 +0100", "Message-Id": "<20210308222855.823670-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210308222855.823670-1-thomas@monjalon.net>", "References": "<20210308222855.823670-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/mlx4: enable debug logs dynamically", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The macro DEBUG was doing nothing if not compiled with\nRTE_LIBRTE_MLX4_DEBUG.\n\nAs it is not used in the data path, it can be always enabled at\ncompilation time. Then it can be enabled at runtime with:\n\t--log-level pmd.net.mlx4:debug\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/mlx4/mlx4_utils.h | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.h\nindex b8769562ab..fca21fd79c 100644\n--- a/drivers/net/mlx4/mlx4_utils.h\n+++ b/drivers/net/mlx4/mlx4_utils.h\n@@ -52,14 +52,13 @@ pmd_drv_log_basename(const char *s)\n \t\t\t__LINE__, \\\n \t\t\t__func__, \\\n \t\t\tRTE_FMT_TAIL(__VA_ARGS__,)))\n-#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__)\n #define MLX4_ASSERT(exp) RTE_VERIFY(exp)\n #define claim_zero(...) MLX4_ASSERT((__VA_ARGS__) == 0)\n \n #else /* RTE_LIBRTE_MLX4_DEBUG */\n \n /*\n- * Like MLX4_ASSERT(), DEBUG() becomes a no-op and claim_zero() does not perform\n+ * Like MLX4_ASSERT(), claim_zero() does not perform\n * any check when debugging is disabled.\n */\n \n@@ -68,12 +67,12 @@ pmd_drv_log_basename(const char *s)\n \t\tRTE_FMT(MLX4_DRIVER_NAME \": \" \\\n \t\t\tRTE_FMT_HEAD(__VA_ARGS__,) \"\\n\", \\\n \t\tRTE_FMT_TAIL(__VA_ARGS__,)))\n-#define DEBUG(...) (void)0\n #define MLX4_ASSERT(exp) RTE_ASSERT(exp)\n #define claim_zero(...) (__VA_ARGS__)\n \n #endif /* RTE_LIBRTE_MLX4_DEBUG */\n \n+#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__)\n #define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__)\n #define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__)\n #define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__)\n", "prefixes": [ "1/3" ] }