Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88490/?format=api
{ "id": 88490, "url": "http://patches.dpdk.org/api/patches/88490/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1614905757-33791-4-git-send-email-oulijun@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1614905757-33791-4-git-send-email-oulijun@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1614905757-33791-4-git-send-email-oulijun@huawei.com", "date": "2021-03-05T00:55:57", "name": "[3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in testpmd", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "060d1d0bcb6e9e111eafea893e1187afc1a1952e", "submitter": { "id": 1675, "url": "http://patches.dpdk.org/api/people/1675/?format=api", "name": "Lijun Ou", "email": "oulijun@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1614905757-33791-4-git-send-email-oulijun@huawei.com/mbox/", "series": [ { "id": 15494, "url": "http://patches.dpdk.org/api/series/15494/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15494", "date": "2021-03-05T00:55:54", "name": "testpmd updates", "version": 1, "mbox": "http://patches.dpdk.org/series/15494/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88490/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88490/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 39DE6A0561;\n\tFri, 5 Mar 2021 01:55:24 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 07E6422A2F0;\n\tFri, 5 Mar 2021 01:55:19 +0100 (CET)", "from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])\n by mails.dpdk.org (Postfix) with ESMTP id 976B34069F\n for <dev@dpdk.org>; Fri, 5 Mar 2021 01:55:16 +0100 (CET)", "from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59])\n by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Ds8Nb47SlzMjH3;\n Fri, 5 Mar 2021 08:53:03 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id\n 14.3.498.0; Fri, 5 Mar 2021 08:55:12 +0800" ], "From": "Lijun Ou <oulijun@huawei.com>", "To": "<ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>", "Date": "Fri, 5 Mar 2021 08:55:57 +0800", "Message-ID": "<1614905757-33791-4-git-send-email-oulijun@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1614905757-33791-1-git-send-email-oulijun@huawei.com>", "References": "<1614905757-33791-1-git-send-email-oulijun@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH 3/3] app/testpmd: fix mixed use of RX/Rx/TX/Tx in\n testpmd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hongbo Zheng <zhenghongbo3@huawei.com>\n\nIn testpmd, when we input \"show config rxtx\", we can see like this:\n\n1: testpmd> show config rxtx\n2: io packet forwarding packets/burst=32\n3: nb forwarding cores=1 - nb forwarding ports=1\n4: port 0: RX queue number: 1 Tx queue number: 1\n5: Rx offloads=0x0 Tx offloads=0x10000\n6: RX queue: 0\n7: RX desc=1024 - RX free threshold=32\n8: RX threshold registers: pthresh=0 hthresh=0 wthresh=0\n9: RX Offloads=0x0\n10: TX queue: 0\n11: TX desc=1024 - TX free threshold=928\n12: TX threshold registers: pthresh=0 hthresh=0 wthresh=0\n13: TX offloads=0x10000 - TX RS bit threshold=32\n\nIn line 4, RX/Tx is mixed used. Also in other lines, RX/Rx/TX/Tx is\nmixed used.\n\nThis patch fix the mixed use of RX/Rx/TX/Tx in testpmd command\n\"show config rxtx\" output by change to unified use Rx/Tx.\n\nSigned-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n app/test-pmd/config.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 576d5ac..2435c26 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2505,7 +2505,7 @@ rxtx_config_display(void)\n \t\tint32_t rc;\n \n \t\t/* per port config */\n-\t\tprintf(\" port %d: RX queue number: %d Tx queue number: %d\\n\",\n+\t\tprintf(\" port %d: Rx queue number: %d Tx queue number: %d\\n\",\n \t\t\t\t(unsigned int)pid, nb_rxq, nb_txq);\n \n \t\tprintf(\" Rx offloads=0x%\"PRIx64\" Tx offloads=0x%\"PRIx64\"\\n\",\n@@ -2533,13 +2533,13 @@ rxtx_config_display(void)\n \t\t\t\toffloads_tmp = rx_qinfo.conf.offloads;\n \t\t\t}\n \n-\t\t\tprintf(\" RX queue: %d\\n\", qid);\n-\t\t\tprintf(\" RX desc=%d - RX free threshold=%d\\n\",\n+\t\t\tprintf(\" Rx queue: %d\\n\", qid);\n+\t\t\tprintf(\" Rx desc=%d - Rx free threshold=%d\\n\",\n \t\t\t\tnb_rx_desc_tmp, rx_free_thresh_tmp);\n-\t\t\tprintf(\" RX threshold registers: pthresh=%d hthresh=%d \"\n+\t\t\tprintf(\" Rx threshold registers: pthresh=%d hthresh=%d \"\n \t\t\t\t\" wthresh=%d\\n\",\n \t\t\t\tpthresh_tmp, hthresh_tmp, wthresh_tmp);\n-\t\t\tprintf(\" RX Offloads=0x%\"PRIx64\"\\n\", offloads_tmp);\n+\t\t\tprintf(\" Rx Offloads=0x%\"PRIx64\"\\n\", offloads_tmp);\n \t\t}\n \n \t\t/* per tx queue config only for first queue to be less verbose */\n@@ -2565,13 +2565,13 @@ rxtx_config_display(void)\n \t\t\t\ttx_rs_thresh_tmp = tx_qinfo.conf.tx_rs_thresh;\n \t\t\t}\n \n-\t\t\tprintf(\" TX queue: %d\\n\", qid);\n-\t\t\tprintf(\" TX desc=%d - TX free threshold=%d\\n\",\n+\t\t\tprintf(\" Tx queue: %d\\n\", qid);\n+\t\t\tprintf(\" Tx desc=%d - Tx free threshold=%d\\n\",\n \t\t\t\tnb_tx_desc_tmp, tx_free_thresh_tmp);\n-\t\t\tprintf(\" TX threshold registers: pthresh=%d hthresh=%d \"\n+\t\t\tprintf(\" Tx threshold registers: pthresh=%d hthresh=%d \"\n \t\t\t\t\" wthresh=%d\\n\",\n \t\t\t\tpthresh_tmp, hthresh_tmp, wthresh_tmp);\n-\t\t\tprintf(\" TX offloads=0x%\"PRIx64\" - TX RS bit threshold=%d\\n\",\n+\t\t\tprintf(\" Tx offloads=0x%\"PRIx64\" - Tx RS bit threshold=%d\\n\",\n \t\t\t\toffloads_tmp, tx_rs_thresh_tmp);\n \t\t}\n \t}\n", "prefixes": [ "3/3" ] }