Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88453,
    "url": "http://patches.dpdk.org/api/patches/88453/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1614843894-43845-6-git-send-email-oulijun@huawei.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1614843894-43845-6-git-send-email-oulijun@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1614843894-43845-6-git-send-email-oulijun@huawei.com",
    "date": "2021-03-04T07:44:45",
    "name": "[V3,05/14] net/hns3: add imissed packet stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9153b4f00043ba4a270f8b4b3037ce43d77e15df",
    "submitter": {
        "id": 1675,
        "url": "http://patches.dpdk.org/api/people/1675/?format=api",
        "name": "Lijun Ou",
        "email": "oulijun@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1614843894-43845-6-git-send-email-oulijun@huawei.com/mbox/",
    "series": [
        {
            "id": 15486,
            "url": "http://patches.dpdk.org/api/series/15486/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15486",
            "date": "2021-03-04T07:44:40",
            "name": "Features and bugfixes for hns3",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/15486/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/88453/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/88453/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 40D97A0561;\n\tThu,  4 Mar 2021 08:45:29 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 55C7022A300;\n\tThu,  4 Mar 2021 08:44:28 +0100 (CET)",
            "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id 5388922A2C9\n for <dev@dpdk.org>; Thu,  4 Mar 2021 08:44:17 +0100 (CET)",
            "from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DrjW20VkpzlSYQ;\n Thu,  4 Mar 2021 15:42:06 +0800 (CST)",
            "from localhost.localdomain (10.69.192.56) by\n DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id\n 14.3.498.0; Thu, 4 Mar 2021 15:44:10 +0800"
        ],
        "From": "Lijun Ou <oulijun@huawei.com>",
        "To": "<ferruh.yigit@intel.com>",
        "CC": "<dev@dpdk.org>, <linuxarm@openeuler.org>",
        "Date": "Thu, 4 Mar 2021 15:44:45 +0800",
        "Message-ID": "<1614843894-43845-6-git-send-email-oulijun@huawei.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1614843894-43845-1-git-send-email-oulijun@huawei.com>",
        "References": "<1614693534-27620-1-git-send-email-oulijun@huawei.com>\n <1614843894-43845-1-git-send-email-oulijun@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-CFilter-Loop": "Reflected",
        "Subject": "[dpdk-dev] [PATCH V3 05/14] net/hns3: add imissed packet stats",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: \"Min Hu (Connor)\" <humin29@huawei.com>\n\nThis patch implement Rx imissed stats by querying cmdq.\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Lijun Ou <oulijun@huawei.com>\n---\n drivers/net/hns3/hns3_cmd.h    |   7 +++\n drivers/net/hns3/hns3_ethdev.c |   7 +++\n drivers/net/hns3/hns3_ethdev.h |   1 +\n drivers/net/hns3/hns3_stats.c  | 106 ++++++++++++++++++++++++++++++++++++++++-\n drivers/net/hns3/hns3_stats.h  |   8 ++++\n 5 files changed, 128 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/hns3/hns3_cmd.h b/drivers/net/hns3/hns3_cmd.h\nindex 2e23f99..93bfa74 100644\n--- a/drivers/net/hns3/hns3_cmd.h\n+++ b/drivers/net/hns3/hns3_cmd.h\n@@ -905,6 +905,13 @@ struct hns3_dev_specs_0_cmd {\n \tuint32_t max_tm_rate;\n };\n \n+struct hns3_query_rpu_cmd {\n+\tuint32_t tc_queue_num;\n+\tuint32_t rsv1[2];\n+\tuint32_t rpu_rx_pkt_drop_cnt;\n+\tuint32_t rsv2[2];\n+};\n+\n #define HNS3_MAX_TQP_NUM_HIP08_PF\t64\n #define HNS3_DEFAULT_TX_BUF\t\t0x4000    /* 16k  bytes */\n #define HNS3_TOTAL_PKT_BUF\t\t0x108000  /* 1.03125M bytes */\ndiff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 91d720a..34cd038 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -4742,6 +4742,13 @@ hns3_init_pf(struct rte_eth_dev *eth_dev)\n \t\tgoto err_cmd_init;\n \t}\n \n+\t/* Hardware statistics of imissed registers cleared. */\n+\tret = hns3_update_imissed_stats(hw, true);\n+\tif (ret) {\n+\t\thns3_err(hw, \"clear imissed stats failed, ret = %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n \thns3_config_all_msix_error(hw, true);\n \n \tret = rte_intr_callback_register(&pci_dev->intr_handle,\ndiff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 3a592c0..5299dd8 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -434,6 +434,7 @@ struct hns3_hw {\n \tstruct hns3_tqp_stats tqp_stats;\n \t/* Include Mac stats | Rx stats | Tx stats */\n \tstruct hns3_mac_stats mac_stats;\n+\tstruct hns3_rx_missed_stats imissed_stats;\n \tuint32_t fw_version;\n \n \tuint16_t num_msi;\ndiff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex 777d36a..87035e3 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -324,6 +324,12 @@ static const struct hns3_xstats_name_offset hns3_tx_queue_strings[] = {\n \t{\"TX_QUEUE_FBD\", HNS3_RING_TX_FBDNUM_REG}\n };\n \n+/* The statistic of imissed packet */\n+static const struct hns3_xstats_name_offset hns3_imissed_stats_strings[] = {\n+\t{\"RPU_DROP_CNT\",\n+\t\tHNS3_IMISSED_STATS_FIELD_OFFSET(rpu_rx_drop_cnt)},\n+};\n+\n #define HNS3_NUM_MAC_STATS (sizeof(hns3_mac_strings) / \\\n \tsizeof(hns3_mac_strings[0]))\n \n@@ -354,8 +360,11 @@ static const struct hns3_xstats_name_offset hns3_tx_queue_strings[] = {\n #define HNS3_NUM_TXQ_BASIC_STATS (sizeof(hns3_txq_basic_stats_strings) / \\\n \tsizeof(hns3_txq_basic_stats_strings[0]))\n \n+#define HNS3_NUM_IMISSED_XSTATS (sizeof(hns3_imissed_stats_strings) / \\\n+\tsizeof(hns3_imissed_stats_strings[0]))\n+\n #define HNS3_FIX_NUM_STATS (HNS3_NUM_MAC_STATS + HNS3_NUM_ERROR_INT_XSTATS + \\\n-\t\t\t    HNS3_NUM_RESET_XSTATS)\n+\t\t\t    HNS3_NUM_RESET_XSTATS + HNS3_NUM_IMISSED_XSTATS)\n \n static void hns3_tqp_stats_clear(struct hns3_hw *hw);\n static void hns3_tqp_basic_stats_clear(struct rte_eth_dev *dev);\n@@ -515,6 +524,52 @@ hns3_update_tqp_stats(struct hns3_hw *hw)\n \treturn 0;\n }\n \n+static int\n+hns3_update_rpu_drop_stats(struct hns3_hw *hw)\n+{\n+\tstruct hns3_rx_missed_stats *stats = &hw->imissed_stats;\n+\tstruct hns3_query_rpu_cmd *req;\n+\tstruct hns3_cmd_desc desc;\n+\tuint64_t cnt;\n+\tuint32_t tc_num;\n+\tint ret;\n+\n+\thns3_cmd_setup_basic_desc(&desc, HNS3_OPC_DFX_RPU_REG_0, true);\n+\treq = (struct hns3_query_rpu_cmd *)desc.data;\n+\n+\t/*\n+\t * tc_num is 0, means rpu stats of all TC channels will be\n+\t * get from firmware\n+\t */\n+\ttc_num = 0;\n+\treq->tc_queue_num = rte_cpu_to_le_32(tc_num);\n+\tret = hns3_cmd_send(hw, &desc, 1);\n+\tif (ret) {\n+\t\thns3_err(hw, \"failed to query RPU stats: %d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tcnt = rte_le_to_cpu_32(req->rpu_rx_pkt_drop_cnt);\n+\tstats->rpu_rx_drop_cnt += cnt;\n+\n+\treturn 0;\n+}\n+\n+int\n+hns3_update_imissed_stats(struct hns3_hw *hw, bool is_clear)\n+{\n+\tint ret;\n+\n+\tret = hns3_update_rpu_drop_stats(hw);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (is_clear)\n+\t\tmemset(&hw->imissed_stats, 0, sizeof(hw->imissed_stats));\n+\n+\treturn 0;\n+}\n+\n /*\n  * Query tqp tx queue statistics ,opcode id: 0x0B03.\n  * Query tqp rx queue statistics ,opcode id: 0x0B13.\n@@ -531,6 +586,7 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n {\n \tstruct hns3_adapter *hns = eth_dev->data->dev_private;\n \tstruct hns3_hw *hw = &hns->hw;\n+\tstruct hns3_rx_missed_stats *imissed_stats = &hw->imissed_stats;\n \tstruct hns3_tqp_stats *stats = &hw->tqp_stats;\n \tstruct hns3_rx_queue *rxq;\n \tuint64_t cnt;\n@@ -544,6 +600,18 @@ hns3_stats_get(struct rte_eth_dev *eth_dev, struct rte_eth_stats *rte_stats)\n \t\treturn ret;\n \t}\n \n+\tif (!hns->is_vf) {\n+\t\t/* Update imissed stats */\n+\t\tret = hns3_update_imissed_stats(hw, false);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"update imissed stats failed, ret = %d\",\n+\t\t\t\t ret);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\trte_stats->imissed = imissed_stats->rpu_rx_drop_cnt;\n+\t}\n+\n \t/* Get the error stats and bytes of received packets */\n \tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++) {\n \t\trxq = eth_dev->data->rx_queues[i];\n@@ -616,6 +684,19 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)\n \t\t}\n \t}\n \n+\tif (!hns->is_vf) {\n+\t\t/*\n+\t\t * Note: Reading hardware statistics of imissed registers will\n+\t\t * clear them.\n+\t\t */\n+\t\tret = hns3_update_imissed_stats(hw, true);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"clear imissed stats failed, ret = %d\",\n+\t\t\t\t ret);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \t/*\n \t * Clear soft stats of rx error packet which will be dropped\n \t * in driver.\n@@ -928,6 +1009,7 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n \tstruct hns3_pf *pf = &hns->pf;\n \tstruct hns3_hw *hw = &hns->hw;\n+\tstruct hns3_rx_missed_stats *imissed_stats = &hw->imissed_stats;\n \tstruct hns3_mac_stats *mac_stats = &hw->mac_stats;\n \tstruct hns3_reset_stats *reset_stats = &hw->reset.stats;\n \tstruct hns3_rx_bd_errors_stats *rx_err_stats;\n@@ -966,6 +1048,21 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \t\t\tcount++;\n \t\t}\n \n+\t\tret = hns3_update_imissed_stats(hw, false);\n+\t\tif (ret) {\n+\t\t\thns3_err(hw, \"update imissed stats failed, ret = %d\",\n+\t\t\t\t ret);\n+\t\t\treturn ret;\n+\t\t}\n+\n+\t\tfor (i = 0; i < HNS3_NUM_IMISSED_XSTATS; i++) {\n+\t\t\taddr = (char *)imissed_stats +\n+\t\t\t\thns3_imissed_stats_strings[i].offset;\n+\t\t\txstats[count].value = *(uint64_t *)addr;\n+\t\t\txstats[count].id = count;\n+\t\t\tcount++;\n+\t\t}\n+\n \t\tfor (i = 0; i < HNS3_NUM_ERROR_INT_XSTATS; i++) {\n \t\t\taddr = (char *)&pf->abn_int_stats +\n \t\t\t       hns3_error_int_stats_strings[i].offset;\n@@ -1108,6 +1205,13 @@ hns3_dev_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\tcount++;\n \t\t}\n \n+\t\tfor (i = 0; i < HNS3_NUM_IMISSED_XSTATS; i++) {\n+\t\t\tsnprintf(xstats_names[count].name,\n+\t\t\t\t sizeof(xstats_names[count].name),\n+\t\t\t\t \"%s\", hns3_imissed_stats_strings[i].name);\n+\t\t\tcount++;\n+\t\t}\n+\n \t\tfor (i = 0; i < HNS3_NUM_ERROR_INT_XSTATS; i++) {\n \t\t\tsnprintf(xstats_names[count].name,\n \t\t\t\t sizeof(xstats_names[count].name),\ndiff --git a/drivers/net/hns3/hns3_stats.h b/drivers/net/hns3/hns3_stats.h\nindex d213be5..01b4f36 100644\n--- a/drivers/net/hns3/hns3_stats.h\n+++ b/drivers/net/hns3/hns3_stats.h\n@@ -110,6 +110,10 @@ struct hns3_mac_stats {\n \tuint64_t mac_rx_ctrl_pkt_num;\n };\n \n+struct hns3_rx_missed_stats {\n+\tuint64_t rpu_rx_drop_cnt;\n+};\n+\n /* store statistics names and its offset in stats structure */\n struct hns3_xstats_name_offset {\n \tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n@@ -141,6 +145,9 @@ struct hns3_reset_stats;\n #define HNS3_TXQ_BASIC_STATS_FIELD_OFFSET(f) \\\n \t(offsetof(struct hns3_tx_basic_stats, f))\n \n+#define HNS3_IMISSED_STATS_FIELD_OFFSET(f) \\\n+\t(offsetof(struct hns3_rx_missed_stats, f))\n+\n int hns3_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats);\n int hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \t\t\tunsigned int n);\n@@ -160,5 +167,6 @@ int hns3_stats_reset(struct rte_eth_dev *dev);\n void hns3_error_int_stats_add(struct hns3_adapter *hns, const char *err);\n int hns3_tqp_stats_init(struct hns3_hw *hw);\n void hns3_tqp_stats_uninit(struct hns3_hw *hw);\n+int hns3_update_imissed_stats(struct hns3_hw *hw, bool is_clear);\n \n #endif /* _HNS3_STATS_H_ */\n",
    "prefixes": [
        "V3",
        "05/14"
    ]
}