Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88411/?format=api
http://patches.dpdk.org/api/patches/88411/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210303072755.82979-1-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210303072755.82979-1-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210303072755.82979-1-yong.liu@intel.com", "date": "2021-03-03T07:27:55", "name": "vhost: fix accessing uninitialized variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bc2e24373cd9685f47d276960e19832b69bb30c6", "submitter": { "id": 17, "url": "http://patches.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210303072755.82979-1-yong.liu@intel.com/mbox/", "series": [ { "id": 15463, "url": "http://patches.dpdk.org/api/series/15463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15463", "date": "2021-03-03T07:27:55", "name": "vhost: fix accessing uninitialized variables", "version": 1, "mbox": "http://patches.dpdk.org/series/15463/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88411/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3E60A055D;\n\tWed, 3 Mar 2021 08:28:55 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5D20440683;\n\tWed, 3 Mar 2021 08:28:55 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 634A74067B;\n Wed, 3 Mar 2021 08:28:53 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2021 23:28:52 -0800", "from npg-dpdk-virtual-marvin-dev.sh.intel.com ([10.67.119.108])\n by orsmga008.jf.intel.com with ESMTP; 02 Mar 2021 23:28:50 -0800" ], "IronPort-SDR": [ "\n +38Kv9HMUXOA6Q90S2ORJqv0vxwobrBMif/E+QBhBcYt4k3su/fJ6jKx6WMXZYckB0BBnWWsbd\n QhdINRdbnLsg==", "\n fk+zWldeglpr7RHhXRTvt16ti5LuxmP1gSGUaN0vTYwTPr9MNIj2uUjP7i47eccucjfiH1Oi97\n hKrbij+pxZGw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9911\"; a=\"187243587\"", "E=Sophos;i=\"5.81,219,1610438400\"; d=\"scan'208\";a=\"187243587\"", "E=Sophos;i=\"5.81,219,1610438400\"; d=\"scan'208\";a=\"407118248\"" ], "X-ExtLoop1": "1", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tchenbo.xia@intel.com", "Cc": "dev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>,\n\tstable@dpdk.org", "Date": "Wed, 3 Mar 2021 15:27:55 +0800", "Message-Id": "<20210303072755.82979-1-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] vhost: fix accessing uninitialized variables", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixs coverity issue by adding initialization step before\nusing temporary virtio header.\n\nCoverity issue: 366181, 366123\nFixes: fb3815cc614d (\"vhost: handle virtually non-contiguous buffers in Rx-mrg\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 583bf379c6..fe464b3088 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -808,9 +808,10 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \n \thdr_mbuf = m;\n \thdr_addr = buf_addr;\n-\tif (unlikely(buf_len < dev->vhost_hlen))\n+\tif (unlikely(buf_len < dev->vhost_hlen)) {\n+\t\tmemset(&tmp_hdr, 0, sizeof(struct virtio_net_hdr_mrg_rxbuf));\n \t\thdr = &tmp_hdr;\n-\telse\n+\t} else\n \t\thdr = (struct virtio_net_hdr_mrg_rxbuf *)(uintptr_t)hdr_addr;\n \n \tVHOST_LOG_DATA(DEBUG, \"(%d) RX: num merge buffers %d\\n\",\n", "prefixes": [] }{ "id": 88411, "url": "