Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88396/?format=api
http://patches.dpdk.org/api/patches/88396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210302152658.9136-3-talshn@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210302152658.9136-3-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210302152658.9136-3-talshn@nvidia.com", "date": "2021-03-02T15:26:58", "name": "[v2,2/2] eal: rename key opaque pointer in TLS API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "58182bd0f7deabce30c42a07df7c6b589a41920c", "submitter": { "id": 1893, "url": "http://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210302152658.9136-3-talshn@nvidia.com/mbox/", "series": [ { "id": 15452, "url": "http://patches.dpdk.org/api/series/15452/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15452", "date": "2021-03-02T15:26:57", "name": "EAL Thread TLS API enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/15452/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88396/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 686D9A054F;\n\tTue, 2 Mar 2021 16:28:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2996622A293;\n\tTue, 2 Mar 2021 16:28:34 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id AC9B322A278\n for <dev@dpdk.org>; Tue, 2 Mar 2021 16:28:30 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@nvidia.com) with SMTP; 2 Mar 2021 17:28:21 +0200", "from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 122FSL2W024047;\n Tue, 2 Mar 2021 17:28:21 +0200" ], "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,\n navasile@linux.microsoft.com, dmitrym@microsoft.com,\n david.marchand@redhat.com, anatoly.burakov@intel.com,\n vladimir.medvedkin@intel.com, mb@smartsharesystems.com", "Date": "Tue, 2 Mar 2021 17:26:58 +0200", "Message-Id": "<20210302152658.9136-3-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "In-Reply-To": "<20210302152658.9136-1-talshn@nvidia.com>", "References": "<20210302152658.9136-1-talshn@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 2/2] eal: rename key opaque pointer in TLS API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rename the key opaque pointer from rte_tls_key to\nrte_thread_key to avoid confusion with transport layer security.\n\nSuggested-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_flow_os.c | 2 +-\n drivers/net/mlx5/windows/mlx5_flow_os.c | 2 +-\n lib/librte_eal/include/rte_thread.h | 13 +++++++------\n lib/librte_eal/unix/rte_thread.c | 8 ++++----\n lib/librte_eal/windows/rte_thread.c | 8 ++++----\n 5 files changed, 17 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_flow_os.c b/drivers/net/mlx5/linux/mlx5_flow_os.c\nindex 732b1b2dd8..80b25ca25a 100644\n--- a/drivers/net/mlx5/linux/mlx5_flow_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_flow_os.c\n@@ -7,7 +7,7 @@\n #include <rte_thread.h>\n \n /* Key of thread specific flow workspace data. */\n-static rte_tls_key key_workspace;\n+static rte_thread_key key_workspace;\n \n int\n mlx5_flow_os_init_workspace_once(void)\ndiff --git a/drivers/net/mlx5/windows/mlx5_flow_os.c b/drivers/net/mlx5/windows/mlx5_flow_os.c\nindex 2cc02df322..8f4dd99fac 100644\n--- a/drivers/net/mlx5/windows/mlx5_flow_os.c\n+++ b/drivers/net/mlx5/windows/mlx5_flow_os.c\n@@ -252,7 +252,7 @@ struct mlx5_workspace_thread {\n */\n static struct mlx5_workspace_thread *curr;\n static struct mlx5_workspace_thread *first;\n-rte_tls_key ws_tls_index;\n+rte_thread_key ws_tls_index;\n static pthread_mutex_t lock_thread_list;\n \n static bool\ndiff --git a/lib/librte_eal/include/rte_thread.h b/lib/librte_eal/include/rte_thread.h\nindex 39737d1829..e44be3d252 100644\n--- a/lib/librte_eal/include/rte_thread.h\n+++ b/lib/librte_eal/include/rte_thread.h\n@@ -23,7 +23,7 @@ extern \"C\" {\n /**\n * TLS key type, an opaque pointer.\n */\n-typedef struct eal_tls_key *rte_tls_key;\n+typedef struct eal_tls_key *rte_thread_key;\n \n /**\n * Set core affinity of the current thread.\n@@ -63,7 +63,8 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n */\n \n __rte_experimental\n-int rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *));\n+int rte_thread_tls_key_create(rte_thread_key *key,\n+\t\t\tvoid (*destructor)(void *));\n \n /**\n * Delete a TLS data key visible to all threads in the process.\n@@ -76,7 +77,7 @@ int rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *));\n * On failure, a negative number and an error number is set in rte_errno.\n */\n __rte_experimental\n-int rte_thread_tls_key_delete(rte_tls_key key);\n+int rte_thread_tls_key_delete(rte_thread_key key);\n \n /**\n * Set value bound to the TLS key on behalf of the calling thread.\n@@ -84,14 +85,14 @@ int rte_thread_tls_key_delete(rte_tls_key key);\n * @param key\n * The key allocated by rte_thread_tls_key_create().\n * @param value\n- * The value bound to the rte_tls_key key for the calling thread.\n+ * The value bound to the rte_thread_key key for the calling thread.\n *\n * @return\n * On success, zero.\n * On failure, a negative number and an error number is set in rte_errno.\n */\n __rte_experimental\n-int rte_thread_tls_value_set(rte_tls_key key, const void *value);\n+int rte_thread_tls_value_set(rte_thread_key key, const void *value);\n \n /**\n * Get value bound to the TLS key on behalf of the calling thread.\n@@ -104,7 +105,7 @@ int rte_thread_tls_value_set(rte_tls_key key, const void *value);\n * On failure, NULL and an error number is set in rte_errno.\n */\n __rte_experimental\n-void *rte_thread_tls_value_get(rte_tls_key key);\n+void *rte_thread_tls_value_get(rte_thread_key key);\n \n #ifdef __cplusplus\n }\ndiff --git a/lib/librte_eal/unix/rte_thread.c b/lib/librte_eal/unix/rte_thread.c\nindex 86e42bf653..923b069f77 100644\n--- a/lib/librte_eal/unix/rte_thread.c\n+++ b/lib/librte_eal/unix/rte_thread.c\n@@ -17,7 +17,7 @@ struct eal_tls_key {\n };\n \n int\n-rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *))\n+rte_thread_tls_key_create(rte_thread_key *key, void (*destructor)(void *))\n {\n \tint err;\n \n@@ -39,7 +39,7 @@ rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *))\n }\n \n int\n-rte_thread_tls_key_delete(rte_tls_key key)\n+rte_thread_tls_key_delete(rte_thread_key key)\n {\n \tint err;\n \n@@ -61,7 +61,7 @@ rte_thread_tls_key_delete(rte_tls_key key)\n }\n \n int\n-rte_thread_tls_value_set(rte_tls_key key, const void *value)\n+rte_thread_tls_value_set(rte_thread_key key, const void *value)\n {\n \tint err;\n \n@@ -81,7 +81,7 @@ rte_thread_tls_value_set(rte_tls_key key, const void *value)\n }\n \n void *\n-rte_thread_tls_value_get(rte_tls_key key)\n+rte_thread_tls_value_get(rte_thread_key key)\n {\n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\ndiff --git a/lib/librte_eal/windows/rte_thread.c b/lib/librte_eal/windows/rte_thread.c\nindex 1c226b3e30..1e56ef6090 100644\n--- a/lib/librte_eal/windows/rte_thread.c\n+++ b/lib/librte_eal/windows/rte_thread.c\n@@ -12,7 +12,7 @@ struct eal_tls_key {\n };\n \n int\n-rte_thread_tls_key_create(rte_tls_key *key,\n+rte_thread_tls_key_create(rte_thread_key *key,\n \t\t__rte_unused void (*destructor)(void *))\n {\n \t*key = malloc(sizeof(**key));\n@@ -32,7 +32,7 @@ rte_thread_tls_key_create(rte_tls_key *key,\n }\n \n int\n-rte_thread_tls_key_delete(rte_tls_key key)\n+rte_thread_tls_key_delete(rte_thread_key key)\n {\n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n@@ -50,7 +50,7 @@ rte_thread_tls_key_delete(rte_tls_key key)\n }\n \n int\n-rte_thread_tls_value_set(rte_tls_key key, const void *value)\n+rte_thread_tls_value_set(rte_thread_key key, const void *value)\n {\n \tchar *p;\n \n@@ -70,7 +70,7 @@ rte_thread_tls_value_set(rte_tls_key key, const void *value)\n }\n \n void *\n-rte_thread_tls_value_get(rte_tls_key key)\n+rte_thread_tls_value_get(rte_thread_key key)\n {\n \tvoid *output;\n \n", "prefixes": [ "v2", "2/2" ] }{ "id": 88396, "url": "