Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 88395,
    "url": "http://patches.dpdk.org/api/patches/88395/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210302152658.9136-2-talshn@nvidia.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210302152658.9136-2-talshn@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210302152658.9136-2-talshn@nvidia.com",
    "date": "2021-03-02T15:26:57",
    "name": "[v2,1/2] eal: error number enhancement for thread TLS API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "631bf4ca831a03b3be738d26e4be7338115f7c69",
    "submitter": {
        "id": 1893,
        "url": "http://patches.dpdk.org/api/people/1893/?format=api",
        "name": "Tal Shnaiderman",
        "email": "talshn@nvidia.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210302152658.9136-2-talshn@nvidia.com/mbox/",
    "series": [
        {
            "id": 15452,
            "url": "http://patches.dpdk.org/api/series/15452/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15452",
            "date": "2021-03-02T15:26:57",
            "name": "EAL Thread TLS API enhancements",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/15452/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/88395/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/88395/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7F404A054F;\n\tTue,  2 Mar 2021 16:28:39 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D975622A280;\n\tTue,  2 Mar 2021 16:28:32 +0100 (CET)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id A813640693\n for <dev@dpdk.org>; Tue,  2 Mar 2021 16:28:30 +0100 (CET)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@nvidia.com) with SMTP; 2 Mar 2021 17:28:21 +0200",
            "from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 122FSL2V024047;\n Tue, 2 Mar 2021 17:28:21 +0200"
        ],
        "From": "Tal Shnaiderman <talshn@nvidia.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,\n navasile@linux.microsoft.com, dmitrym@microsoft.com,\n david.marchand@redhat.com, anatoly.burakov@intel.com,\n vladimir.medvedkin@intel.com, mb@smartsharesystems.com",
        "Date": "Tue,  2 Mar 2021 17:26:57 +0200",
        "Message-Id": "<20210302152658.9136-2-talshn@nvidia.com>",
        "X-Mailer": "git-send-email 2.16.1.windows.4",
        "In-Reply-To": "<20210302152658.9136-1-talshn@nvidia.com>",
        "References": "<20210302152658.9136-1-talshn@nvidia.com>",
        "Subject": "[dpdk-dev] [PATCH v2 1/2] eal: error number enhancement for thread\n TLS API",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "add error number reporting to rte_errno in all\nfunctions in the rte_thread_tls_* API.\n\nSuggested-by: Anatoly Burakov <anatoly.burakov@intel.com>\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\n---\n lib/librte_eal/include/rte_thread.h | 6 +++---\n lib/librte_eal/unix/rte_thread.c    | 6 ++++++\n lib/librte_eal/windows/rte_thread.c | 8 +++++++-\n 3 files changed, 16 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/include/rte_thread.h b/lib/librte_eal/include/rte_thread.h\nindex e640ea1857..39737d1829 100644\n--- a/lib/librte_eal/include/rte_thread.h\n+++ b/lib/librte_eal/include/rte_thread.h\n@@ -59,7 +59,7 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n  *\n  * @return\n  *   On success, zero.\n- *   On failure, a negative number.\n+ *   On failure, a negative number and an error number is set in rte_errno.\n  */\n \n __rte_experimental\n@@ -73,7 +73,7 @@ int rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *));\n  *\n  * @return\n  *   On success, zero.\n- *   On failure, a negative number.\n+ *   On failure, a negative number and an error number is set in rte_errno.\n  */\n __rte_experimental\n int rte_thread_tls_key_delete(rte_tls_key key);\n@@ -88,7 +88,7 @@ int rte_thread_tls_key_delete(rte_tls_key key);\n  *\n  * @return\n  *   On success, zero.\n- *   On failure, a negative number.\n+ *   On failure, a negative number and an error number is set in rte_errno.\n  */\n __rte_experimental\n int rte_thread_tls_value_set(rte_tls_key key, const void *value);\ndiff --git a/lib/librte_eal/unix/rte_thread.c b/lib/librte_eal/unix/rte_thread.c\nindex 86ffeebc95..86e42bf653 100644\n--- a/lib/librte_eal/unix/rte_thread.c\n+++ b/lib/librte_eal/unix/rte_thread.c\n@@ -24,6 +24,7 @@ rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *))\n \t*key = malloc(sizeof(**key));\n \tif ((*key) == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Cannot allocate TLS key.\\n\");\n+\t\trte_errno = ENOMEM;\n \t\treturn -1;\n \t}\n \terr = pthread_key_create(&((*key)->thread_index), destructor);\n@@ -31,6 +32,7 @@ rte_thread_tls_key_create(rte_tls_key *key, void (*destructor)(void *))\n \t\tRTE_LOG(DEBUG, EAL, \"pthread_key_create failed: %s\\n\",\n \t\t\t strerror(err));\n \t\tfree(*key);\n+\t\trte_errno = err;\n \t\treturn -1;\n \t}\n \treturn 0;\n@@ -43,6 +45,7 @@ rte_thread_tls_key_delete(rte_tls_key key)\n \n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n+\t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n \terr = pthread_key_delete(key->thread_index);\n@@ -50,6 +53,7 @@ rte_thread_tls_key_delete(rte_tls_key key)\n \t\tRTE_LOG(DEBUG, EAL, \"pthread_key_delete failed: %s\\n\",\n \t\t\t strerror(err));\n \t\tfree(key);\n+\t\trte_errno = err;\n \t\treturn -1;\n \t}\n \tfree(key);\n@@ -63,12 +67,14 @@ rte_thread_tls_value_set(rte_tls_key key, const void *value)\n \n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n+\t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n \terr = pthread_setspecific(key->thread_index, value);\n \tif (err) {\n \t\tRTE_LOG(DEBUG, EAL, \"pthread_setspecific failed: %s\\n\",\n \t\t\tstrerror(err));\n+\t\trte_errno = err;\n \t\treturn -1;\n \t}\n \treturn 0;\ndiff --git a/lib/librte_eal/windows/rte_thread.c b/lib/librte_eal/windows/rte_thread.c\nindex 2e2ab29177..1c226b3e30 100644\n--- a/lib/librte_eal/windows/rte_thread.c\n+++ b/lib/librte_eal/windows/rte_thread.c\n@@ -18,12 +18,14 @@ rte_thread_tls_key_create(rte_tls_key *key,\n \t*key = malloc(sizeof(**key));\n \tif ((*key) == NULL) {\n \t\tRTE_LOG(DEBUG, EAL, \"Cannot allocate TLS key.\\n\");\n+\t\trte_errno = ENOMEM;\n \t\treturn -1;\n \t}\n \t(*key)->thread_index = TlsAlloc();\n \tif ((*key)->thread_index == TLS_OUT_OF_INDEXES) {\n \t\tRTE_LOG_WIN32_ERR(\"TlsAlloc()\");\n \t\tfree(*key);\n+\t\trte_errno = GetLastError();\n \t\treturn -1;\n \t}\n \treturn 0;\n@@ -34,11 +36,13 @@ rte_thread_tls_key_delete(rte_tls_key key)\n {\n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n+\t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n \tif (!TlsFree(key->thread_index)) {\n \t\tRTE_LOG_WIN32_ERR(\"TlsFree()\");\n \t\tfree(key);\n+\t\trte_errno = GetLastError();\n \t\treturn -1;\n \t}\n \tfree(key);\n@@ -52,12 +56,14 @@ rte_thread_tls_value_set(rte_tls_key key, const void *value)\n \n \tif (!key) {\n \t\tRTE_LOG(DEBUG, EAL, \"Invalid TLS key.\\n\");\n+\t\trte_errno = EINVAL;\n \t\treturn -1;\n \t}\n \t/* discard const qualifier */\n \tp = (char *) (uintptr_t) value;\n \tif (!TlsSetValue(key->thread_index, p)) {\n \t\tRTE_LOG_WIN32_ERR(\"TlsSetValue()\");\n+\t\trte_errno = GetLastError();\n \t\treturn -1;\n \t}\n \treturn 0;\n@@ -76,7 +82,7 @@ rte_thread_tls_value_get(rte_tls_key key)\n \toutput = TlsGetValue(key->thread_index);\n \tif (GetLastError() != ERROR_SUCCESS) {\n \t\tRTE_LOG_WIN32_ERR(\"TlsGetValue()\");\n-\t\trte_errno = ENOEXEC;\n+\t\trte_errno = GetLastError();\n \t\treturn NULL;\n \t}\n \treturn output;\n",
    "prefixes": [
        "v2",
        "1/2"
    ]
}