Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88286/?format=api
{ "id": 88286, "url": "http://patches.dpdk.org/api/patches/88286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210228125353.2436562-17-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210228125353.2436562-17-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20210228125353.2436562-17-thomas@monjalon.net", "date": "2021-02-28T12:53:51", "name": "[v6,16/17] app/testpmd: fix build with musl", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1796c3c1d96bd6ba11fae44de5ac98b7e1c0433e", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210228125353.2436562-17-thomas@monjalon.net/mbox/", "series": [ { "id": 15401, "url": "http://patches.dpdk.org/api/series/15401/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15401", "date": "2021-02-28T12:53:35", "name": "Alpine/musl build support", "version": 6, "mbox": "http://patches.dpdk.org/series/15401/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88286/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88286/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 16588A0548;\n\tSun, 28 Feb 2021 13:56:33 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 74E6322A2F1;\n\tSun, 28 Feb 2021 13:54:30 +0100 (CET)", "from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com\n [64.147.123.19])\n by mails.dpdk.org (Postfix) with ESMTP id 2A68D22A2EC;\n Sun, 28 Feb 2021 13:54:29 +0100 (CET)", "from compute2.internal (compute2.nyi.internal [10.202.2.42])\n by mailout.west.internal (Postfix) with ESMTP id D5AAD5D4;\n Sun, 28 Feb 2021 07:54:27 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n by compute2.internal (MEProxy); Sun, 28 Feb 2021 07:54:28 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 9056C1080057;\n Sun, 28 Feb 2021 07:54:26 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-type:content-transfer-encoding; s=fm3; bh=\n uuctzikRObxp0/hu4uvMy6utWUI8ejyogHL8LYIO85g=; b=zQVbP9m+42ff17TV\n t8Of10ttZsawIjzEVcXEnNTj0scjNztb3rZ+SRo9J2jiYsKg9QyGXvlWkHr2PkqK\n t005Ah9sGnFyb9L2Skyb08qBDIUTfahAdW5m7DQTiW6jilqrSWCVolJDiQNcV2wr\n iyTsF/x3uWZGU4rjitLF2Qqs56nM4ifLFbPRMisYrk5U0e67MUFGvYUJrX8L5BG7\n yIOqO4MMRcrz6h2Xmk5BybL633dJ5kUxtFH6waokc/qE/D9kEbqXLyW/CN7j4y2t\n vwgRu3F+sum2fAvtCLfYiX3W9cp90t/q1MmUwOKQ1U/sH71gB+rMZe6Vg28iRirU\n /xH+VA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:content-type\n :date:from:in-reply-to:message-id:mime-version:references\n :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender\n :x-sasl-enc; s=fm2; bh=uuctzikRObxp0/hu4uvMy6utWUI8ejyogHL8LYIO8\n 5g=; b=DMPMmeqxM/zPsGuhA91OhYqurej+vgkZU7MFpKMaF1+YHKxvCqMoHjTlu\n Fs1uwVQ5pTh9/81e7WsFeGCanD/Pc3J1ka/9pRWmrc9vJ9tbu2nRv9cMpdOdwFHW\n WIYvNdzm8QwSIXGsoFlLH+/SvxKGaYDP/NIX4CKn7FSoho5ZOVpNpqdBlVtfK39/\n qvmVVCjLNhcEwo5gIsWsZuZ5HCYHPd+ud8QwliuJoTfpwyxvVfBE0bpMRoeCt04m\n 2Ehl7gRymWN2q5rgTZkkvva7PDDwQGAioiw0ILWSGbi59orrnImOdirvi9wQ3O4s\n g9/nEMIwUmizqmRQaSZvl1HvPKQng==" ], "X-ME-Sender": "<xms:g5I7YOW1_fCO0u4vfkGdVh5KMiXukNVZ1NADVLNdWeHUTMxIOybKiA>\n <xme:g5I7YKlMhBrgSRsWYiqlHLVzOLZmQZI0LG0E20on0m_sds1CLJMJUdyyj--DMt22w\n Z0-wbHNQj11Qm2cQQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduledrleeigdegkecutefuodetggdotefrodftvf\n curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc\n fjughrpefhvffufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvedutdevueevjeekveehheevffeugeejudekffeltdelkeeifeeg\n udehvdegjefhnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl\n ohhnrdhnvght", "X-ME-Proxy": "<xmx:g5I7YCbSYFhIM0joNDklUZZpTkQIvppOyZtYc3kJQRPuieamh--hEA>\n <xmx:g5I7YFUK85GnMe4hg8Vb_0iH2sLqf5dh6auEfZz6Eqb30Ihnovz2Ew>\n <xmx:g5I7YImIY_j6w3BxagSYtQfUwZpBJ4kSvuJRaRRUMBP8EqIUshgWwA>\n <xmx:g5I7YHt7GTylHHuu-KVxxQa_ed2ZHyCLz4W7ZVMMZtuMWSiOPxexsg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ncopa@alpinelinux.org, stable@dpdk.org,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>,\n =?utf-8?q?N=C3=A9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>,\n Ferruh Yigit <ferruh.yigit@intel.com>", "Date": "Sun, 28 Feb 2021 13:53:51 +0100", "Message-Id": "<20210228125353.2436562-17-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.30.1", "In-Reply-To": "<20210228125353.2436562-1-thomas@monjalon.net>", "References": "<20190313170657.16688-1-ncopa@alpinelinux.org>\n <20210228125353.2436562-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 16/17] app/testpmd: fix build with musl", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Natanael Copa <ncopa@alpinelinux.org>\n\n1/ Improve portability by avoiding use of non-standard 'uint'.\nUse uint8_t for hash_key_len as rss_key_len is a uint8_t type.\nThis solves following build error when building with musl libc:\n app/test-pmd/testpmd.h:813:29: error: unknown type name 'uint'\n\n2/ In musl libc, stdout is of type (FILE * const).\nBecause of the const qualifier, a dark magic cast\nmust be achieved through uintptr_t.\n\nFixes: 8205e241b2b0 (\"app/testpmd: add missing type to RSS hash commands\")\nFixes: e977e4199a8d (\"app/testpmd: add commands to load/unload BPF filters\")\nCc: stable@dpdk.org\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/bpf_cmd.c | 2 +-\n app/test-pmd/config.c | 2 +-\n app/test-pmd/testpmd.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c\nindex 066619e115..6980291f07 100644\n--- a/app/test-pmd/bpf_cmd.c\n+++ b/app/test-pmd/bpf_cmd.c\n@@ -20,7 +20,7 @@ static const struct rte_bpf_xsym bpf_xsym[] = {\n \t\t.name = RTE_STR(stdout),\n \t\t.type = RTE_BPF_XTYPE_VAR,\n \t\t.var = {\n-\t\t\t.val = &stdout,\n+\t\t\t.val = (void *)(uintptr_t)&stdout,\n \t\t\t.desc = {\n \t\t\t\t.type = RTE_BPF_ARG_PTR,\n \t\t\t\t.size = sizeof(stdout),\ndiff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex dab8afe5dd..9ca03c236e 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -2963,7 +2963,7 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key)\n \n void\n port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key,\n-\t\t\t uint hash_key_len)\n+\t\t\t uint8_t hash_key_len)\n {\n \tstruct rte_eth_rss_conf rss_conf;\n \tint diag;\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex 4aca522859..5437b6229e 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -935,7 +935,7 @@ int set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate,\n \n void port_rss_hash_conf_show(portid_t port_id, int show_rss_key);\n void port_rss_hash_key_update(portid_t port_id, char rss_type[],\n-\t\t\t uint8_t *hash_key, uint hash_key_len);\n+\t\t\t uint8_t *hash_key, uint8_t hash_key_len);\n int rx_queue_id_is_invalid(queueid_t rxq_id);\n int tx_queue_id_is_invalid(queueid_t txq_id);\n void setup_gro(const char *onoff, portid_t port_id);\n", "prefixes": [ "v6", "16/17" ] }