Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88229/?format=api
{ "id": 88229, "url": "http://patches.dpdk.org/api/patches/88229/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210225152903.148347-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210225152903.148347-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210225152903.148347-2-bruce.richardson@intel.com", "date": "2021-02-25T15:29:01", "name": "[1/3] build: enable a developer mode setting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1db9b5f49a3dff92f03a38d352f1c0f8b8ac2647", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210225152903.148347-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 15386, "url": "http://patches.dpdk.org/api/series/15386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15386", "date": "2021-02-25T15:29:00", "name": "Add developer mode to DPDK build", "version": 1, "mbox": "http://patches.dpdk.org/series/15386/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88229/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9869A034F;\n\tThu, 25 Feb 2021 16:29:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7A6A41607FF;\n\tThu, 25 Feb 2021 16:29:17 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 7239A1607FB\n for <dev@dpdk.org>; Thu, 25 Feb 2021 16:29:16 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Feb 2021 07:29:16 -0800", "from silpixa00399126.ir.intel.com ([10.237.223.204])\n by orsmga006.jf.intel.com with ESMTP; 25 Feb 2021 07:29:14 -0800" ], "IronPort-SDR": [ "\n dpK10xCVsyCvBjMh1b8uP26kd0H2hAXrHjDL7f3gtfJNtru18XBl6p7Afa9W4X/1/5qXl1BUq1\n NxLY/epU1iJQ==", "\n k2i23h647STxuO4wbtW6O6uu1YnTKfF4TWEhB2fhWVXjeQqdvs2QpDlsFutQ+fMV3MqCvwGZP7\n JJCclNF+l5+g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9905\"; a=\"249617656\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"249617656\"", "E=Sophos;i=\"5.81,206,1610438400\"; d=\"scan'208\";a=\"367432351\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, david.marchand@redhat.com,\n Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 25 Feb 2021 15:29:01 +0000", "Message-Id": "<20210225152903.148347-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210225152903.148347-1-bruce.richardson@intel.com>", "References": "<20210225152903.148347-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] build: enable a developer mode setting", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To allow support for additional build checks and tests only really\nrelevant for developers, we add support for a developer mode option to\nDPDK. The default, \"auto\", value for this enables developer mode if a\n\".git\" folder is found at the root of the source tree - as was the case\nwith the previous \"make\" build system. There is also support for\nexplicitly enabling or disabling this option using \"meson configure\" if\nso desired.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n doc/guides/contributing/coding_style.rst | 8 ++++++++\n meson.build | 14 ++++++++++++++\n meson_options.txt | 2 ++\n 3 files changed, 24 insertions(+)", "diff": "diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex 734d1901b2..fdcd21861d 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -798,6 +798,14 @@ Integrating with the Build System\n \n DPDK is built using the tools ``meson`` and ``ninja``.\n \n+.. note::\n+\n+ In order to catch possible issues as soon as possible,\n+ it is recommended that developers build DPDK in \"developer mode\" to enable additional checks.\n+ By default, this mode is enabled if the build is being done from a git checkout,\n+ but the mode can be manually enabled/disabled using the\n+ ``developer_mode`` meson configuration option.\n+\n Therefore all new component additions should include a ``meson.build`` file,\n and should be added to the component lists in the ``meson.build`` files in the\n relevant top-level directory:\ndiff --git a/meson.build b/meson.build\nindex fcc4d4c900..8906b5e0b5 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -11,6 +11,20 @@ project('DPDK', 'C',\n \tmeson_version: '>= 0.47.1'\n )\n \n+# check for developer mode\n+developer_mode = false\n+if get_option('developer_mode').auto()\n+\tif meson.version().version_compare('>=0.53') # fs module available\n+\t\tfs = import('fs')\n+\t\tdeveloper_mode = fs.is_dir('.git')\n+\tendif\n+else\n+\tdeveloper_mode = get_option('developer_mode').enabled()\n+endif\n+if developer_mode\n+\tmessage('## Building in Developer Mode ##')\n+endif\n+\n # set up some global vars for compiler, platform, configuration, etc.\n cc = meson.get_compiler('c')\n dpdk_conf = configuration_data()\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 6eff62e47d..fe0f9ed501 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -2,6 +2,8 @@\n \n option('check_includes', type: 'boolean', value: false,\n \tdescription: 'build \"chkincs\" to verify each header file can compile alone')\n+option('developer_mode', type: 'feature',\n+\tdescription: 'turn on additional build checks relevant for DPDK developers')\n option('disable_drivers', type: 'string', value: '',\n \tdescription: 'Comma-separated list of drivers to explicitly disable.')\n option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',\n", "prefixes": [ "1/3" ] }