Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88065/?format=api
{ "id": 88065, "url": "http://patches.dpdk.org/api/patches/88065/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210221142819.6769-7-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210221142819.6769-7-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210221142819.6769-7-dmitry.kozliuk@gmail.com", "date": "2021-02-21T14:28:18", "name": "[v3,6/7] drivers: remove POSIX dependencies", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "62add6bbfe5566abfb047b3944fee8450d49b1fb", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210221142819.6769-7-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 15322, "url": "http://patches.dpdk.org/api/series/15322/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15322", "date": "2021-02-21T14:28:12", "name": "eal/windows: do not expose POSIX symbols", "version": 3, "mbox": "http://patches.dpdk.org/series/15322/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88065/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/88065/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F6C4A034F;\n\tSun, 21 Feb 2021 15:29:14 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 21B3F22A2D9;\n\tSun, 21 Feb 2021 15:28:37 +0100 (CET)", "from mail-lj1-f175.google.com (mail-lj1-f175.google.com\n [209.85.208.175])\n by mails.dpdk.org (Postfix) with ESMTP id BF8B322A2C3\n for <dev@dpdk.org>; Sun, 21 Feb 2021 15:28:33 +0100 (CET)", "by mail-lj1-f175.google.com with SMTP id e8so10453169ljj.5\n for <dev@dpdk.org>; Sun, 21 Feb 2021 06:28:33 -0800 (PST)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id a30sm1569885lfo.56.2021.02.21.06.28.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 21 Feb 2021 06:28:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=Hj6nlfyINy4JqhZBvmbQFP7COVG0nPkA5j9iJp4hv5M=;\n b=oFRccWRRM7Te0A8QdY/itQZCDHmm7yHBOIx28GD/hvwv73R5X/BqmlFt4jfyILU0Qt\n b4s6AzhNd6hvyDITGkw62E7YkPNLKXhBqF6Bf2SppBA6fezHuGbeMxjXyht0hPT65rfW\n hXMCHPOKUmI56K9DpI5v1FXs9P8Hfxi7oeOyiWarOHrwtm9s/A8RECtNkUv/ZeJO4R6J\n 8gFjUqDh7gqcaj3E7eXBwbzuVWskGFuQRV9hB7+gEk/9/QQM6bvgAsHX9VOdngKgdTEp\n zLAaglLC5SoY2oNu/18lUQ5iKHRrvDvfvL+euGwgkrslP5UOt+WMEb6knBYy/CCko9uZ\n 5sPw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=Hj6nlfyINy4JqhZBvmbQFP7COVG0nPkA5j9iJp4hv5M=;\n b=FHJZv8aKXz6jUgolPFFMpHljxIHprLvysCnN+HASIHFYTFriJXq74WgPrPklGLGTOj\n waVHxUyDTin++kHWJYLejfiAfSjJY2F/sPK9Gy0OBJN7k8tPcygiA7GHxlIb3HUmZUtY\n 03xNWmTawn4UDJeR6ranVBijT1XOQpiPqwaFqxNaOwxK9eliQwwKrD42R/lZ/SVhpiQI\n 7IOwaTN3GQc8Z+Tivse7zyrZUNqesnmNWOZO7O/5a6c/QJltrig6z4+KhgmJdsf8Yh7Z\n vZL56zb8MyNqZjRUvKe6V2nUEUjy2F12P9ygU8WSd+Ac05IYhZYJW4ZdwKrXjwIsjaLe\n 7tdg==", "X-Gm-Message-State": "AOAM533Zj+Yzuy2hGomTkXKXRb1dUrTYY+6G5kchSo038aNdmH1/PUUK\n XTImfy6Ja7QvoIK3BfT3yY//Y/AI6if8sdXY", "X-Google-Smtp-Source": "\n ABdhPJx4FkdHamyZzqvGBAzeKXDah7iIMJg3XsDmM+R31v/LE99oZGBCbCNyBNI+w6YGhMT6wZJgMw==", "X-Received": "by 2002:a2e:9903:: with SMTP id v3mr9921198lji.179.1613917713066;\n Sun, 21 Feb 2021 06:28:33 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Tal Shnaiderman <talshn@nvidia.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Matan Azrad <matan@nvidia.com>,\n Shahaf Shuler <shahafs@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>", "Date": "Sun, 21 Feb 2021 17:28:18 +0300", "Message-Id": "<20210221142819.6769-7-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210221142819.6769-1-dmitry.kozliuk@gmail.com>", "References": "<20210221012831.14643-1-dmitry.kozliuk@gmail.com>\n <20210221142819.6769-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 6/7] drivers: remove POSIX dependencies", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace POSIX strncasecmp() with EAL rte_strncasecmp().\nReplace POSIX strtok_r() with EAL rte_strtok().\nReplace POSIX strdup() with EAL rte_strdup().\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\ni40e: checkpatches.sh complains about long lines (it's ~85).\n I doubt that mechanical fix would keep the code readable.\n It's on 5th level of indentation, so I'd extract a function,\n but would like to hear from maintainers first.\n\n drivers/bus/pci/private.h | 2 +-\n drivers/bus/vdev/vdev.c | 4 +-\n drivers/bus/vdev/vdev_params.c | 3 +-\n drivers/common/mlx5/mlx5_common_pci.c | 6 +--\n drivers/common/mlx5/mlx5_common_pci.h | 1 +\n drivers/net/i40e/i40e_ethdev.c | 56 +++++++++++++--------------\n drivers/net/mlx5/mlx5.c | 4 ++\n 7 files changed, 41 insertions(+), 35 deletions(-)", "diff": "diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h\nindex f566943f5..5648916d1 100644\n--- a/drivers/bus/pci/private.h\n+++ b/drivers/bus/pci/private.h\n@@ -92,7 +92,7 @@ struct mapped_pci_resource {\n \tTAILQ_ENTRY(mapped_pci_resource) next;\n \n \tstruct rte_pci_addr pci_addr;\n-\tchar path[PATH_MAX];\n+\tchar path[RTE_PATH_MAX];\n \tint nb_maps;\n \tstruct pci_map maps[PCI_MAX_RESOURCE];\n \tstruct pci_msix_table msix_table;\ndiff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 9a673347a..a490d26a2 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -245,9 +245,9 @@ alloc_devargs(const char *name, const char *args)\n \n \tdevargs->bus = &rte_vdev_bus;\n \tif (args)\n-\t\tdevargs->args = strdup(args);\n+\t\tdevargs->args = rte_strdup(args);\n \telse\n-\t\tdevargs->args = strdup(\"\");\n+\t\tdevargs->args = rte_strdup(\"\");\n \n \tret = strlcpy(devargs->name, name, sizeof(devargs->name));\n \tif (ret < 0 || ret >= (int)sizeof(devargs->name)) {\ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 6f74704d1..64848f4c2 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -8,6 +8,7 @@\n #include <rte_bus.h>\n #include <rte_kvargs.h>\n #include <rte_errno.h>\n+#include <rte_string_fns.h>\n \n #include \"vdev_logs.h\"\n #include \"vdev_private.h\"\n@@ -31,7 +32,7 @@ vdev_dev_match(const struct rte_device *dev,\n \tchar *name;\n \n \t/* cannot pass const dev->name to rte_kvargs_process() */\n-\tname = strdup(dev->name);\n+\tname = rte_strdup(dev->name);\n \tif (name == NULL)\n \t\treturn -1;\n \tret = rte_kvargs_process(kvlist,\ndiff --git a/drivers/common/mlx5/mlx5_common_pci.c b/drivers/common/mlx5/mlx5_common_pci.c\nindex 2b657686d..0b2c50f46 100644\n--- a/drivers/common/mlx5/mlx5_common_pci.c\n+++ b/drivers/common/mlx5/mlx5_common_pci.c\n@@ -82,13 +82,13 @@ bus_cmdline_options_handler(__rte_unused const char *key,\n \tchar *refstr = NULL;\n \n \t*ret = 0;\n-\tnstr = strdup(class_names);\n+\tnstr = rte_strdup(class_names);\n \tif (!nstr) {\n \t\t*ret = -ENOMEM;\n \t\treturn *ret;\n \t}\n \tnstr_org = nstr;\n-\tfound = strtok_r(nstr, \":\", &refstr);\n+\tfound = rte_strtok(nstr, \":\", &refstr);\n \tif (!found)\n \t\tgoto err;\n \tdo {\n@@ -102,7 +102,7 @@ bus_cmdline_options_handler(__rte_unused const char *key,\n \t\t\tgoto err;\n \t\t}\n \t\t*ret |= class_val;\n-\t\tfound = strtok_r(NULL, \":\", &refstr);\n+\t\tfound = rte_strtok(NULL, \":\", &refstr);\n \t} while (found);\n err:\n \tfree(nstr_org);\ndiff --git a/drivers/common/mlx5/mlx5_common_pci.h b/drivers/common/mlx5/mlx5_common_pci.h\nindex de89bb98b..729d0f4cc 100644\n--- a/drivers/common/mlx5/mlx5_common_pci.h\n+++ b/drivers/common/mlx5/mlx5_common_pci.h\n@@ -45,6 +45,7 @@ extern \"C\" {\n \n #include <rte_pci.h>\n #include <rte_bus_pci.h>\n+#include <rte_string_fns.h>\n \n #include <mlx5_common.h>\n \ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex d7cd04989..5b806d201 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -12036,110 +12036,110 @@ i40e_update_customized_ptype(struct rte_eth_dev *dev, uint8_t *pkg,\n \t\t\t\tmemset(name, 0, sizeof(name));\n \t\t\t\tstrcpy(name, proto[n].name);\n \t\t\t\tPMD_DRV_LOG(INFO, \"name = %s\\n\", name);\n-\t\t\t\tif (!strncasecmp(name, \"PPPOE\", 5))\n+\t\t\t\tif (!rte_strncasecmp(name, \"PPPOE\", 5))\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L2_ETHER_PPPOE;\n-\t\t\t\telse if (!strncasecmp(name, \"IPV4FRAG\", 8) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"IPV4FRAG\", 8) &&\n \t\t\t\t\t !in_tunnel) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV4_EXT_UNKNOWN;\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_FRAG;\n-\t\t\t\t} else if (!strncasecmp(name, \"IPV4FRAG\", 8) &&\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"IPV4FRAG\", 8) &&\n \t\t\t\t\t in_tunnel) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_FRAG;\n-\t\t\t\t} else if (!strncasecmp(name, \"OIPV4\", 5)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"OIPV4\", 5)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV4_EXT_UNKNOWN;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"IPV4\", 4) &&\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"IPV4\", 4) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV4_EXT_UNKNOWN;\n-\t\t\t\telse if (!strncasecmp(name, \"IPV4\", 4) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"IPV4\", 4) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;\n-\t\t\t\telse if (!strncasecmp(name, \"IPV6FRAG\", 8) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"IPV6FRAG\", 8) &&\n \t\t\t\t\t !in_tunnel) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV6_EXT_UNKNOWN;\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_FRAG;\n-\t\t\t\t} else if (!strncasecmp(name, \"IPV6FRAG\", 8) &&\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"IPV6FRAG\", 8) &&\n \t\t\t\t\t in_tunnel) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN;\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_FRAG;\n-\t\t\t\t} else if (!strncasecmp(name, \"OIPV6\", 5)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"OIPV6\", 5)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV6_EXT_UNKNOWN;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"IPV6\", 4) &&\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"IPV6\", 4) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L3_IPV6_EXT_UNKNOWN;\n-\t\t\t\telse if (!strncasecmp(name, \"IPV6\", 4) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"IPV6\", 4) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN;\n-\t\t\t\telse if (!strncasecmp(name, \"UDP\", 3) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"UDP\", 3) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_UDP;\n-\t\t\t\telse if (!strncasecmp(name, \"UDP\", 3) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"UDP\", 3) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_UDP;\n-\t\t\t\telse if (!strncasecmp(name, \"TCP\", 3) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"TCP\", 3) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_TCP;\n-\t\t\t\telse if (!strncasecmp(name, \"TCP\", 3) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"TCP\", 3) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_TCP;\n-\t\t\t\telse if (!strncasecmp(name, \"SCTP\", 4) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"SCTP\", 4) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_SCTP;\n-\t\t\t\telse if (!strncasecmp(name, \"SCTP\", 4) &&\n+\t\t\t\telse if (!rte_strncasecmp(name, \"SCTP\", 4) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_SCTP;\n-\t\t\t\telse if ((!strncasecmp(name, \"ICMP\", 4) ||\n-\t\t\t\t\t !strncasecmp(name, \"ICMPV6\", 6)) &&\n+\t\t\t\telse if ((!rte_strncasecmp(name, \"ICMP\", 4) ||\n+\t\t\t\t\t !rte_strncasecmp(name, \"ICMPV6\", 6)) &&\n \t\t\t\t\t !in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_L4_ICMP;\n-\t\t\t\telse if ((!strncasecmp(name, \"ICMP\", 4) ||\n-\t\t\t\t\t !strncasecmp(name, \"ICMPV6\", 6)) &&\n+\t\t\t\telse if ((!rte_strncasecmp(name, \"ICMP\", 4) ||\n+\t\t\t\t\t !rte_strncasecmp(name, \"ICMPV6\", 6)) &&\n \t\t\t\t\t in_tunnel)\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_INNER_L4_ICMP;\n-\t\t\t\telse if (!strncasecmp(name, \"GTPC\", 4)) {\n+\t\t\t\telse if (!rte_strncasecmp(name, \"GTPC\", 4)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_TUNNEL_GTPC;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"GTPU\", 4)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"GTPU\", 4)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_TUNNEL_GTPU;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"ESP\", 3)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"ESP\", 3)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_TUNNEL_ESP;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"GRENAT\", 6)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"GRENAT\", 6)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_TUNNEL_GRENAT;\n \t\t\t\t\tin_tunnel = true;\n-\t\t\t\t} else if (!strncasecmp(name, \"L2TPV2CTL\", 9) ||\n-\t\t\t\t\t !strncasecmp(name, \"L2TPV2\", 6) ||\n-\t\t\t\t\t !strncasecmp(name, \"L2TPV3\", 6)) {\n+\t\t\t\t} else if (!rte_strncasecmp(name, \"L2TPV2CTL\", 9) ||\n+\t\t\t\t\t !rte_strncasecmp(name, \"L2TPV2\", 6) ||\n+\t\t\t\t\t !rte_strncasecmp(name, \"L2TPV3\", 6)) {\n \t\t\t\t\tptype_mapping[i].sw_ptype |=\n \t\t\t\t\t\tRTE_PTYPE_TUNNEL_L2TP;\n \t\t\t\t\tin_tunnel = true;\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex aae2ef9af..22fbcef7e 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -41,6 +41,10 @@\n #include \"mlx5_flow_os.h\"\n #include \"rte_pmd_mlx5.h\"\n \n+#ifdef RTE_EXEC_ENV_WINDOWS\n+#define close _close\n+#endif\n+\n /* Device parameter to enable RX completion queue compression. */\n #define MLX5_RXQ_CQE_COMP_EN \"rxq_cqe_comp_en\"\n \n", "prefixes": [ "v3", "6/7" ] }