Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88039/?format=api
{ "id": 88039, "url": "http://patches.dpdk.org/api/patches/88039/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210220232910.772-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210220232910.772-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210220232910.772-2-dmitry.kozliuk@gmail.com", "date": "2021-02-20T23:29:04", "name": "[1/7] eal: add wrappers for POSIX string functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fbf0962a4d2896ad9a10afd83c236ec60fdd0ec", "submitter": { "id": 1581, "url": "http://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210220232910.772-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 15317, "url": "http://patches.dpdk.org/api/series/15317/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15317", "date": "2021-02-20T23:29:03", "name": "eal/windows: do not expose POSIX symbols", "version": 1, "mbox": "http://patches.dpdk.org/series/15317/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88039/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 77232A0524;\n\tSun, 21 Feb 2021 00:29:28 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD4B322A249;\n\tSun, 21 Feb 2021 00:29:21 +0100 (CET)", "from mail-lj1-f177.google.com (mail-lj1-f177.google.com\n [209.85.208.177])\n by mails.dpdk.org (Postfix) with ESMTP id 3E3094013F\n for <dev@dpdk.org>; Sun, 21 Feb 2021 00:29:20 +0100 (CET)", "by mail-lj1-f177.google.com with SMTP id v6so44041287ljh.9\n for <dev@dpdk.org>; Sat, 20 Feb 2021 15:29:20 -0800 (PST)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id f5sm1462931ljc.8.2021.02.20.15.29.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 20 Feb 2021 15:29:19 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=3pMvwR89qcZTBE9RQzUAoHmCguIRyzM5f0bBUWwi8Xc=;\n b=Em4iYqV1LmkxGnA1XcTONyG4GktPiGjgTEDvn/T+P4U0kCSRCWw3qmpqYUlWOPFu5s\n oFYPtq0qPIgWSQmdnxjb2k8UFWMsDcAmQab/4y9MQYtqkWi+QXmDG71UVInzRQEnXTSP\n E1+RNVfITHLRpwbufW4EBbYfCK9evgmhMjsvBUIIy8nEGTjotEXtA0ZIXGZ1Rt54jCyV\n wzoKh8NeQ2ETzxOhiPx5f7LVg5n+megZ/qjSK+jsD1nm7/8Zulbm0LeeJcgwBnRULj0j\n 81Ux97BBlLqNrWt6PCXgEvn1Zy7F2ubOsB3mLidwzRt1oeaR1Xk6QmMcaOiHxCXugZ5d\n 8Uxg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=3pMvwR89qcZTBE9RQzUAoHmCguIRyzM5f0bBUWwi8Xc=;\n b=Mam9ji2w4s0E/C0mvyZNBtdUqZC/XEpoCB2kaL58nN8fdztmfhP1c6CqlRSGM+nBoJ\n f/WTvnk0nBp+6srBu1EI7YoNJh4ciM39VIQJtekCsj2z3MLAy/6fekypeiqcRUiayHN7\n ZzpeNrCVVvCqqUa4C9ofy/vxoZuDkmBhQInhdNzD8ay+Dgh1u2lxNTj6S6GQDV0LnGM/\n NEDYeOnPi744vthLlQddCKsucUD+EQK4MeeDQx5P6f8yJyAyysns06AWTFMy8HdHf1MY\n eNF4euGoRp0Nfn+xdrq6QaD/HVa0RnvZ9SBoVHCcaR9Zp/URbvwmtlztxyk55W5M4jYS\n Q4iQ==", "X-Gm-Message-State": "AOAM533N0EPh6Ww8/v90YGJTcwT8DFCxgLGaa1Fc4uYVICm+a9DbbTO2\n 5fYrVLpjQY5OrrPtFYLEjHrQAT3+LMpHUw==", "X-Google-Smtp-Source": "\n ABdhPJxgnEuLLWrMRbb9/m49v9rgIggkpxOnfifvesl7zvMW9WVlGY1R6xkRGVPjI7/6i76siG1B+w==", "X-Received": "by 2002:a05:6512:1148:: with SMTP id\n m8mr9469606lfg.64.1613863759582;\n Sat, 20 Feb 2021 15:29:19 -0800 (PST)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@microsoft.com>,\n Nick Connolly <nick.connolly@mayadata.io>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>", "Date": "Sun, 21 Feb 2021 02:29:04 +0300", "Message-Id": "<20210220232910.772-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210220232910.772-1-dmitry.kozliuk@gmail.com>", "References": "<20210220232910.772-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/7] eal: add wrappers for POSIX string functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "POSIX strncasecmp(), strdup(), and strtok_r() have different names\non Windows, respectively, strnicmp(), _strdup(), and strtok_s().\n\nAdd wrappers as inline functions, because they're used from librte_kvargs,\nand thus cannot be in librte_eal; besides, implementation is trivial.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/common/eal_common_dev.c | 6 +--\n lib/librte_eal/common/eal_common_devargs.c | 7 ++--\n lib/librte_eal/common/eal_common_log.c | 5 ++-\n lib/librte_eal/common/eal_common_options.c | 12 +++---\n lib/librte_eal/common/eal_common_trace_ctf.c | 2 +-\n .../common/eal_common_trace_utils.c | 2 +-\n lib/librte_eal/include/rte_string_fns.h | 42 +++++++++++++++++++\n 7 files changed, 60 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex 8a3bd3100..0a15fdcf7 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -462,7 +462,7 @@ rte_dev_event_callback_register(const char *device_name,\n \t\t\tif (!device_name) {\n \t\t\t\tevent_cb->dev_name = NULL;\n \t\t\t} else {\n-\t\t\t\tevent_cb->dev_name = strdup(device_name);\n+\t\t\t\tevent_cb->dev_name = rte_strdup(device_name);\n \t\t\t\tif (event_cb->dev_name == NULL) {\n \t\t\t\t\tret = -ENOMEM;\n \t\t\t\t\tgoto error;\n@@ -630,10 +630,10 @@ dev_str_sane_copy(const char *str)\n \n \tend = strcspn(str, \",/\");\n \tif (str[end] == ',') {\n-\t\tcopy = strdup(&str[end + 1]);\n+\t\tcopy = rte_strdup(&str[end + 1]);\n \t} else {\n \t\t/* '/' or '\\0' */\n-\t\tcopy = strdup(\"\");\n+\t\tcopy = rte_strdup(\"\");\n \t}\n \tif (copy == NULL) {\n \t\trte_errno = ENOMEM;\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex fcf3d9a3c..14e082a27 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -18,6 +18,7 @@\n #include <rte_errno.h>\n #include <rte_kvargs.h>\n #include <rte_log.h>\n+#include <rte_string_fns.h>\n #include <rte_tailq.h>\n #include \"eal_private.h\"\n \n@@ -75,7 +76,7 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,\n \t * anything and keep referring only to it.\n \t */\n \tif (devargs->data != devstr) {\n-\t\tdevargs->data = strdup(devstr);\n+\t\tdevargs->data = rte_strdup(devstr);\n \t\tif (devargs->data == NULL) {\n \t\t\tRTE_LOG(ERR, EAL, \"OOM\\n\");\n \t\t\tret = -ENOMEM;\n@@ -219,9 +220,9 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n \tda->bus = bus;\n \t/* Parse eventual device arguments */\n \tif (devname[i] == ',')\n-\t\tda->args = strdup(&devname[i + 1]);\n+\t\tda->args = rte_strdup(&devname[i + 1]);\n \telse\n-\t\tda->args = strdup(\"\");\n+\t\tda->args = rte_strdup(\"\");\n \tif (da->args == NULL) {\n \t\tRTE_LOG(ERR, EAL, \"not enough memory to parse arguments\\n\");\n \t\treturn -ENOMEM;\ndiff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex c5554badb..557a8243f 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -14,6 +14,7 @@\n #include <rte_eal.h>\n #include <rte_log.h>\n #include <rte_per_lcore.h>\n+#include <rte_string_fns.h>\n \n #include \"eal_private.h\"\n \n@@ -194,7 +195,7 @@ static int rte_log_save_level(int priority,\n \t\tif (regcomp(&opt_ll->re_match, regex, 0) != 0)\n \t\t\tgoto fail;\n \t} else if (pattern) {\n-\t\topt_ll->pattern = strdup(pattern);\n+\t\topt_ll->pattern = rte_strdup(pattern);\n \t\tif (opt_ll->pattern == NULL)\n \t\t\tgoto fail;\n \t} else\n@@ -270,7 +271,7 @@ rte_log_lookup(const char *name)\n static int\n __rte_log_register(const char *name, int id)\n {\n-\tchar *dup_name = strdup(name);\n+\tchar *dup_name = rte_strdup(name);\n \n \tif (dup_name == NULL)\n \t\treturn -ENOMEM;\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 622c7bc42..3612ad441 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -228,7 +228,7 @@ eal_save_args(int argc, char **argv)\n \t\treturn -1;\n \n \tfor (i = 0; i < argc; i++) {\n-\t\teal_args[i] = strdup(argv[i]);\n+\t\teal_args[i] = rte_strdup(argv[i]);\n \t\tif (strcmp(argv[i], \"--\") == 0)\n \t\t\tbreak;\n \t}\n@@ -243,7 +243,7 @@ eal_save_args(int argc, char **argv)\n \t\treturn -1;\n \n \tfor (j = 0; i < argc; j++, i++)\n-\t\teal_app_args[j] = strdup(argv[i]);\n+\t\teal_app_args[j] = rte_strdup(argv[i]);\n \teal_app_args[j] = NULL;\n \n \treturn 0;\n@@ -1273,7 +1273,7 @@ eal_parse_log_level(const char *arg)\n \tchar *str, *level;\n \tint priority;\n \n-\tstr = strdup(arg);\n+\tstr = rte_strdup(arg);\n \tif (str == NULL)\n \t\treturn -1;\n \n@@ -1324,11 +1324,11 @@ eal_parse_log_level(const char *arg)\n static enum rte_proc_type_t\n eal_parse_proc_type(const char *arg)\n {\n-\tif (strncasecmp(arg, \"primary\", sizeof(\"primary\")) == 0)\n+\tif (rte_strncasecmp(arg, \"primary\", sizeof(\"primary\")) == 0)\n \t\treturn RTE_PROC_PRIMARY;\n-\tif (strncasecmp(arg, \"secondary\", sizeof(\"secondary\")) == 0)\n+\tif (rte_strncasecmp(arg, \"secondary\", sizeof(\"secondary\")) == 0)\n \t\treturn RTE_PROC_SECONDARY;\n-\tif (strncasecmp(arg, \"auto\", sizeof(\"auto\")) == 0)\n+\tif (rte_strncasecmp(arg, \"auto\", sizeof(\"auto\")) == 0)\n \t\treturn RTE_PROC_AUTO;\n \n \treturn RTE_PROC_INVALID;\ndiff --git a/lib/librte_eal/common/eal_common_trace_ctf.c b/lib/librte_eal/common/eal_common_trace_ctf.c\nindex 33e419aac..4041d9af6 100644\n--- a/lib/librte_eal/common/eal_common_trace_ctf.c\n+++ b/lib/librte_eal/common/eal_common_trace_ctf.c\n@@ -398,7 +398,7 @@ char *trace_metadata_fixup_field(const char *field)\n \tif (strstr(field, \".\") == NULL && strstr(field, \"->\") == NULL)\n \t\treturn NULL;\n \n-\tout = strdup(field);\n+\tout = rte_strdup(field);\n \tif (out == NULL)\n \t\treturn NULL;\n \tp = out;\ndiff --git a/lib/librte_eal/common/eal_common_trace_utils.c b/lib/librte_eal/common/eal_common_trace_utils.c\nindex 64f58fb66..d541a5ea9 100644\n--- a/lib/librte_eal/common/eal_common_trace_utils.c\n+++ b/lib/librte_eal/common/eal_common_trace_utils.c\n@@ -145,7 +145,7 @@ eal_trace_args_save(const char *val)\n \t\treturn -ENOMEM;\n \t}\n \n-\targ->val = strdup(val);\n+\targ->val = rte_strdup(val);\n \tif (arg->val == NULL) {\n \t\ttrace_err(\"failed to allocate memory for %s\", val);\n \t\tfree(arg);\ndiff --git a/lib/librte_eal/include/rte_string_fns.h b/lib/librte_eal/include/rte_string_fns.h\nindex 8bac8243c..2d9d5afc8 100644\n--- a/lib/librte_eal/include/rte_string_fns.h\n+++ b/lib/librte_eal/include/rte_string_fns.h\n@@ -116,6 +116,48 @@ rte_strlcat(char *dst, const char *src, size_t size)\n ssize_t\n rte_strscpy(char *dst, const char *src, size_t dsize);\n \n+/**\n+ * @internal\n+ * strncasecmp(3) replacement for systems that don't have it.\n+ */\n+static inline int\n+rte_strncasecmp(const char *s1, const char *s2, size_t size)\n+{\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+\treturn _strnicmp(s1, s2, size);\n+#else\n+\treturn strncasecmp(s1, s2, size);\n+#endif\n+}\n+\n+/**\n+ * @internal\n+ * strtor_r(3) replacement for systems that don't have it.\n+ */\n+static inline char *\n+rte_strtok(char *str, const char *delim, char **saveptr)\n+{\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+\treturn strtok_s(str, delim, saveptr);\n+#else\n+\treturn strtok_r(str, delim, saveptr);\n+#endif\n+}\n+\n+/**\n+ * @internal\n+ * strdup(3) replacement for systems that don't have it.\n+ */\n+static inline char *\n+rte_strdup(const char *str)\n+{\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+\treturn _strdup(str);\n+#else\n+\treturn strdup(str);\n+#endif\n+}\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "1/7" ] }