Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/88002/?format=api
{ "id": 88002, "url": "http://patches.dpdk.org/api/patches/88002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210219085407.97265-1-dapengx.yu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210219085407.97265-1-dapengx.yu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210219085407.97265-1-dapengx.yu@intel.com", "date": "2021-02-19T08:54:07", "name": "net/igc: remove MTU setting limitation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "37e839aa2c954d4556947f0c92f89161d9d7ec30", "submitter": { "id": 2042, "url": "http://patches.dpdk.org/api/people/2042/?format=api", "name": "Yu, DapengX", "email": "dapengx.yu@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210219085407.97265-1-dapengx.yu@intel.com/mbox/", "series": [ { "id": 15299, "url": "http://patches.dpdk.org/api/series/15299/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15299", "date": "2021-02-19T08:54:07", "name": "net/igc: remove MTU setting limitation", "version": 1, "mbox": "http://patches.dpdk.org/series/15299/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/88002/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/88002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2D5FA054A;\n\tFri, 19 Feb 2021 09:54:31 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C31A540395;\n\tFri, 19 Feb 2021 09:54:31 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 837CF40042;\n Fri, 19 Feb 2021 09:54:30 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2021 00:54:26 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.93])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Feb 2021 00:54:24 -0800" ], "IronPort-SDR": [ "\n Gzctz8TZcxl8pbx/PawI4+DkQ0xTyt9/eJvtAhK5UCSxQ/r2JpDrlrI7WpTjrUkqNxqBdATP0g\n cyrlqeoRQ86Q==", "\n 7N4YbI5IE/xQtbEpiZelFMmQiAKzXnqgmB7l5k4QQ5ZRdMhv6/Yri8H8LEPDlbCb/alLzSGUUa\n CLV72O29oPIg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9899\"; a=\"183905598\"", "E=Sophos;i=\"5.81,189,1610438400\"; d=\"scan'208\";a=\"183905598\"", "E=Sophos;i=\"5.81,189,1610438400\"; d=\"scan'208\";a=\"440184978\"" ], "From": "dapengx.yu@intel.com", "To": "=?unknown-8bit?b?ImppYS5ndW9AaW50ZWwuY29t77ybaGFpeXVlLndhbmciQGludGVs?=\n\t=?unknown-8bit?b?LmNvbQ==?=", "Cc": "dev@dpdk.org,\n\tDapeng Yu <dapengx.yu@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 19 Feb 2021 16:54:07 +0800", "Message-Id": "<20210219085407.97265-1-dapengx.yu@intel.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/igc: remove MTU setting limitation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dapeng Yu <dapengx.yu@intel.com>\n\nCurrently, if requested MTU is bigger than mbuf size and scattered\nreceive is not enabled, setting MTU to that value fails.\n\nThis patch allows setting this special MTU when device is stopped,\nbecause scattered_rx will be re-configured during next port start\nand driver may enable scattered receive according new MTU value.\n\nAfter this patch, driver may select different receive function\nautomatically after MTU set, according MTU values selected.\n\nFixes: a5aeb2b9e225 (\"net/igc: support Rx and Tx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dapeng Yu <dapengx.yu@intel.com>\n---\n drivers/net/igc/igc_ethdev.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c\nindex dbaa7a83e..0ea6e2a04 100644\n--- a/drivers/net/igc/igc_ethdev.c\n+++ b/drivers/net/igc/igc_ethdev.c\n@@ -1590,12 +1590,14 @@ eth_igc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\treturn -EINVAL;\n \n \t/*\n-\t * refuse mtu that requires the support of scattered packets when\n-\t * this feature has not been enabled before.\n+\t * If device is started, refuse mtu that requires the support of\n+\t * scattered packets when this feature has not been enabled before.\n \t */\n-\tif (!dev->data->scattered_rx &&\n-\t frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)\n+\tif (dev->data->dev_started && !dev->data->scattered_rx &&\n+\t frame_size > dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) {\n+\t\tPMD_INIT_LOG(ERR, \"Stop port first.\");\n \t\treturn -EINVAL;\n+\t}\n \n \trctl = IGC_READ_REG(hw, IGC_RCTL);\n \n", "prefixes": [] }