Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87999/?format=api
{ "id": 87999, "url": "http://patches.dpdk.org/api/patches/87999/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210219051346.12992-1-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210219051346.12992-1-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210219051346.12992-1-alvinx.zhang@intel.com", "date": "2021-02-19T05:13:46", "name": "net/ice: fix VLAN filter with PF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "36a0dc026a656ddec09e7119c1cdef0998fe6f1c", "submitter": { "id": 1398, "url": "http://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210219051346.12992-1-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 15296, "url": "http://patches.dpdk.org/api/series/15296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15296", "date": "2021-02-19T05:13:46", "name": "net/ice: fix VLAN filter with PF", "version": 1, "mbox": "http://patches.dpdk.org/series/15296/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87999/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/87999/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 00448A054A;\n\tFri, 19 Feb 2021 06:14:03 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 78BE740395;\n\tFri, 19 Feb 2021 06:14:03 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 1AFDB40042;\n Fri, 19 Feb 2021 06:14:01 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Feb 2021 21:14:00 -0800", "from unknown (HELO shwdeNPG235.ccr.corp.intel.com) ([10.240.182.60])\n by fmsmga002-auth.fm.intel.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2021 21:13:59 -0800" ], "IronPort-SDR": [ "\n sge+UPDbdY9HJ/GM5ejZzKEf6DNxgW3QcRxIqTWyem6jsCTWFrd7rRVu1Tv4hScPMEEHt0fGw2\n 4zTuA633raOA==", "\n nvapKULVIvtIlrdYnwTbWSCV3Y1GLSJKeXEBO69fBFiUF4A8Rb51jERs4kvCVSjzwkl01KBo65\n 0W+fiEAzZkoA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9899\"; a=\"180229042\"", "E=Sophos;i=\"5.81,189,1610438400\"; d=\"scan'208\";a=\"180229042\"", "E=Sophos;i=\"5.81,189,1610438400\"; d=\"scan'208\";a=\"428629217\"" ], "From": "Alvin Zhang <alvinx.zhang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 19 Feb 2021 13:13:46 +0800", "Message-Id": "<20210219051346.12992-1-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210219050736.12632-1-alvinx.zhang@intel.com>", "References": "<20210219050736.12632-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The macro flag DEV_RX_OFFLOAD_VLAN_FILTER is used to enable/disable\nRx VLAN filter, but not Tx VLAN filter. Therefore, Tx VLAN filter\nshould not be enabled/disabled in function ice_vsi_config_vlan_filter\ncalled after checking DEV_RX_OFFLOAD_VLAN_FILTER flag.\n\nIn addition, the kernel driver doesn't enable/disable the TX VLAN\nfilter in the similar function ice_cfg_vlan_pruning.\n\nThis patch removes the setting about the TX VLAN filter in function\nice_vsi_config_vlan_filter.\n\nFixes: e0dcf94a0d7f (\"net/ice: support VLAN ops\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex dfd99ac..8999d44 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -4011,20 +4011,16 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n {\n \tstruct ice_hw *hw = ICE_VSI_TO_HW(vsi);\n \tstruct ice_vsi_ctx ctxt;\n-\tuint8_t sec_flags, sw_flags2;\n+\tuint8_t sw_flags2;\n \tint ret = 0;\n \n-\tsec_flags = ICE_AQ_VSI_SEC_TX_VLAN_PRUNE_ENA <<\n-\t\t ICE_AQ_VSI_SEC_TX_PRUNE_ENA_S;\n \tsw_flags2 = ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA;\n \n-\tif (on) {\n-\t\tvsi->info.sec_flags |= sec_flags;\n+\tif (on)\n \t\tvsi->info.sw_flags2 |= sw_flags2;\n-\t} else {\n-\t\tvsi->info.sec_flags &= ~sec_flags;\n+\telse\n \t\tvsi->info.sw_flags2 &= ~sw_flags2;\n-\t}\n+\n \tvsi->info.sw_id = hw->port_info->sw_id;\n \t(void)rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info));\n \tctxt.info.valid_sections =\n", "prefixes": [] }