Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87973/?format=api
http://patches.dpdk.org/api/patches/87973/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210218114058.13248-1-talshn@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210218114058.13248-1-talshn@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210218114058.13248-1-talshn@nvidia.com", "date": "2021-02-18T11:40:58", "name": "eal/windows: fix default thread priority", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "725849778581bf2bc33477e34f675a0f4a4f0f48", "submitter": { "id": 1893, "url": "http://patches.dpdk.org/api/people/1893/?format=api", "name": "Tal Shnaiderman", "email": "talshn@nvidia.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210218114058.13248-1-talshn@nvidia.com/mbox/", "series": [ { "id": 15282, "url": "http://patches.dpdk.org/api/series/15282/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15282", "date": "2021-02-18T11:40:58", "name": "eal/windows: fix default thread priority", "version": 1, "mbox": "http://patches.dpdk.org/series/15282/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87973/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/87973/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 575DDA054D;\n\tThu, 18 Feb 2021 12:41:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CADA716071C;\n\tThu, 18 Feb 2021 12:41:38 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by mails.dpdk.org (Postfix) with ESMTP id DC373160712\n for <dev@dpdk.org>; Thu, 18 Feb 2021 12:41:37 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n talshn@nvidia.com) with SMTP; 18 Feb 2021 13:41:35 +0200", "from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 11IBfZRT013564;\n Thu, 18 Feb 2021 13:41:35 +0200" ], "From": "Tal Shnaiderman <talshn@nvidia.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com,\n navasile@linux.microsoft.com, dmitrym@microsoft.com,\n david.marchand@redhat.com, stable@dpdk.org", "Date": "Thu, 18 Feb 2021 13:40:58 +0200", "Message-Id": "<20210218114058.13248-1-talshn@nvidia.com>", "X-Mailer": "git-send-email 2.16.1.windows.4", "Subject": "[dpdk-dev] [PATCH] eal/windows: fix default thread priority", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The hard-coded thread priority for Windows threads in eal\nis REALTIME_PRIORITY_CLASS/THREAD_PRIORITY_TIME_CRITICAL.\n\nThis results in issues with DPDK threads causing OS thread starvation\nand eventually a bugcheck.\n\nThe fix reduce the thread priority to\nNORMAL_PRIORITY_CLASS/THREAD_PRIORITY_NORMAL.\n\nBugzilla ID: 600\nFixes: 53ffd9f080f (\"eal/windows: add minimum viable code\")\nCc: stable@dpdk.org\n\nReported-by: Odi Assli <odia@nvidia.com>\nSigned-off-by: Tal Shnaiderman <talshn@nvidia.com>\n---\n lib/librte_eal/windows/eal_thread.c | 4 ++--\n lib/librte_eal/windows/include/pthread.h | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_eal/windows/eal_thread.c b/lib/librte_eal/windows/eal_thread.c\nindex 908e726d16..9c3f6d69fd 100644\n--- a/lib/librte_eal/windows/eal_thread.c\n+++ b/lib/librte_eal/windows/eal_thread.c\n@@ -134,8 +134,8 @@ eal_thread_create(pthread_t *thread)\n \tif (!th)\n \t\treturn -1;\n \n-\tSetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS);\n-\tSetThreadPriority(th, THREAD_PRIORITY_TIME_CRITICAL);\n+\tSetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS);\n+\tSetThreadPriority(th, THREAD_PRIORITY_NORMAL);\n \n \treturn 0;\n }\ndiff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h\nindex fb11a07ce6..9aeab1fa70 100644\n--- a/lib/librte_eal/windows/include/pthread.h\n+++ b/lib/librte_eal/windows/include/pthread.h\n@@ -137,8 +137,8 @@ pthread_create(void *threadid, const void *threadattr, void *threadfunc,\n \thThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc,\n \t\targs, 0, (LPDWORD)threadid);\n \tif (hThread) {\n-\t\tSetPriorityClass(GetCurrentProcess(), REALTIME_PRIORITY_CLASS);\n-\t\tSetThreadPriority(hThread, THREAD_PRIORITY_TIME_CRITICAL);\n+\t\tSetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS);\n+\t\tSetThreadPriority(hThread, THREAD_PRIORITY_NORMAL);\n \t}\n \treturn ((hThread != NULL) ? 0 : E_FAIL);\n }\n", "prefixes": [] }{ "id": 87973, "url": "