Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87966/?format=api
{ "id": 87966, "url": "http://patches.dpdk.org/api/patches/87966/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210218030610.1277810-1-xiaoyun.li@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210218030610.1277810-1-xiaoyun.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210218030610.1277810-1-xiaoyun.li@intel.com", "date": "2021-02-18T03:06:10", "name": "app/testpmd: remove unnecessary tunnel UDP cmd check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b33331f22ddf77f9f525a95c1700c95cfa62e670", "submitter": { "id": 798, "url": "http://patches.dpdk.org/api/people/798/?format=api", "name": "Li, Xiaoyun", "email": "xiaoyun.li@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210218030610.1277810-1-xiaoyun.li@intel.com/mbox/", "series": [ { "id": 15278, "url": "http://patches.dpdk.org/api/series/15278/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15278", "date": "2021-02-18T03:06:10", "name": "app/testpmd: remove unnecessary tunnel UDP cmd check", "version": 1, "mbox": "http://patches.dpdk.org/series/15278/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87966/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/87966/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD8CEA054D;\n\tThu, 18 Feb 2021 04:08:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 22F8D40698;\n\tThu, 18 Feb 2021 04:08:57 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id C5CF840697;\n Thu, 18 Feb 2021 04:08:54 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Feb 2021 19:08:53 -0800", "from dpdk-xiaoyunl.sh.intel.com ([10.67.111.154])\n by fmsmga008.fm.intel.com with ESMTP; 17 Feb 2021 19:08:51 -0800" ], "IronPort-SDR": [ "\n 9GHLqRkniytmf0ERQzBA8PovQ7owU0jXtqbo5V+ty2dKu0OgSp8hWVWMhESf+2QfJoNNYOsUa6\n CNXVd7nyV8cQ==", "\n JRnzsF+8zt0/VNigjqb3f7Ua8cBslYJwsGQtL5OEVhfCpsvf39wZqwTtbh0x8jSy9YzBFPhpUX\n un0k7cPmguFQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9898\"; a=\"170519843\"", "E=Sophos;i=\"5.81,185,1610438400\"; d=\"scan'208\";a=\"170519843\"", "E=Sophos;i=\"5.81,185,1610438400\"; d=\"scan'208\";a=\"385544317\"" ], "X-ExtLoop1": "1", "From": "Xiaoyun Li <xiaoyun.li@intel.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tXiaoyun Li <xiaoyun.li@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 18 Feb 2021 11:06:10 +0800", "Message-Id": "<20210218030610.1277810-1-xiaoyun.li@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] app/testpmd: remove unnecessary tunnel UDP cmd\n check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "cmd_tunnel_udp_config checked 'cmd' to set prot_type but this cmd is\nonly for rx_vxlan_port. The unnecessary cmd check will cause uninit\ncoverity issue. So remove it and rename 'cmd' to 'rx_vxlan_port'.\n\nCoverity issue: 366155\nFixes: bd948f20d609 (\"app/testpmd: VXLAN packet identification\")\nCc: stable@dpdk.org\n\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\n app/test-pmd/cmdline.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 59722d268b..d77958b783 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -9098,7 +9098,7 @@ cmdline_parse_inst_t cmd_vf_rate_limit = {\n \n /* *** CONFIGURE TUNNEL UDP PORT *** */\n struct cmd_tunnel_udp_config {\n-\tcmdline_fixed_string_t cmd;\n+\tcmdline_fixed_string_t rx_vxlan_port;\n \tcmdline_fixed_string_t what;\n \tuint16_t udp_port;\n \tportid_t port_id;\n@@ -9114,9 +9114,7 @@ cmd_tunnel_udp_config_parsed(void *parsed_result,\n \tint ret;\n \n \ttunnel_udp.udp_port = res->udp_port;\n-\n-\tif (!strcmp(res->cmd, \"rx_vxlan_port\"))\n-\t\ttunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN;\n+\ttunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN;\n \n \tif (!strcmp(res->what, \"add\"))\n \t\tret = rte_eth_dev_udp_tunnel_port_add(res->port_id,\n@@ -9129,9 +9127,9 @@ cmd_tunnel_udp_config_parsed(void *parsed_result,\n \t\tprintf(\"udp tunneling add error: (%s)\\n\", strerror(-ret));\n }\n \n-cmdline_parse_token_string_t cmd_tunnel_udp_config_cmd =\n+cmdline_parse_token_string_t cmd_tunnel_udp_config_rx_vxlan_port =\n \tTOKEN_STRING_INITIALIZER(struct cmd_tunnel_udp_config,\n-\t\t\t\tcmd, \"rx_vxlan_port\");\n+\t\t\t\trx_vxlan_port, \"rx_vxlan_port\");\n cmdline_parse_token_string_t cmd_tunnel_udp_config_what =\n \tTOKEN_STRING_INITIALIZER(struct cmd_tunnel_udp_config,\n \t\t\t\twhat, \"add#rm\");\n@@ -9148,7 +9146,7 @@ cmdline_parse_inst_t cmd_tunnel_udp_config = {\n \t.help_str = \"rx_vxlan_port add|rm <udp_port> <port_id>: \"\n \t\t\"Add/Remove a tunneling UDP port filter\",\n \t.tokens = {\n-\t\t(void *)&cmd_tunnel_udp_config_cmd,\n+\t\t(void *)&cmd_tunnel_udp_config_rx_vxlan_port,\n \t\t(void *)&cmd_tunnel_udp_config_what,\n \t\t(void *)&cmd_tunnel_udp_config_udp_port,\n \t\t(void *)&cmd_tunnel_udp_config_port_id,\n", "prefixes": [] }