Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87954/?format=api
{ "id": 87954, "url": "http://patches.dpdk.org/api/patches/87954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-16-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210216203540.29290-16-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210216203540.29290-16-aboyer@pensando.io", "date": "2021-02-16T20:35:40", "name": "[v2,15/15] net/ionic: fix code around lif init devcmd", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bd22dc6aea42487013ba81cc45668ebc2c8ed039", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-16-aboyer@pensando.io/mbox/", "series": [ { "id": 15272, "url": "http://patches.dpdk.org/api/series/15272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15272", "date": "2021-02-16T20:35:25", "name": "net/ionic: struct optimizations, fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/15272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87954/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/87954/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6EF5BA054D;\n\tTue, 16 Feb 2021 21:37:31 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16A0E160815;\n\tTue, 16 Feb 2021 21:36:19 +0100 (CET)", "from mail-pj1-f52.google.com (mail-pj1-f52.google.com\n [209.85.216.52])\n by mails.dpdk.org (Postfix) with ESMTP id E4EA71607F9\n for <dev@dpdk.org>; Tue, 16 Feb 2021 21:36:15 +0100 (CET)", "by mail-pj1-f52.google.com with SMTP id c19so31868pjq.3\n for <dev@dpdk.org>; Tue, 16 Feb 2021 12:36:15 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id u17sm11371pgh.72.2021.02.16.12.36.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 16 Feb 2021 12:36:14 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=;\n b=aE3oMumXyHy7qszISNuL/ClRMoCBEI2R+95HVZJmlqDuOznyaaTKX2oK33qnd6mFxJ\n XZ3RJny7M2QGPr1VFDwI6LglfPJA4K+831QP+2l6mD7ZG1bMsvPWLAXWEI/Bj5gLoPXb\n FVSGKLvbVrLJZHnC0XhcFzTlsTWnl7gL90xkC/tGDTkvD5hn2pG6p9zLQH0EiLOtJ6vY\n fmghj6nUTkQNlydVgFcwx3NARohf0/A3h6TfJkKmK8LdoNcmpY7QKqqqswdWGX29Tqjd\n lCoX7JTn9MQg6aaB1Sp+NKZ3a55rquZ+i7hfUSa+DL3epP/puG0hXQ7buocHs4z11pbo\n rpCw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=;\n b=uC3g9Krns2OmkSajqu2s3aKjOdCKeQFdLNTC6OsiP0Ctmz/AGwQateF3hzCnKRPzrl\n 2wM0KCE3Nh2WOTrTE39vi864EbWgSLJ4QhPMyh1QS0UbcKSfCpcIgsa/Wy0xp4CD+qh1\n u/PtRwWbEE0iUX26GZynkq53a9cGl411xdzg7h+8D9c9WpMZIoKgyetJJgVerOsBudXI\n hR8w7o+z/o3iQ1ZbZu1lq3RSh0sYXBtKQDAJoWhOSP//AHCIOFuHneU1wBH91Ic9MRLv\n yt2wRGGmKg50dZBSSCXhX8InolwrwB2NK04j2+cN9vWbdxCZaO2By/psegkfY+ia8phL\n Ctrg==", "X-Gm-Message-State": "AOAM531BR6eHMWpsZRraej/TEIt11n87SQkpF6RufzWcGGYX1AvIsc5I\n zXo4P1iMTaT7IQZsQCZ2GEtNavboRZ0xhg==", "X-Google-Smtp-Source": "\n ABdhPJwWDxRlrsW0HwdWPFMgDDeMb6KpgEJdhiXUJ7C/QZdKT7meUQegX8zBYBw1Xy3n3pwJCnanNA==", "X-Received": "by 2002:a17:90a:c684:: with SMTP id\n n4mr5993244pjt.13.1613507775006;\n Tue, 16 Feb 2021 12:36:15 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>, stable@dpdk.org", "Date": "Tue, 16 Feb 2021 12:35:40 -0800", "Message-Id": "<20210216203540.29290-16-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "References": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v2 15/15] net/ionic: fix code around lif init\n devcmd", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The completion type was wrong.\nDon't check the completion if the wait timed out.\n\nFixes: 669c8de67c88 (\"net/ionic: support basic LIF\")\nCc: cardigliano@ntop.org\nCc: stable@dpdk.org\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex b8023e0632..cd220abee2 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -1605,17 +1605,18 @@ int\n ionic_lif_init(struct ionic_lif *lif)\n {\n \tstruct ionic_dev *idev = &lif->adapter->idev;\n-\tstruct ionic_q_init_comp comp;\n+\tstruct ionic_lif_init_comp comp;\n \tint err;\n \n \tmemset(&lif->stats_base, 0, sizeof(lif->stats_base));\n \n \tionic_dev_cmd_lif_init(idev, lif->info_pa);\n \terr = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);\n-\tionic_dev_cmd_comp(idev, &comp);\n \tif (err)\n \t\treturn err;\n \n+\tionic_dev_cmd_comp(idev, &comp);\n+\n \tlif->hw_index = rte_cpu_to_le_16(comp.hw_index);\n \n \terr = ionic_lif_adminq_init(lif);\n", "prefixes": [ "v2", "15/15" ] }