Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87953/?format=api
{ "id": 87953, "url": "http://patches.dpdk.org/api/patches/87953/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-15-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210216203540.29290-15-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210216203540.29290-15-aboyer@pensando.io", "date": "2021-02-16T20:35:39", "name": "[v2,14/15] net/ionic: store Tx fragment limit in queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7423d1a9a3e279001dd118df442189a0602fa062", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-15-aboyer@pensando.io/mbox/", "series": [ { "id": 15272, "url": "http://patches.dpdk.org/api/series/15272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15272", "date": "2021-02-16T20:35:25", "name": "net/ionic: struct optimizations, fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/15272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87953/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87953/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8D516A054D;\n\tTue, 16 Feb 2021 21:37:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E9A4160800;\n\tTue, 16 Feb 2021 21:36:17 +0100 (CET)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51])\n by mails.dpdk.org (Postfix) with ESMTP id BB2441607C4\n for <dev@dpdk.org>; Tue, 16 Feb 2021 21:36:13 +0100 (CET)", "by mail-pj1-f51.google.com with SMTP id l18so33984pji.3\n for <dev@dpdk.org>; Tue, 16 Feb 2021 12:36:13 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id u17sm11371pgh.72.2021.02.16.12.36.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 16 Feb 2021 12:36:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=QeNNymWUPKDtzMw83UcjDh/XmwFbM156RAu7l4XrryE=;\n b=BhYE/3VdbuUEvs2WDe3PCx/E4TaNHmaG/5c4xfRBYeHgqRFPFK5YW3AESgH5WdOYOg\n GeJmXEdeOnnY+Bv1V1q4hn9QTHjRfZzBfoBIaOt5Cyz5DsfVIEd2Cd0+ZGeTXCi9Wnag\n AR4cEnC3lk1pRlkxUW3oH0W0m845q8Jyu3LLfwM/3gadfdEY3HT0UnCxiPASp8Iozs7S\n mXFgpYeB4dHZUE1HgqQwK7NoHzT0fq83/K7FG1otnYxTDoQ/zaA70eV7fsz6iCmRM+Fn\n LG86btgsZIcOf+VRcew9dUzkCnSVG5INo8lU+Qq04kdil1sQRu7Gw3saFzLpw3S0Kg9+\n p47Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=QeNNymWUPKDtzMw83UcjDh/XmwFbM156RAu7l4XrryE=;\n b=KZ0dd5nbnIQIkqOQHe86zTf9ZdYSPoZHNvN9eOQwZSU3LkM0pLq/JFFFw7tzjdFpY6\n 7n1Mttl1vTzeHPlCy7bqD3dHLnYwUU821TB62Oxta9PgMpPLLbrwmyGr4xWUTPhCwo4z\n +wHSV9tPSrgBMC8Dp8GwafZEkkyac4L96Gbj5IyL8m3Pe8Hyh5feEpv0H3IdIjtFVYk/\n o65PAiUhJPkEu1VyfO7Z/2DNTtzV3M4RVfqiIWuLyG5B6oxbbDivvQ6HCrHyeaItC5fp\n ZyADssh6SiX4YkqwjMwodn+97fnYZxA8VAmS0AgWtFslZWDi4koGn3jOrvVgqu4CINCu\n ZSGg==", "X-Gm-Message-State": "AOAM533hko2IbP670PQ9LzFyeW5fRO696aL308++ZT0qZ8I3mj1YUG0m\n qQUnJqrPPHXOS7tMLatNaT6OqYsFoAwVqw==", "X-Google-Smtp-Source": "\n ABdhPJz2VPDm2scQcwEUy+RbQ09pi2shh1BVsYDj20kTgtr0dMYo9Cn7hZPe1SdpvE2sr4Le7L+z9Q==", "X-Received": "by 2002:a17:90b:198c:: with SMTP id\n mv12mr5812411pjb.25.1613507772801;\n Tue, 16 Feb 2021 12:36:12 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Tue, 16 Feb 2021 12:35:39 -0800", "Message-Id": "<20210216203540.29290-15-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "References": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v2 14/15] net/ionic: store Tx fragment limit in\n queue", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A future patch will allow Tx scatter/gather to be disabled. Store the value\nin the queue so it can be changed at runtime based on the configuration.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.c | 6 +++++-\n drivers/net/ionic/ionic_lif.h | 1 +\n drivers/net/ionic/ionic_rxtx.c | 6 +++---\n 3 files changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex dd79068948..b8023e0632 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -757,10 +757,13 @@ ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,\n \t\tuint16_t ntxq_descs, struct ionic_tx_qcq **txq_out)\n {\n \tstruct ionic_tx_qcq *txq;\n-\tuint16_t flags;\n+\tuint16_t flags, num_segs_fw;\n \tint err;\n \n \tflags = IONIC_QCQ_F_SG;\n+\n+\tnum_segs_fw = IONIC_TX_MAX_SG_ELEMS_V1 + 1;\n+\n \terr = ionic_qcq_alloc(lif,\n \t\tIONIC_QTYPE_TXQ,\n \t\tsizeof(struct ionic_tx_qcq),\n@@ -777,6 +780,7 @@ ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,\n \t\treturn err;\n \n \ttxq->flags = flags;\n+\ttxq->num_segs_fw = num_segs_fw;\n \n \tlif->txqcqs[index] = txq;\n \t*txq_out = txq;\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex 5885aa1546..9f00ba2973 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -92,6 +92,7 @@ struct ionic_tx_qcq {\n \tstruct ionic_qcq qcq;\n \n \t/* cacheline2 */\n+\tuint16_t num_segs_fw;\t/* # segs supported by current FW */\n \tuint16_t flags;\n \n \tstruct ionic_tx_stats stats;\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex b4bdeabad1..b83ea1bcaa 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -598,9 +598,9 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t(PKT_TX_OFFLOAD_MASK ^ IONIC_TX_OFFLOAD_MASK)\n \n uint16_t\n-ionic_prep_pkts(void *tx_queue __rte_unused, struct rte_mbuf **tx_pkts,\n-\t\tuint16_t nb_pkts)\n+ionic_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n {\n+\tstruct ionic_tx_qcq *txq = tx_queue;\n \tstruct rte_mbuf *txm;\n \tuint64_t offloads;\n \tint i = 0;\n@@ -608,7 +608,7 @@ ionic_prep_pkts(void *tx_queue __rte_unused, struct rte_mbuf **tx_pkts,\n \tfor (i = 0; i < nb_pkts; i++) {\n \t\ttxm = tx_pkts[i];\n \n-\t\tif (txm->nb_segs > IONIC_TX_MAX_SG_ELEMS_V1 + 1) {\n+\t\tif (txm->nb_segs > txq->num_segs_fw) {\n \t\t\trte_errno = -EINVAL;\n \t\t\tbreak;\n \t\t}\n", "prefixes": [ "v2", "14/15" ] }