Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87949/?format=api
{ "id": 87949, "url": "http://patches.dpdk.org/api/patches/87949/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-11-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210216203540.29290-11-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210216203540.29290-11-aboyer@pensando.io", "date": "2021-02-16T20:35:35", "name": "[v2,10/15] net/ionic: log queue counters when tearing down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "372149f5cd2a2b2dbe1f8d38c7e3d464381d35a6", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210216203540.29290-11-aboyer@pensando.io/mbox/", "series": [ { "id": 15272, "url": "http://patches.dpdk.org/api/series/15272/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15272", "date": "2021-02-16T20:35:25", "name": "net/ionic: struct optimizations, fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/15272/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87949/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87949/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 06A63A054D;\n\tTue, 16 Feb 2021 21:36:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1171F1607E5;\n\tTue, 16 Feb 2021 21:36:10 +0100 (CET)", "from mail-pl1-f178.google.com (mail-pl1-f178.google.com\n [209.85.214.178])\n by mails.dpdk.org (Postfix) with ESMTP id 0A8C41607D1\n for <dev@dpdk.org>; Tue, 16 Feb 2021 21:36:07 +0100 (CET)", "by mail-pl1-f178.google.com with SMTP id u11so6115797plg.13\n for <dev@dpdk.org>; Tue, 16 Feb 2021 12:36:06 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id u17sm11371pgh.72.2021.02.16.12.36.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 16 Feb 2021 12:36:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :in-reply-to:references;\n bh=3Wo47tI1VUFWCXaudhypvJgBtWXPyxvPP/YWpBZyf0o=;\n b=Lkxm24yGPFvIs9WCAfeE+rT2hZCKJECIqu8uqcI9pEQsqy3D1RCsujdpohkK4aZFHE\n XC5A0gLsagrPbVAFKM7HPJlJ9Wm2chpdN6Rp1kimbUu73i3r6MfDsOP7dpCCKRDlDm7Y\n i6sWGC1KAmsDthVPQJkUBvOUd6Rs9U+QUV/Y/O8IHC1gNSbdLh/oaz//M6VH40kk4JlX\n MscSDIXV+5p9O2S6+sjlw7F4q2wzciku2e1Qnx6kdHBb4R6YNzvTgG2G3IQddEmBYg1l\n HJSCd/bVPb83aerDbzxxoXf1fQiKuKCfxOyxtRF6sUC/fqLkhh8T6qtui+abJ2hq8OIB\n C+Iw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:in-reply-to:references;\n bh=3Wo47tI1VUFWCXaudhypvJgBtWXPyxvPP/YWpBZyf0o=;\n b=NPwC+yInjy2iNWQgZajMYIY8PI2zIgCvuilGfQDQnqUf02uj0BCBq+AFSvPGC4Mq8n\n /TF8MFFTQwnEi6FALVJcc41FkB9RwYymAyxLzeKpYzc9B3ts8Fae6TwYHt420U+HlUWc\n 4TrLqs9x+Oh4NCkrNCOL2onvVfRYahIUj4iuw0/pyiQ27cf/CVB7CIjUUHM+ijPx97+R\n broZQ1dgA0gwstrYWg1JcshYLV9+EkQUDOGCiz/8fZsEBSJQPOWZhThrXVV3M+c6AqYl\n PT08zPLPhLeerlrsuK8ytyEvSN1L/2BZp4xheawxyvab/s5oEArEbFoEKavKJY9Ii7+0\n laVQ==", "X-Gm-Message-State": "AOAM5309ZVsvGB/eA0NaCyaVZgq4T6tNTYnoI7ItSw8/O3QSWKU4aJM0\n TUj8UdlWgUpmYDAcdj3iRYzB0o40Z+004w==", "X-Google-Smtp-Source": "\n ABdhPJwCfb/O1H7RaXl/Dnxt9GjsP+X0blFvvBiUri4BGBLJFvRl5nZfGkAEyxcBGdWN/wS5HX04Ow==", "X-Received": "by 2002:a17:90a:517:: with SMTP id\n h23mr5900394pjh.108.1613507766071;\n Tue, 16 Feb 2021 12:36:06 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Tue, 16 Feb 2021 12:35:35 -0800", "Message-Id": "<20210216203540.29290-11-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "References": [ "<20210216203540.29290-1-aboyer@pensando.io>", "<20210204195853.13411-1-aboyer@pensando.io>" ], "Subject": "[dpdk-dev] [PATCH v2 10/15] net/ionic: log queue counters when\n tearing down", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This improves debuggability.\n\nTo see the logs, use EAL arg: --log-level=pmd.net.ionic,debug\n\nWhile here, stop counting fragments, but start counting mtods.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.h | 2 +-\n drivers/net/ionic/ionic_rxtx.c | 13 +++++++++++--\n 2 files changed, 12 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex ba1471b6e9..5885aa1546 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -34,7 +34,6 @@ struct ionic_tx_stats {\n \tuint64_t stop;\n \tuint64_t no_csum;\n \tuint64_t tso;\n-\tuint64_t frags;\n };\n \n struct ionic_rx_stats {\n@@ -44,6 +43,7 @@ struct ionic_rx_stats {\n \tuint64_t bad_cq_status;\n \tuint64_t no_room;\n \tuint64_t bad_len;\n+\tuint64_t mtods;\n };\n \n #define IONIC_QCQ_F_INITED\tBIT(0)\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 89b37733b6..fa92fca2f5 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -123,9 +123,13 @@ void __rte_cold\n ionic_dev_tx_queue_release(void *tx_queue)\n {\n \tstruct ionic_tx_qcq *txq = tx_queue;\n+\tstruct ionic_tx_stats *stats = &txq->stats;\n \n \tIONIC_PRINT_CALL();\n \n+\tIONIC_PRINT(DEBUG, \"TX queue %u pkts %ju tso %ju\",\n+\t\ttxq->qcq.q.index, stats->packets, stats->tso);\n+\n \tionic_lif_txq_deinit(txq);\n \n \tionic_qcq_free(&txq->qcq);\n@@ -410,7 +414,6 @@ ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \t\toffset = 0;\n \t\tdata_iova = rte_mbuf_data_iova(txm_seg);\n \t\tleft = txm_seg->data_len;\n-\t\tstats->frags++;\n \n \t\twhile (left > 0) {\n \t\t\tnext_addr = rte_cpu_to_le_64(data_iova + offset);\n@@ -508,7 +511,6 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \twhile (txm_seg != NULL) {\n \t\telem->len = txm_seg->data_len;\n \t\telem->addr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm_seg));\n-\t\tstats->frags++;\n \t\telem++;\n \t\ttxm_seg = txm_seg->next;\n \t}\n@@ -657,12 +659,18 @@ void __rte_cold\n ionic_dev_rx_queue_release(void *rx_queue)\n {\n \tstruct ionic_rx_qcq *rxq = rx_queue;\n+\tstruct ionic_rx_stats *stats;\n \n \tif (!rxq)\n \t\treturn;\n \n \tIONIC_PRINT_CALL();\n \n+\tstats = &rxq->stats;\n+\n+\tIONIC_PRINT(DEBUG, \"RX queue %u pkts %ju mtod %ju\",\n+\t\trxq->qcq.q.index, stats->packets, stats->mtods);\n+\n \tionic_rx_empty(rxq);\n \n \tionic_lif_rxq_deinit(rxq);\n@@ -887,6 +895,7 @@ ionic_rx_clean(struct ionic_rx_qcq *rxq,\n \t\t\t\tpkt_type = RTE_PTYPE_L2_ETHER_ARP;\n \t\t\telse\n \t\t\t\tpkt_type = RTE_PTYPE_UNKNOWN;\n+\t\t\tstats->mtods++;\n \t\t\tbreak;\n \t\t}\n \t}\n", "prefixes": [ "v2", "10/15" ] }