Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87849/?format=api
{ "id": 87849, "url": "http://patches.dpdk.org/api/patches/87849/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210211082004.23626-1-sarosh.arif@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210211082004.23626-1-sarosh.arif@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210211082004.23626-1-sarosh.arif@emumba.com", "date": "2021-02-11T08:20:04", "name": "[v4] usertools: show valid hugepage sizes if user requests an invalid hugepage size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d0cbeb886773a72daacd82a0814490674006580", "submitter": { "id": 1638, "url": "http://patches.dpdk.org/api/people/1638/?format=api", "name": "Sarosh Arif", "email": "sarosh.arif@emumba.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210211082004.23626-1-sarosh.arif@emumba.com/mbox/", "series": [ { "id": 15233, "url": "http://patches.dpdk.org/api/series/15233/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15233", "date": "2021-02-11T08:20:04", "name": "[v4] usertools: show valid hugepage sizes if user requests an invalid hugepage size", "version": 4, "mbox": "http://patches.dpdk.org/series/15233/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87849/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E10A9A054A;\n\tThu, 11 Feb 2021 09:20:48 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5A81D1CC55C;\n\tThu, 11 Feb 2021 09:20:48 +0100 (CET)", "from mail-ej1-f41.google.com (mail-ej1-f41.google.com\n [209.85.218.41])\n by mails.dpdk.org (Postfix) with ESMTP id 6D57D1CC505\n for <dev@dpdk.org>; Thu, 11 Feb 2021 09:20:47 +0100 (CET)", "by mail-ej1-f41.google.com with SMTP id f14so8679671ejc.8\n for <dev@dpdk.org>; Thu, 11 Feb 2021 00:20:47 -0800 (PST)", "from localhost.localdomain ([182.191.83.208])\n by smtp.gmail.com with ESMTPSA id p10sm3179242edj.2.2021.02.11.00.20.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 11 Feb 2021 00:20:46 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=0o2tlPI1enwsqsxdtDYGe8eMfuCXBaQEqqcndYirMlc=;\n b=Tmipi+TGis9Ff2SXMcsvfNAjB5kprNpld4Z7MmuDS6RVrhavSTkCuAOsdCEef1lYOx\n s/EZxwhQXAs4yzS8qHHKxMXsSpYFh3B4hv+MaIlwRXMaLCcFQ+muBAKSPFyUG/kGxNsR\n eWuX6vp1s+HAYSfRtnycWnNw5EOzAUpm9h83kmLAfSNgNeb9cH2ozL6dUqtGustr/vVI\n 9tK7ZfU5UZkzqCFOP3gRQgj5ZdJLWVFRSGkjTOTpHQyQHJt2tufrxOdwqfmK+oDzuUKc\n 64Aiw0FlOjp3NnnYkgUVhPKXzkRMvbXysvm5K9gO2PUHGMt48YxpCf0RtiUyhDnKbEtX\n yxnA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=0o2tlPI1enwsqsxdtDYGe8eMfuCXBaQEqqcndYirMlc=;\n b=oo6Uyo/CKeXmvyPrNN1Kl2ywHuVF9qVbsVwRk+szkK9iJVfsR/sPyqDhKYG6ar/e2v\n tsHgqBYHhJH9UmOC4EOSX4dWTLVGxNcQLYF1xvQbyuCNPtBzJUnnP2QSt5u+sWoGQ0lc\n XjnwstIKQ5WAd7k2nyuq/5GTZ9sRpqWkg8sCrrsG811yYtXz4zpkQaE/F0y9OwLWuR7O\n qZ6p0ZTLhS8TE3bpbo5qqLAlxeJKPq+1ifEOo+q1p0By+nQgOPUax/V3Xh2kbdh9AOeX\n KHcLLQuCCANeOectmwf9FcQqAOICKuHYj6syJf2fegPJdSkGy4KM5BEawMRopPoMzFX7\n 9BNg==", "X-Gm-Message-State": "AOAM530nHSflV/8cp2Sn1kQRnhSnGntgXpr0X/D/y/18xff1sSvfQkvv\n 0wjcNcTn045G3It8dV3OXG5e7g==", "X-Google-Smtp-Source": "\n ABdhPJx/qjTzcMnf1UBSplfdbXDwJVg12vgp6RUAW4WgtwqO+bfn33rWqnF9rDXLYjK5Ocwg0pRdWg==", "X-Received": "by 2002:a17:906:3850:: with SMTP id\n w16mr7454182ejc.286.1613031647124;\n Thu, 11 Feb 2021 00:20:47 -0800 (PST)", "From": "Sarosh Arif <sarosh.arif@emumba.com>", "To": "sthemmin@microsoft.com", "Cc": "dev@dpdk.org,\n\tSarosh Arif <sarosh.arif@emumba.com>", "Date": "Thu, 11 Feb 2021 13:20:04 +0500", "Message-Id": "<20210211082004.23626-1-sarosh.arif@emumba.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210210061605.30648-1-sarosh.arif@emumba.com>", "References": "<20210210061605.30648-1-sarosh.arif@emumba.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [v4 PATCH] usertools: show valid hugepage sizes if user\n requests an invalid hugepage size", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If user requests a hugepage size which is not supported by the system,\ncurrently user gets an error message saying that the requested size\nis not a valid system huge page size. In addition to this if we display\nthe valid hugepage sizes it will be convenient for the user to request\nthe right size next time.\n\nSigned-off-by: Sarosh Arif <sarosh.arif@emumba.com>\n---\nv2:\npass string in sys.exit() to remove pylint warning\nv3:\nmodify get_valid_page_sizes()\nv4:\nfix indentation\n---\n usertools/dpdk-hugepages.py | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/usertools/dpdk-hugepages.py b/usertools/dpdk-hugepages.py\nindex 70432f9cd..e68bae5a4 100755\n--- a/usertools/dpdk-hugepages.py\n+++ b/usertools/dpdk-hugepages.py\n@@ -43,6 +43,12 @@ def is_numa():\n return os.path.exists('/sys/devices/system/node')\n \n \n+def get_valid_page_sizes(path):\n+ '''Extract valid hugepage sizes'''\n+ dir = os.path.dirname(path)\n+ pg_sizes = (d.split(\"-\")[1] for d in os.listdir(dir))\n+ return \" \".join(pg_sizes)\n+\n def get_hugepages(path):\n '''Read number of reserved pages'''\n with open(path + '/nr_hugepages') as nr_hugepages:\n@@ -59,9 +65,8 @@ def set_hugepages(path, pages):\n except PermissionError:\n sys.exit('Permission denied: need to be root!')\n except FileNotFoundError:\n- filename = os.path.basename(path)\n- size = filename[10:]\n- sys.exit('{} is not a valid system huge page size'.format(size))\n+ sys.exit(\"Invalid page size. Valid page sizes: {}\".format(\n+ get_valid_page_sizes(path)))\n if get_hugepages(path) != pages:\n sys.exit('Unable to reserve required pages.')\n \n", "prefixes": [ "v4" ] }