Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87846/?format=api
{ "id": 87846, "url": "http://patches.dpdk.org/api/patches/87846/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210210203654.10132-1-pallavi.kadam@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210210203654.10132-1-pallavi.kadam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210210203654.10132-1-pallavi.kadam@intel.com", "date": "2021-02-10T20:36:54", "name": "[v2] bus/pci: fix probing for non-netuio bound devices", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c935607e7621e18bd80cc08c7a6d8a39e970336b", "submitter": { "id": 1177, "url": "http://patches.dpdk.org/api/people/1177/?format=api", "name": "Kadam, Pallavi", "email": "pallavi.kadam@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210210203654.10132-1-pallavi.kadam@intel.com/mbox/", "series": [ { "id": 15230, "url": "http://patches.dpdk.org/api/series/15230/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15230", "date": "2021-02-10T20:36:54", "name": "[v2] bus/pci: fix probing for non-netuio bound devices", "version": 2, "mbox": "http://patches.dpdk.org/series/15230/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87846/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87846/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE5B4A0550;\n\tWed, 10 Feb 2021 21:45:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3774640693;\n\tWed, 10 Feb 2021 21:45:18 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id A858E40142\n for <dev@dpdk.org>; Wed, 10 Feb 2021 21:45:16 +0100 (CET)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Feb 2021 12:45:15 -0800", "from win-dpdk-pallavi.jf.intel.com (HELO localhost.localdomain)\n ([10.166.188.111])\n by fmsmga007.fm.intel.com with ESMTP; 10 Feb 2021 12:45:14 -0800" ], "IronPort-SDR": [ "\n I68wtiquSmkgMyR2ZZSBcXP8Gg6zoEZ9TqQeTSH1RyMqvY+x4pKeC8uVJq1ViMd9SA1ahl1Kt+\n WiFjos+gFCHQ==", "\n 3NXHH+fB4s+JSBBh5L4IdbZtACRfEZSymldZj1evZAND+VdyEJedR30OfsGE4sjUd6G/8BemqX\n JaRooalNiJoA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9891\"; a=\"169274965\"", "E=Sophos;i=\"5.81,169,1610438400\"; d=\"scan'208\";a=\"169274965\"", "E=Sophos;i=\"5.81,169,1610438400\"; d=\"scan'208\";a=\"361471636\"" ], "X-ExtLoop1": "1", "From": "Pallavi Kadam <pallavi.kadam@intel.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "ranjit.menon@intel.com, dmitry.kozliuk@gmail.com,\n Narcisa.Vasile@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com", "Date": "Wed, 10 Feb 2021 12:36:54 -0800", "Message-Id": "<20210210203654.10132-1-pallavi.kadam@intel.com>", "X-Mailer": "git-send-email 2.18.0.windows.1", "In-Reply-To": "<20210210014008.11112-1-pallavi.kadam@intel.com>", "References": "<20210210014008.11112-1-pallavi.kadam@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] bus/pci: fix probing for non-netuio bound\n devices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implement rte_pci_map_device() to distinguish between the devices bound\nto netuio and NDIS devices.\nOnly return success for the netuio devices.\n\nv2 changes:\n\t- Extended the comment to mention about mapping\n\t- replaced the return errno value with -1\n\nSuggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\nSigned-off-by: Pallavi Kadam <pallavi.kadam@intel.com>\nReviewed-by: Ranjit Menon <ranjit.menon@intel.com>\n---\n drivers/bus/pci/windows/pci.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c\nindex f66258452..00e7849b0 100644\n--- a/drivers/bus/pci/windows/pci.c\n+++ b/drivers/bus/pci/windows/pci.c\n@@ -23,20 +23,22 @@ DEFINE_DEVPROPKEY(DEVPKEY_Device_Numa_Node, 0x540b947e, 0x8b40, 0x45bc,\n * the registry hive for PCI devices.\n */\n \n-/* The functions below are not implemented on Windows,\n+/* Some of the functions below are not implemented on Windows,\n * but need to be defined for compilation purposes\n */\n \n /* Map pci device */\n int\n-rte_pci_map_device(struct rte_pci_device *dev __rte_unused)\n+rte_pci_map_device(struct rte_pci_device *dev)\n {\n-\t/* This function is not implemented on Windows.\n-\t * We really should short-circuit the call to these functions by\n-\t * clearing the RTE_PCI_DRV_NEED_MAPPING flag\n-\t * in the rte_pci_driver flags.\n+\t/* Only return success for devices bound to netuio.\n+\t * Devices that are bound to netuio are mapped at\n+\t * the bus probing stage.\n \t */\n-\treturn 0;\n+\tif (dev->kdrv == RTE_PCI_KDRV_NIC_UIO)\n+\t\treturn 0;\n+\telse\n+\t\treturn -1;\n }\n \n /* Unmap pci device */\n", "prefixes": [ "v2" ] }