Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87766/?format=api
{ "id": 87766, "url": "http://patches.dpdk.org/api/patches/87766/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-12-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210204195853.13411-12-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210204195853.13411-12-aboyer@pensando.io", "date": "2021-02-04T19:58:50", "name": "[11/14] net/ionic: ring doorbell once at the end of each burst", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9e2c44ec3d5d3d0305c67d9395d2e691d42c775c", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-12-aboyer@pensando.io/mbox/", "series": [ { "id": 15176, "url": "http://patches.dpdk.org/api/series/15176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15176", "date": "2021-02-04T19:58:39", "name": "net/ionic: struct optimizations, fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/15176/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87766/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87766/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 228F2A0524;\n\tThu, 4 Feb 2021 21:00:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B93CE24082E;\n\tThu, 4 Feb 2021 20:59:42 +0100 (CET)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 14BB0240828\n for <dev@dpdk.org>; Thu, 4 Feb 2021 20:59:40 +0100 (CET)", "by mail-pf1-f174.google.com with SMTP id x23so1280411pfn.6\n for <dev@dpdk.org>; Thu, 04 Feb 2021 11:59:40 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id r14sm7757915pgi.27.2021.02.04.11.59.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 04 Feb 2021 11:59:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=KL+OWJnxxLzAzgT+VugGRoow4eeEjwDQz4PZFZc5TEI=;\n b=tZucEAHW0K4/IUxubY7y80p4NOiOE13c3Dg3duM0SmYOnpL6K8KfGibz4ugMHzv52n\n uTq5OYyxWRanUMew0ct6ogJbLjJ0RnHRs+fam+j8x0lvmnm/i10am9dfJWkIMVdwwSbZ\n 5N73IyAdJ3LQIBt/y42YtRuy7lxmYeI45r1+JPIPEkGrZW1APQjKGZFvSFFdUO/fTpjI\n Y/8AHaxcXVcGZIE4X02WMBpoFtEXZ8VJbezeDJFfxq7uy8PWTKffMJn5bVYU3YPyiJU6\n y/7z/kU27WU7aiUV4vdQxlDwB/t4TTU0ogeILrWMZjRVYTOlAV+hOw1ibCWObGzyng3E\n PseQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=KL+OWJnxxLzAzgT+VugGRoow4eeEjwDQz4PZFZc5TEI=;\n b=TneyRm75fSCKAKrtgaga/EnEeh8doxmrECe9y/vxiNmodZcpoASSPqPiEAVYaEOujC\n 1KrGkfUEb32+NoJISk/Ig6aZaIlS6KFLRZTn3ZhGTKpx8/ZH6Q2nA7AeUvzXNjwdX6vh\n +Q/abuRZ6UkfDU+Y/3JC4qbH477byradsSxMhI3aVIm7UeIgYv2n56GlLiJNcYQTxynI\n 10R4bwP2DgY20HNABiTi4nCInYkIHKXuSmACFogYBkfXSzvAknq7p4BoAfI6jna6bvZc\n BMDiU6Q+AqoPR9TmROW9UWlhBi6NmJUkyeCXlGrnq/pFE/I3Nr1S4uut12V0+Jb+Rw8f\n KQSA==", "X-Gm-Message-State": "AOAM532iPMttAR3Mna85JzY5AqlY131sI/zbV71ZazgR4mBNoIFEw7mU\n OZi9PFfZnSp4SZ7foAgxb0nbMlr0624KAg==", "X-Google-Smtp-Source": "\n ABdhPJwsYL5P/OixhyBYSqJwr6rDF6DYYbeauas7UBpJMwtAeBiiY6KFvOGBaMc8u4zNsNGxUgpjVA==", "X-Received": "by 2002:a65:6246:: with SMTP id q6mr685742pgv.6.1612468779110;\n Thu, 04 Feb 2021 11:59:39 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Thu, 4 Feb 2021 11:58:50 -0800", "Message-Id": "<20210204195853.13411-12-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210204195853.13411-1-aboyer@pensando.io>", "References": "<20210204195853.13411-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 11/14] net/ionic: ring doorbell once at the end\n of each burst", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This improves performance.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_rxtx.c | 41 +++++++++++-----------------------\n 1 file changed, 13 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex c671b34e94..2522c8283a 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -47,8 +47,6 @@\n #include \"ionic_lif.h\"\n #include \"ionic_rxtx.h\"\n \n-#define IONIC_RX_RING_DOORBELL_STRIDE\t\t(32 - 1)\n-\n /*********************************************************************\n *\n * TX functions\n@@ -322,9 +320,6 @@ ionic_tx_tso_post(struct ionic_queue *q, struct ionic_txq_desc *desc,\n \t}\n \n \tq->head_idx = Q_NEXT_TO_POST(q, 1);\n-\n-\tif (done)\n-\t\tionic_q_flush(q);\n }\n \n static struct ionic_txq_desc *\n@@ -341,8 +336,7 @@ ionic_tx_tso_next(struct ionic_tx_qcq *txq, struct ionic_txq_sg_elem **elem)\n }\n \n static int\n-ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n-\t\tbool not_xmit_more)\n+ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm)\n {\n \tstruct ionic_queue *q = &txq->qcq.q;\n \tstruct ionic_tx_stats *stats = &txq->stats;\n@@ -410,7 +404,7 @@ ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \t\t\thdrlen, mss,\n \t\t\tencap,\n \t\t\tvlan_tci, has_vlan,\n-\t\t\tstart, done && not_xmit_more);\n+\t\t\tstart, done);\n \t\tdesc = ionic_tx_tso_next(txq, &elem);\n \t\tstart = false;\n \t\tseglen = mss;\n@@ -451,7 +445,7 @@ ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \t\t\t\thdrlen, mss,\n \t\t\t\tencap,\n \t\t\t\tvlan_tci, has_vlan,\n-\t\t\t\tstart, done && not_xmit_more);\n+\t\t\t\tstart, done);\n \t\t\tdesc = ionic_tx_tso_next(txq, &elem);\n \t\t\tstart = false;\n \t\t}\n@@ -465,8 +459,7 @@ ionic_tx_tso(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n }\n \n static __rte_always_inline int\n-ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n-\t\tbool not_xmit_more)\n+ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm)\n {\n \tstruct ionic_queue *q = &txq->qcq.q;\n \tstruct ionic_txq_desc *desc, *desc_base = q->base;\n@@ -531,9 +524,6 @@ ionic_tx(struct ionic_tx_qcq *txq, struct rte_mbuf *txm,\n \n \tq->head_idx = Q_NEXT_TO_POST(q, 1);\n \n-\tif (not_xmit_more)\n-\t\tionic_q_flush(q);\n-\n \treturn 0;\n }\n \n@@ -548,7 +538,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tuint32_t bytes_tx = 0;\n \tuint16_t nb_tx = 0;\n \tint err;\n-\tbool last;\n \n \t/* Cleaning old buffers */\n \tionic_tx_flush(txq);\n@@ -559,8 +548,6 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t}\n \n \twhile (nb_tx < nb_pkts) {\n-\t\tlast = (nb_tx == (nb_pkts - 1));\n-\n \t\tnext_q_head_idx = Q_NEXT_TO_POST(q, 1);\n \t\tif ((next_q_head_idx & 0x3) == 0) {\n \t\t\tstruct ionic_txq_desc *desc_base = q->base;\n@@ -569,13 +556,11 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t}\n \n \t\tif (tx_pkts[nb_tx]->ol_flags & PKT_TX_TCP_SEG)\n-\t\t\terr = ionic_tx_tso(txq, tx_pkts[nb_tx], last);\n+\t\t\terr = ionic_tx_tso(txq, tx_pkts[nb_tx]);\n \t\telse\n-\t\t\terr = ionic_tx(txq, tx_pkts[nb_tx], last);\n+\t\t\terr = ionic_tx(txq, tx_pkts[nb_tx]);\n \t\tif (err) {\n \t\t\tstats->drop += nb_pkts - nb_tx;\n-\t\t\tif (nb_tx > 0)\n-\t\t\t\tionic_q_flush(q);\n \t\t\tbreak;\n \t\t}\n \n@@ -583,6 +568,11 @@ ionic_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tnb_tx++;\n \t}\n \n+\tif (nb_tx > 0) {\n+\t\trte_wmb();\n+\t\tionic_q_flush(q);\n+\t}\n+\n \tstats->packets += nb_tx;\n \tstats->bytes += bytes_tx;\n \n@@ -954,7 +944,6 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq, uint32_t len)\n \tvoid **info;\n \trte_iova_t dma_addr;\n \tuint32_t i, j, nsegs, buf_size, size;\n-\tbool ring_doorbell;\n \n \tbuf_size = (uint16_t)(rte_pktmbuf_data_room_size(rxq->mb_pool) -\n \t\tRTE_PKTMBUF_HEADROOM);\n@@ -1010,17 +999,13 @@ ionic_rx_fill(struct ionic_rx_qcq *rxq, uint32_t len)\n \t\t\tIONIC_PRINT(ERR, \"Rx SG size is not sufficient (%d < %d)\",\n \t\t\t\tsize, len);\n \n-\t\tring_doorbell = ((q->head_idx + 1) &\n-\t\t\tIONIC_RX_RING_DOORBELL_STRIDE) == 0;\n-\n \t\tinfo[0] = rxm;\n \n \t\tq->head_idx = Q_NEXT_TO_POST(q, 1);\n-\n-\t\tif (ring_doorbell)\n-\t\t\tionic_q_flush(q);\n \t}\n \n+\tionic_q_flush(q);\n+\n \treturn 0;\n }\n \n", "prefixes": [ "11/14" ] }