Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87763/?format=api
{ "id": 87763, "url": "http://patches.dpdk.org/api/patches/87763/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-9-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210204195853.13411-9-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210204195853.13411-9-aboyer@pensando.io", "date": "2021-02-04T19:58:47", "name": "[08/14] net/ionic: use the socket id passed in for Rx and Tx queues", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d3d46c681a0be52a895103d1801e671b08f038c7", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210204195853.13411-9-aboyer@pensando.io/mbox/", "series": [ { "id": 15176, "url": "http://patches.dpdk.org/api/series/15176/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15176", "date": "2021-02-04T19:58:39", "name": "net/ionic: struct optimizations, fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/15176/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87763/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 835A9A0524;\n\tThu, 4 Feb 2021 21:00:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F0E80240818;\n\tThu, 4 Feb 2021 20:59:35 +0100 (CET)", "from mail-pg1-f177.google.com (mail-pg1-f177.google.com\n [209.85.215.177])\n by mails.dpdk.org (Postfix) with ESMTP id CB75D240804\n for <dev@dpdk.org>; Thu, 4 Feb 2021 20:59:34 +0100 (CET)", "by mail-pg1-f177.google.com with SMTP id o63so2874485pgo.6\n for <dev@dpdk.org>; Thu, 04 Feb 2021 11:59:34 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id r14sm7757915pgi.27.2021.02.04.11.59.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 04 Feb 2021 11:59:33 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=wK+zrvH68Xo1JmlCYpS0dNpT8HzExAqH76/8kNBDBdw=;\n b=hfqQq/wTPj9OKyxBqQdAzqFfsg1qR63znv0THaAqmSBXXNxcLJWGCfjzodfkbVu8Zo\n H/NMy46+s//Wl5HpWcCbrZ5UtKSc+VCywC1v15uk1MQWM7ppqJMhAJ6xlWeWqYHXtcz+\n MKDluTz5E4iMd0yKT+i6d5R02iq1b/qHYWO2oQ9R5UgN3/IkVWoX7SCMcNeCrMo7o2N+\n 8N6nLrwKdW59Eritlyqd3cQ9X1Vmnca931O/irA4fh7EAAbRz8hVjZ5SiQIg1EbT3EWm\n Y/FJuaHQYsZY4eIz788w77cMPrtvlJJ0kGC9IT/Bp6p1/V97r1e2I8qoBvAOW5GW8Rff\n e1cA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=wK+zrvH68Xo1JmlCYpS0dNpT8HzExAqH76/8kNBDBdw=;\n b=A50iqXOtyi2pVadYMsREJU/e6gaoCuaevrZpmIZEUAtEyrrJlOlJaLS0LTgGfVxFgV\n e11MM3NTRqIVwXbu9y7I+fSuTVQd5ORCgTnkUudwFpjhRrpDnGD0JYK62q+r7Z6e10+2\n fTkN6NzCWLT5hcDTBa8/itK0Q55eXqSUemdm9v7Srei6eT3VL/ckUC/wNRZuYplH3U4V\n P/wgCJZ3xqof5QE/yVVLL3z2WNV8x74Dxel3HmEkEocN5Uy3Xz60RY3vbnU78KxiwRVm\n C3uR1hWKvvYYGG1jOvj8fI+/x04R1M7KXU1mMIngg5lVtQ8tl4rbe6Yljnt7iR6TTDXh\n AFGQ==", "X-Gm-Message-State": "AOAM5305qoAwMwDBilGuE11L5AodBsHoGaqucVeks/w0vNAeLWZQ53MG\n 0LEm2i6yEMZEQBsMYuiqr1HsdY2Lg39CLQ==", "X-Google-Smtp-Source": "\n ABdhPJz/leVOYimzZYZCImMGT8HokaUeajmkkExltueVmy6BqklqIuA9UNMkftdT41GqZg8GyY/sgQ==", "X-Received": "by 2002:a63:f703:: with SMTP id x3mr657061pgh.66.1612468773881;\n Thu, 04 Feb 2021 11:59:33 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Thu, 4 Feb 2021 11:58:47 -0800", "Message-Id": "<20210204195853.13411-9-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210204195853.13411-1-aboyer@pensando.io>", "References": "<20210204195853.13411-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 08/14] net/ionic: use the socket id passed in for\n Rx and Tx queues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Pipe the value from the queue setup routines through to\nionic_qcq_alloc().\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_lif.c | 10 +++++++---\n drivers/net/ionic/ionic_lif.h | 10 ++++++----\n drivers/net/ionic/ionic_rxtx.c | 4 ++--\n 3 files changed, 15 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c\nindex 87579a09e5..dd79068948 100644\n--- a/drivers/net/ionic/ionic_lif.c\n+++ b/drivers/net/ionic/ionic_lif.c\n@@ -588,6 +588,7 @@ static int\n ionic_qcq_alloc(struct ionic_lif *lif,\n \t\tuint8_t type,\n \t\tsize_t struct_size,\n+\t\tuint32_t socket_id,\n \t\tuint32_t index,\n \t\tconst char *type_name,\n \t\tuint16_t flags,\n@@ -603,7 +604,6 @@ ionic_qcq_alloc(struct ionic_lif *lif,\n \trte_iova_t q_base_pa = 0;\n \trte_iova_t cq_base_pa = 0;\n \trte_iova_t sg_base_pa = 0;\n-\tuint32_t socket_id = rte_socket_id();\n \tint err;\n \n \t*qcq = NULL;\n@@ -721,7 +721,7 @@ ionic_qcq_free(struct ionic_qcq *qcq)\n }\n \n int\n-ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n+ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,\n \t\tuint16_t nrxq_descs, struct ionic_rx_qcq **rxq_out)\n {\n \tstruct ionic_rx_qcq *rxq;\n@@ -732,6 +732,7 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n \terr = ionic_qcq_alloc(lif,\n \t\tIONIC_QTYPE_RXQ,\n \t\tsizeof(struct ionic_rx_qcq),\n+\t\tsocket_id,\n \t\tindex,\n \t\t\"rx\",\n \t\tflags,\n@@ -752,7 +753,7 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n }\n \n int\n-ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n+ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index,\n \t\tuint16_t ntxq_descs, struct ionic_tx_qcq **txq_out)\n {\n \tstruct ionic_tx_qcq *txq;\n@@ -763,6 +764,7 @@ ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n \terr = ionic_qcq_alloc(lif,\n \t\tIONIC_QTYPE_TXQ,\n \t\tsizeof(struct ionic_tx_qcq),\n+\t\tsocket_id,\n \t\tindex,\n \t\t\"tx\",\n \t\tflags,\n@@ -791,6 +793,7 @@ ionic_admin_qcq_alloc(struct ionic_lif *lif)\n \terr = ionic_qcq_alloc(lif,\n \t\tIONIC_QTYPE_ADMINQ,\n \t\tsizeof(struct ionic_admin_qcq),\n+\t\trte_socket_id(),\n \t\t0,\n \t\t\"admin\",\n \t\tflags,\n@@ -816,6 +819,7 @@ ionic_notify_qcq_alloc(struct ionic_lif *lif)\n \terr = ionic_qcq_alloc(lif,\n \t\tIONIC_QTYPE_NOTIFYQ,\n \t\tsizeof(struct ionic_notify_qcq),\n+\t\trte_socket_id(),\n \t\t0,\n \t\t\"notify\",\n \t\tflags,\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex a8243ebf21..ba1471b6e9 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -196,10 +196,12 @@ int ionic_dev_promiscuous_disable(struct rte_eth_dev *dev);\n int ionic_dev_allmulticast_enable(struct rte_eth_dev *dev);\n int ionic_dev_allmulticast_disable(struct rte_eth_dev *dev);\n \n-int ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n-\tuint16_t nrxq_descs, struct ionic_rx_qcq **qcq_out);\n-int ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t index,\n-\tuint16_t ntxq_descs, struct ionic_tx_qcq **qcq_out);\n+int ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id,\n+\tuint32_t index, uint16_t nrxq_descs,\n+\tstruct ionic_rx_qcq **qcq_out);\n+int ionic_tx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id,\n+\tuint32_t index, uint16_t ntxq_descs,\n+\tstruct ionic_tx_qcq **qcq_out);\n void ionic_qcq_free(struct ionic_qcq *qcq);\n \n int ionic_qcq_enable(struct ionic_qcq *qcq);\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 102cfa4331..0565cea603 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -191,7 +191,7 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \teth_dev->data->tx_queue_state[tx_queue_id] =\n \t\tRTE_ETH_QUEUE_STATE_STOPPED;\n \n-\terr = ionic_tx_qcq_alloc(lif, tx_queue_id, nb_desc, &txq);\n+\terr = ionic_tx_qcq_alloc(lif, socket_id, tx_queue_id, nb_desc, &txq);\n \tif (err) {\n \t\tIONIC_PRINT(DEBUG, \"Queue allocation failure\");\n \t\treturn -EINVAL;\n@@ -718,7 +718,7 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev,\n \teth_dev->data->rx_queue_state[rx_queue_id] =\n \t\tRTE_ETH_QUEUE_STATE_STOPPED;\n \n-\terr = ionic_rx_qcq_alloc(lif, rx_queue_id, nb_desc,\n+\terr = ionic_rx_qcq_alloc(lif, socket_id, rx_queue_id, nb_desc,\n \t\t\t&rxq);\n \tif (err) {\n \t\tIONIC_PRINT(ERR, \"Queue %d allocation failure\", rx_queue_id);\n", "prefixes": [ "08/14" ] }