Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87722/?format=api
{ "id": 87722, "url": "http://patches.dpdk.org/api/patches/87722/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210204073420.2421-7-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210204073420.2421-7-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210204073420.2421-7-ibtisam.tariq@emumba.com", "date": "2021-02-04T07:34:20", "name": "[v4,7/7] examples/vhost_crypto: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "95e257ab2b05c6d38e33db527a47338d2ecb1657", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210204073420.2421-7-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 15146, "url": "http://patches.dpdk.org/api/series/15146/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15146", "date": "2021-02-04T07:34:14", "name": "[v4,1/7] examples/fips_validation: enhance getopt_long usage", "version": 4, "mbox": "http://patches.dpdk.org/series/15146/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87722/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AA011A0A0E;\n\tThu, 4 Feb 2021 08:35:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EE0AC2405C1;\n\tThu, 4 Feb 2021 08:35:04 +0100 (CET)", "from mail-wm1-f42.google.com (mail-wm1-f42.google.com\n [209.85.128.42])\n by mails.dpdk.org (Postfix) with ESMTP id A8E0324059F\n for <dev@dpdk.org>; Thu, 4 Feb 2021 08:35:03 +0100 (CET)", "by mail-wm1-f42.google.com with SMTP id l12so2205827wmq.2\n for <dev@dpdk.org>; Wed, 03 Feb 2021 23:35:03 -0800 (PST)", "from localhost.localdomain ([39.33.143.135])\n by smtp.gmail.com with ESMTPSA id j11sm7082604wrt.26.2021.02.03.23.35.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 03 Feb 2021 23:35:02 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=fYgUCFObKmBMlEz3xcUZhSHwLZmaVrRvR10lapU6ZHM=;\n b=QCCcSLiCqIS6JSrAGAdZf/2vKf4mgG/jxEnKBKtzezXQb1o/ct6dh9WuklmPXxuwqJ\n XlbtVgeHiwMRSeeTRxdjTP0+HGxLPxCBsy/axRjIE4+TK93kHka4dzIHipKx4iCTn2Pr\n GCn7V7ckYCY2VooCNHSFtjHYrpkeTNuxZnthQOdDqNJXZH+0qVuuOGt9CXqIlgl1wKba\n 8c2+DmkmlZvi73eui3Kln12Rv1Ew1jDqPHZuDhEXkbWpQS5BKwir9aWtjkoTXsHgubO+\n aJwujav59KmWR/Tk3qyUSsoEv3kBbo5df1rDsTlKMJFhnJeq+nnN1R/kU619vS6HBWKw\n IlVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=fYgUCFObKmBMlEz3xcUZhSHwLZmaVrRvR10lapU6ZHM=;\n b=HZKl8G1Wgn4ISuB/SrWyq9B4wPBEM3mOh2zGuciDBeESaL0YM/BcQAoUv2IkThvIQJ\n 7TRrTN4wYpqoKuHm+6ZpGHqY1pDGNkUaTCqb4e8D6c/AsVcjiLTLHBrWvUKgQmLg+3Zc\n aKSb3oPT7E0bxhYRoBsFhrGk+/1XdmTbRdyHIzK1m484VVZad8CK0yKlquQEKuqxB0hm\n CNljjtw75OM8amvrY3/myN3Fv+HEB+pitbNIMqL/vZ2Sh1xRTaVvybsWSXGaLaOHlbZx\n Xk+K+8dHaFXFhWEnmlVIcSo3LRNwpFsydMY4/PMEmUD/pDyKPNNZeGsXI85GaeNPmowX\n Kmvg==", "X-Gm-Message-State": "AOAM530eWbveScnC1CIAugIskJX0bA25lq+K6W29ZRz1qmra2y/GQyqL\n qeT/z4tDaW5MU5LjJWjDEVHIDg==", "X-Google-Smtp-Source": "\n ABdhPJz2t/9H/1M31YrRU4zprNhssFIly32KqPeksXEujjnXZv2Ztx9MVo9W1pBfB1g7Ewdmm0HDfQ==", "X-Received": "by 2002:a05:600c:3545:: with SMTP id\n i5mr6286822wmq.134.1612424103376;\n Wed, 03 Feb 2021 23:35:03 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n roy.fan.zhang@intel.com", "Date": "Thu, 4 Feb 2021 07:34:20 +0000", "Message-Id": "<20210204073420.2421-7-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210204073420.2421-1-ibtisam.tariq@emumba.com>", "References": "<20210204073420.2421-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH v4 7/7] examples/vhost_crypto: enhance\n getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: roy.fan.zhang@intel.com\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv4:\n* Set indentation of preprocessor directives.\n\nv3:\n* None.\n\nv2:\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n* Remove unused short options.\n\nv1:\n* enhance getopt_long usage.\n---\n examples/vhost_crypto/main.c | 86 +++++++++++++++++++++---------------\n 1 file changed, 50 insertions(+), 36 deletions(-)", "diff": "diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c\nindex 29c8f7228..efae99781 100644\n--- a/examples/vhost_crypto/main.c\n+++ b/examples/vhost_crypto/main.c\n@@ -62,10 +62,16 @@ struct vhost_crypto_options {\n \tuint32_t guest_polling;\n } options;\n \n-#define CONFIG_KEYWORD\t\t\"config\"\n-#define SOCKET_FILE_KEYWORD\t\"socket-file\"\n-#define ZERO_COPY_KEYWORD\t\"zero-copy\"\n-#define POLLING_KEYWORD\t\t\"guest-polling\"\n+enum {\n+#define OPT_CONFIG \"config\"\n+\tOPT_CONFIG_NUM = 256,\n+#define OPT_SOCKET_FILE \"socket-file\"\n+\tOPT_SOCKET_FILE_NUM,\n+#define OPT_ZERO_COPY \"zero-copy\"\n+\tOPT_ZERO_COPY_NUM,\n+#define OPT_POLLING \"guest-polling\"\n+\tOPT_POLLING_NUM,\n+};\n \n #define NB_SOCKET_FIELDS\t(2)\n \n@@ -198,8 +204,8 @@ vhost_crypto_usage(const char *prgname)\n \t\t\" --%s (lcore,cdev_id,queue_id)[,(lcore,cdev_id,queue_id)]\\n\"\n \t\t\" --%s: zero copy\\n\"\n \t\t\" --%s: guest polling\\n\",\n-\t\tprgname, SOCKET_FILE_KEYWORD, CONFIG_KEYWORD,\n-\t\tZERO_COPY_KEYWORD, POLLING_KEYWORD);\n+\t\tprgname, OPT_SOCKET_FILE, OPT_CONFIG,\n+\t\tOPT_ZERO_COPY, OPT_POLLING);\n }\n \n static int\n@@ -210,11 +216,15 @@ vhost_crypto_parse_args(int argc, char **argv)\n \tchar **argvopt;\n \tint option_index;\n \tstruct option lgopts[] = {\n-\t\t\t{SOCKET_FILE_KEYWORD, required_argument, 0, 0},\n-\t\t\t{CONFIG_KEYWORD, required_argument, 0, 0},\n-\t\t\t{ZERO_COPY_KEYWORD, no_argument, 0, 0},\n-\t\t\t{POLLING_KEYWORD, no_argument, 0, 0},\n-\t\t\t{NULL, 0, 0, 0}\n+\t\t{OPT_SOCKET_FILE, required_argument,\n+\t\t\t\tNULL, OPT_SOCKET_FILE_NUM},\n+\t\t{OPT_CONFIG, required_argument,\n+\t\t\t\tNULL, OPT_CONFIG_NUM},\n+\t\t{OPT_ZERO_COPY, no_argument,\n+\t\t\t\tNULL, OPT_ZERO_COPY_NUM},\n+\t\t{OPT_POLLING, no_argument,\n+\t\t\t\tNULL, OPT_POLLING_NUM},\n+\t\t{NULL, 0, 0, 0}\n \t};\n \n \targvopt = argv;\n@@ -222,36 +232,40 @@ vhost_crypto_parse_args(int argc, char **argv)\n \twhile ((opt = getopt_long(argc, argvopt, \"s:\",\n \t\t\t\t lgopts, &option_index)) != EOF) {\n \n+\t\tif (opt == '?') {\n+\t\t\tvhost_crypto_usage(prgname);\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\tswitch (opt) {\n-\t\tcase 0:\n-\t\t\tif (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tSOCKET_FILE_KEYWORD) == 0) {\n-\t\t\t\tret = parse_socket_arg(optarg);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\t\treturn ret;\n-\t\t\t\t}\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tCONFIG_KEYWORD) == 0) {\n-\t\t\t\tret = parse_config(optarg);\n-\t\t\t\tif (ret < 0) {\n-\t\t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\t\treturn ret;\n-\t\t\t\t}\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tZERO_COPY_KEYWORD) == 0) {\n-\t\t\t\toptions.zero_copy =\n-\t\t\t\t\tRTE_VHOST_CRYPTO_ZERO_COPY_ENABLE;\n-\t\t\t} else if (strcmp(lgopts[option_index].name,\n-\t\t\t\t\tPOLLING_KEYWORD) == 0) {\n-\t\t\t\toptions.guest_polling = 1;\n-\t\t\t} else {\n+\t\tcase OPT_SOCKET_FILE_NUM:\n+\t\t\tret = parse_socket_arg(optarg);\n+\t\t\tif (ret < 0) {\n \t\t\t\tvhost_crypto_usage(prgname);\n-\t\t\t\treturn -EINVAL;\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t\tbreak;\n+\n+\t\tcase OPT_CONFIG_NUM:\n+\t\t\tret = parse_config(optarg);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tvhost_crypto_usage(prgname);\n+\t\t\t\treturn ret;\n \t\t\t}\n \t\t\tbreak;\n+\n+\t\tcase OPT_ZERO_COPY_NUM:\n+\t\t\toptions.zero_copy =\n+\t\t\t\tRTE_VHOST_CRYPTO_ZERO_COPY_ENABLE;\n+\t\t\tbreak;\n+\n+\t\tcase OPT_POLLING_NUM:\n+\t\t\toptions.guest_polling = 1;\n+\t\t\tbreak;\n+\n \t\tdefault:\n-\t\t\treturn -1;\n+\t\t\tvhost_crypto_usage(prgname);\n+\t\t\treturn -EINVAL;\n \t\t}\n \t}\n \n", "prefixes": [ "v4", "7/7" ] }