Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87719/?format=api
{ "id": 87719, "url": "http://patches.dpdk.org/api/patches/87719/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210204073420.2421-4-ibtisam.tariq@emumba.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210204073420.2421-4-ibtisam.tariq@emumba.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210204073420.2421-4-ibtisam.tariq@emumba.com", "date": "2021-02-04T07:34:17", "name": "[v4,4/7] examples/performance-thread/l3fwd-thread: enhance getopt_long usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75a41f864ec19f884680b4e2e4c1bad026317af7", "submitter": { "id": 1680, "url": "http://patches.dpdk.org/api/people/1680/?format=api", "name": "Ibtisam Tariq", "email": "ibtisam.tariq@emumba.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210204073420.2421-4-ibtisam.tariq@emumba.com/mbox/", "series": [ { "id": 15146, "url": "http://patches.dpdk.org/api/series/15146/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15146", "date": "2021-02-04T07:34:14", "name": "[v4,1/7] examples/fips_validation: enhance getopt_long usage", "version": 4, "mbox": "http://patches.dpdk.org/series/15146/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87719/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87719/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E428A0A0E;\n\tThu, 4 Feb 2021 08:34:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 34903240596;\n\tThu, 4 Feb 2021 08:34:49 +0100 (CET)", "from mail-wr1-f52.google.com (mail-wr1-f52.google.com\n [209.85.221.52])\n by mails.dpdk.org (Postfix) with ESMTP id 313C7240596\n for <dev@dpdk.org>; Thu, 4 Feb 2021 08:34:48 +0100 (CET)", "by mail-wr1-f52.google.com with SMTP id q7so2199107wre.13\n for <dev@dpdk.org>; Wed, 03 Feb 2021 23:34:48 -0800 (PST)", "from localhost.localdomain ([39.33.143.135])\n by smtp.gmail.com with ESMTPSA id j11sm7082604wrt.26.2021.02.03.23.34.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 03 Feb 2021 23:34:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=emumba-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=CJGk2Wn+nSLdWIWbjQrTbm1E7PYXh8Uju35NS1n34ho=;\n b=YgZZuAOV51Yp3D1Fb2H/Zpn51ZZSpRQL5nzfnLAtdDDOFJSOK1LfezKpx5c+LxlnmA\n 0ilEwZhuncD7Zm+LOUnpRq/709waphlStI4kgErr7Hb2NaRn73QTOFH8+EBjt4Idhhkb\n cHnjeu9xJbXfJyRFOmbodnKTYS7qTpuVyxwC6auLICJ0SerzQySXdHZFxun6VVvlaZgF\n hgEqPFiSE/ebEedxZOUTNOI2h3nw1Aata63sCEW/mhOWFatV3hTHOtwNJt/2QHOiBcDL\n kN8RpOOZJN9yHB9v8gHQGRD1yP49eD/9EyX5P+zegrWcJB3WLnhbLw2f/gT9hbUi7jW7\n 8tnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=CJGk2Wn+nSLdWIWbjQrTbm1E7PYXh8Uju35NS1n34ho=;\n b=ZkWkglT5CNEv22LQEHOgyWew3ABanND8aZqvKwhJS0hTzHVKfRC6onxMmGqQVU47hG\n zAGqi5Efcf0mj5yksxBEOX6A/26bDowmynWvYyfjz6UjKyUBwqa2wtX/A68VBqlU73bt\n 0ojGezPrXJWoTY0chhqxP1femQ0bzVGxKJrqGzl7PQp0Lncn7AMq3iixZVCoywEAPp6e\n gktDp3bkdohjx2Fd3i4QbB2zlRnktaSj4sJI9+E1ViI+9zHFA170dsofbXHheD14FWeK\n 21XmD8b0HREG+rSuazXQY89QMqjNAwA65cGMSb8k0EsLTMZ37qUj9CpYEH8wcvHlmvCl\n xYfg==", "X-Gm-Message-State": "AOAM5333BXDWu76UgVHSO/JO2Je+FfDeY7VvaeKEUOZTqbu2Ypx8Be3g\n RgIltpqV6Vp5mtuhTytVztb6lA==", "X-Google-Smtp-Source": "\n ABdhPJwv6ufX+uL3loBa8aILTsq+mbx+xxiaJi02kqtR32mYmdh22j5Tl6XtRu2xd+goODJvgnbmmw==", "X-Received": "by 2002:adf:fd52:: with SMTP id h18mr7705093wrs.295.1612424087921;\n Wed, 03 Feb 2021 23:34:47 -0800 (PST)", "From": "Ibtisam Tariq <ibtisam.tariq@emumba.com>", "To": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n cristian.dumitrescu@intel.com, jasvinder.singh@intel.com,\n john.mcnamara@intel.com, reshma.pattan@intel.com,\n konstantin.ananyev@intel.com, marko.kovacevic@intel.com", "Cc": "dev@dpdk.org, Ibtisam Tariq <ibtisam.tariq@emumba.com>,\n ian.betts@intel.com", "Date": "Thu, 4 Feb 2021 07:34:17 +0000", "Message-Id": "<20210204073420.2421-4-ibtisam.tariq@emumba.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210204073420.2421-1-ibtisam.tariq@emumba.com>", "References": "<20210204073420.2421-1-ibtisam.tariq@emumba.com>", "Subject": "[dpdk-dev] [PATCH v4 4/7] examples/performance-thread/l3fwd-thread:\n enhance getopt_long usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of using getopt_long return value, strcmp was used to\ncompare the input parameters with the struct option array. This\npatch get rid of all those strcmp by directly binding each longopt\nwith an int enum. This is to improve readability and consistency in\nall examples.\n\nBugzilla ID: 238\nCc: ian.betts@intel.com\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Ibtisam Tariq <ibtisam.tariq@emumba.com>\n---\nv4:\n* Set indentation of preprocessor directives.\nv3:\n* None.\n\nv2:\n* Remove extra indentations.\n* Remove extra block brackets in switch statement.\n* Change enum names to start with OPT_ and remove KEYWORD from enum names.\n\nv1:\n* enhance getopt_long usage.\n---\n .../performance-thread/l3fwd-thread/main.c | 208 +++++++++---------\n 1 file changed, 106 insertions(+), 102 deletions(-)", "diff": "diff --git a/examples/performance-thread/l3fwd-thread/main.c b/examples/performance-thread/l3fwd-thread/main.c\nindex 4d82fb82e..65652f993 100644\n--- a/examples/performance-thread/l3fwd-thread/main.c\n+++ b/examples/performance-thread/l3fwd-thread/main.c\n@@ -2864,16 +2864,28 @@ parse_eth_dest(const char *optarg)\n \t*(uint64_t *)(val_eth + portid) = dest_eth_addr[portid];\n }\n \n-#define CMD_LINE_OPT_RX_CONFIG \"rx\"\n-#define CMD_LINE_OPT_TX_CONFIG \"tx\"\n-#define CMD_LINE_OPT_STAT_LCORE \"stat-lcore\"\n-#define CMD_LINE_OPT_ETH_DEST \"eth-dest\"\n-#define CMD_LINE_OPT_NO_NUMA \"no-numa\"\n-#define CMD_LINE_OPT_IPV6 \"ipv6\"\n-#define CMD_LINE_OPT_ENABLE_JUMBO \"enable-jumbo\"\n-#define CMD_LINE_OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n-#define CMD_LINE_OPT_NO_LTHREADS \"no-lthreads\"\n-#define CMD_LINE_OPT_PARSE_PTYPE \"parse-ptype\"\n+enum {\n+#define OPT_RX_CONFIG \"rx\"\n+\tOPT_RX_CONFIG_NUM = 256,\n+#define OPT_TX_CONFIG \"tx\"\n+\tOPT_TX_CONFIG_NUM,\n+#define OPT_STAT_LCORE \"stat-lcore\"\n+\tOPT_STAT_LCORE_NUM,\n+#define OPT_ETH_DEST \"eth-dest\"\n+\tOPT_ETH_DEST_NUM,\n+#define OPT_NO_NUMA \"no-numa\"\n+\tOPT_NO_NUMA_NUM,\n+#define OPT_IPV6 \"ipv6\"\n+\tOPT_IPV6_NUM,\n+#define OPT_ENABLE_JUMBO \"enable-jumbo\"\n+\tOPT_ENABLE_JUMBO_NUM,\n+#define OPT_HASH_ENTRY_NUM \"hash-entry-num\"\n+\tOPT_HASH_ENTRY_NUM_NUM,\n+#define OPT_NO_LTHREADS \"no-lthreads\"\n+\tOPT_NO_LTHREADS_NUM,\n+#define OPT_PARSE_PTYPE \"parse-ptype\"\n+\tOPT_PARSE_PTYPE_NUM,\n+};\n \n /* Parse the argument given in the command line of the application */\n static int\n@@ -2884,17 +2896,17 @@ parse_args(int argc, char **argv)\n \tint option_index;\n \tchar *prgname = argv[0];\n \tstatic struct option lgopts[] = {\n-\t\t{CMD_LINE_OPT_RX_CONFIG, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_TX_CONFIG, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_STAT_LCORE, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_ETH_DEST, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_NO_NUMA, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_IPV6, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_ENABLE_JUMBO, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_HASH_ENTRY_NUM, 1, 0, 0},\n-\t\t{CMD_LINE_OPT_NO_LTHREADS, 0, 0, 0},\n-\t\t{CMD_LINE_OPT_PARSE_PTYPE, 0, 0, 0},\n-\t\t{NULL, 0, 0, 0}\n+\t\t{OPT_RX_CONFIG, 1, NULL, OPT_RX_CONFIG_NUM },\n+\t\t{OPT_TX_CONFIG, 1, NULL, OPT_TX_CONFIG_NUM },\n+\t\t{OPT_STAT_LCORE, 1, NULL, OPT_STAT_LCORE_NUM },\n+\t\t{OPT_ETH_DEST, 1, NULL, OPT_ETH_DEST_NUM },\n+\t\t{OPT_NO_NUMA, 0, NULL, OPT_NO_NUMA_NUM },\n+\t\t{OPT_IPV6, 0, NULL, OPT_IPV6_NUM },\n+\t\t{OPT_ENABLE_JUMBO, 0, NULL, OPT_ENABLE_JUMBO_NUM },\n+\t\t{OPT_HASH_ENTRY_NUM, 1, NULL, OPT_HASH_ENTRY_NUM_NUM },\n+\t\t{OPT_NO_LTHREADS, 0, NULL, OPT_NO_LTHREADS_NUM },\n+\t\t{OPT_PARSE_PTYPE, 0, NULL, OPT_PARSE_PTYPE_NUM },\n+\t\t{NULL, 0, 0, 0 }\n \t};\n \n \targvopt = argv;\n@@ -2912,112 +2924,104 @@ parse_args(int argc, char **argv)\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t\tbreak;\n+\n \t\tcase 'P':\n \t\t\tprintf(\"Promiscuous mode selected\\n\");\n \t\t\tpromiscuous_on = 1;\n \t\t\tbreak;\n \n \t\t/* long options */\n-\t\tcase 0:\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_RX_CONFIG,\n-\t\t\t\tsizeof(CMD_LINE_OPT_RX_CONFIG))) {\n-\t\t\t\tret = parse_rx_config(optarg);\n-\t\t\t\tif (ret) {\n-\t\t\t\t\tprintf(\"invalid rx-config\\n\");\n-\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n+\t\tcase OPT_RX_CONFIG_NUM:\n+\t\t\tret = parse_rx_config(optarg);\n+\t\t\tif (ret) {\n+\t\t\t\tprintf(\"invalid rx-config\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_TX_CONFIG,\n-\t\t\t\tsizeof(CMD_LINE_OPT_TX_CONFIG))) {\n-\t\t\t\tret = parse_tx_config(optarg);\n-\t\t\t\tif (ret) {\n-\t\t\t\t\tprintf(\"invalid tx-config\\n\");\n-\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\treturn -1;\n-\t\t\t\t}\n+\t\tcase OPT_TX_CONFIG_NUM:\n+\t\t\tret = parse_tx_config(optarg);\n+\t\t\tif (ret) {\n+\t\t\t\tprintf(\"invalid tx-config\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n \t\t\t}\n+\t\t\tbreak;\n \n #if (APP_CPU_LOAD > 0)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_STAT_LCORE,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_STAT_LCORE))) {\n-\t\t\t\tcpu_load_lcore_id = parse_stat_lcore(optarg);\n-\t\t\t}\n+\t\tcase OPT_STAT_LCORE_NUM:\n+\t\t\tcpu_load_lcore_id = parse_stat_lcore(optarg);\n+\t\t\tbreak;\n #endif\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_ETH_DEST,\n-\t\t\t\tsizeof(CMD_LINE_OPT_ETH_DEST)))\n-\t\t\t\t\tparse_eth_dest(optarg);\n+\t\tcase OPT_ETH_DEST_NUM:\n+\t\t\tparse_eth_dest(optarg);\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_NO_NUMA,\n-\t\t\t\tsizeof(CMD_LINE_OPT_NO_NUMA))) {\n-\t\t\t\tprintf(\"numa is disabled\\n\");\n-\t\t\t\tnuma_on = 0;\n-\t\t\t}\n+\t\tcase OPT_NO_NUMA_NUM:\n+\t\t\tprintf(\"numa is disabled\\n\");\n+\t\t\tnuma_on = 0;\n+\t\t\tbreak;\n \n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_IPV6,\n-\t\t\t\tsizeof(CMD_LINE_OPT_IPV6))) {\n-\t\t\t\tprintf(\"ipv6 is specified\\n\");\n-\t\t\t\tipv6 = 1;\n-\t\t\t}\n+\t\tcase OPT_IPV6_NUM:\n+\t\t\tprintf(\"ipv6 is specified\\n\");\n+\t\t\tipv6 = 1;\n+\t\t\tbreak;\n #endif\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_NO_LTHREADS,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_NO_LTHREADS))) {\n-\t\t\t\tprintf(\"l-threads model is disabled\\n\");\n-\t\t\t\tlthreads_on = 0;\n-\t\t\t}\n+\t\tcase OPT_NO_LTHREADS_NUM:\n+\t\t\tprintf(\"l-threads model is disabled\\n\");\n+\t\t\tlthreads_on = 0;\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_PARSE_PTYPE,\n-\t\t\t\t\tsizeof(CMD_LINE_OPT_PARSE_PTYPE))) {\n-\t\t\t\tprintf(\"software packet type parsing enabled\\n\");\n-\t\t\t\tparse_ptype_on = 1;\n-\t\t\t}\n+\t\tcase OPT_PARSE_PTYPE_NUM:\n+\t\t\tprintf(\"software packet type parsing enabled\\n\");\n+\t\t\tparse_ptype_on = 1;\n+\t\t\tbreak;\n \n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_ENABLE_JUMBO,\n-\t\t\t\tsizeof(CMD_LINE_OPT_ENABLE_JUMBO))) {\n-\t\t\t\tstruct option lenopts = {\"max-pkt-len\", required_argument, 0,\n-\t\t\t\t\t\t0};\n-\n-\t\t\t\tprintf(\"jumbo frame is enabled - disabling simple TX path\\n\");\n-\t\t\t\tport_conf.rxmode.offloads |=\n-\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n-\t\t\t\tport_conf.txmode.offloads |=\n-\t\t\t\t\t\tDEV_TX_OFFLOAD_MULTI_SEGS;\n-\n-\t\t\t\t/* if no max-pkt-len set, use the default value\n-\t\t\t\t * RTE_ETHER_MAX_LEN\n-\t\t\t\t */\n-\t\t\t\tif (0 == getopt_long(argc, argvopt, \"\", &lenopts,\n-\t\t\t\t\t\t&option_index)) {\n-\n-\t\t\t\t\tret = parse_max_pkt_len(optarg);\n-\t\t\t\t\tif ((ret < 64) || (ret > MAX_JUMBO_PKT_LEN)) {\n-\t\t\t\t\t\tprintf(\"invalid packet length\\n\");\n-\t\t\t\t\t\tprint_usage(prgname);\n-\t\t\t\t\t\treturn -1;\n-\t\t\t\t\t}\n-\t\t\t\t\tport_conf.rxmode.max_rx_pkt_len = ret;\n-\t\t\t\t}\n-\t\t\t\tprintf(\"set jumbo frame max packet length to %u\\n\",\n-\t\t\t\t\t\t(unsigned int)port_conf.rxmode.max_rx_pkt_len);\n-\t\t\t}\n-#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n-\t\t\tif (!strncmp(lgopts[option_index].name, CMD_LINE_OPT_HASH_ENTRY_NUM,\n-\t\t\t\tsizeof(CMD_LINE_OPT_HASH_ENTRY_NUM))) {\n-\t\t\t\tret = parse_hash_entry_number(optarg);\n-\t\t\t\tif ((ret > 0) && (ret <= L3FWD_HASH_ENTRIES)) {\n-\t\t\t\t\thash_entry_number = ret;\n-\t\t\t\t} else {\n-\t\t\t\t\tprintf(\"invalid hash entry number\\n\");\n+\t\tcase OPT_ENABLE_JUMBO_NUM:\n+\t\t{\n+\t\t\tstruct option lenopts = {\"max-pkt-len\",\n+\t\t\t\t\trequired_argument, 0, 0};\n+\n+\t\t\tprintf(\"jumbo frame is enabled - disabling simple TX path\\n\");\n+\t\t\tport_conf.rxmode.offloads |=\n+\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\t\tport_conf.txmode.offloads |=\n+\t\t\t\t\tDEV_TX_OFFLOAD_MULTI_SEGS;\n+\n+\t\t\t/* if no max-pkt-len set, use the default value\n+\t\t\t * RTE_ETHER_MAX_LEN\n+\t\t\t */\n+\t\t\tif (0 == getopt_long(argc, argvopt, \"\", &lenopts,\n+\t\t\t\t\t&option_index)) {\n+\n+\t\t\t\tret = parse_max_pkt_len(optarg);\n+\t\t\t\tif ((ret < 64) || (ret > MAX_JUMBO_PKT_LEN)) {\n+\t\t\t\t\tprintf(\"invalid packet length\\n\");\n \t\t\t\t\tprint_usage(prgname);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n+\t\t\t\tport_conf.rxmode.max_rx_pkt_len = ret;\n \t\t\t}\n-#endif\n+\t\t\tprintf(\"set jumbo frame max packet length to %u\\n\",\n+\t\t\t\t(unsigned int)port_conf.rxmode.max_rx_pkt_len);\n \t\t\tbreak;\n+\t\t}\n+#if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n+\t\tcase OPT_HASH_ENTRY_NUM_NUM:\n+\t\t\tret = parse_hash_entry_number(optarg);\n+\t\t\tif ((ret > 0) && (ret <= L3FWD_HASH_ENTRIES)) {\n+\t\t\t\thash_entry_number = ret;\n+\t\t\t} else {\n+\t\t\t\tprintf(\"invalid hash entry number\\n\");\n+\t\t\t\tprint_usage(prgname);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\tbreak;\n+#endif\n \n \t\tdefault:\n \t\t\tprint_usage(prgname);\n", "prefixes": [ "v4", "4/7" ] }