Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87590/?format=api
{ "id": 87590, "url": "http://patches.dpdk.org/api/patches/87590/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1612191313-7654-1-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1612191313-7654-1-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dev/1612191313-7654-1-git-send-email-juraj.linkes@pantheon.tech", "date": "2021-02-01T14:55:13", "name": "[RFC,v1] config/arm: fix native machine args", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7ca90cede3d4618b7889c29a2c59f62f4f98dee8", "submitter": { "id": 1626, "url": "http://patches.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1612191313-7654-1-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 15060, "url": "http://patches.dpdk.org/api/series/15060/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15060", "date": "2021-02-01T14:55:13", "name": "[RFC,v1] config/arm: fix native machine args", "version": 1, "mbox": "http://patches.dpdk.org/series/15060/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87590/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87590/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6FE66A0A0B;\n\tMon, 1 Feb 2021 15:55:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DC2DC40693;\n\tMon, 1 Feb 2021 15:55:17 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by mails.dpdk.org (Postfix) with ESMTP id 13D1240687\n for <dev@dpdk.org>; Mon, 1 Feb 2021 15:55:16 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 034E1BFD91;\n Mon, 1 Feb 2021 15:55:14 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id DWwe1K3duC_2; Mon, 1 Feb 2021 15:55:13 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 63E8BBF47F;\n Mon, 1 Feb 2021 15:55:13 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "bruce.richardson@intel.com, thomas@monjalon.net, Ruifeng.Wang@arm.com,\n Honnappa.Nagarahalli@arm.com, jerinjacobk@gmail.com, ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Date": "Mon, 1 Feb 2021 15:55:13 +0100", "Message-Id": "<1612191313-7654-1-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH v1] config/arm: fix native machine args", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are compiler issues when building with -mcpu=native with popular\ncompilers, such as GCC-8.4 and clang (which doesn't define\n__ARM_FEATURE_ATOMIC). Fix this by always specifying the proper machine\nargs and never using the native flags.\n\nFixes: 78ac8eac7e8a (\"config/arm: use native machine build arguments\")\nCc: juraj.linkes@pantheon.tech\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\n config/arm/meson.build | 10 +---------\n 1 file changed, 1 insertion(+), 9 deletions(-)", "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex f207e5a288..f948768578 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -24,7 +24,6 @@ flags_common = [\n \t['RTE_ARCH_ARM64', true],\n \t['RTE_CACHE_LINE_SIZE', 128]\n ]\n-native_machine_args = ['-mcpu=native']\n \n ## Part numbers are specific to Arm implementers\n # implementer specific aarch64 flags have middle priority\n@@ -193,7 +192,6 @@ if dpdk_conf.get('RTE_ARCH_32')\n \tmachine_args += '-mfpu=neon'\n else\n \t# aarch64 build\n-\tuse_native_machine_args = false\n \tif not meson.is_cross_build()\n \t\tif machine == 'default'\n \t\t\t# default build\n@@ -213,7 +211,6 @@ else\n \t\t\telse\n \t\t\t\terror('Error when getting Arm Implementer ID and part number.')\n \t\t\tendif\n-\t\t\tuse_native_machine_args = true\n \t\tendif\n \telse\n \t\t# cross build\n@@ -249,12 +246,7 @@ else\n \n \t# apply supported machine args\n \tmachine_args = [] # Clear previous machine args\n-\tif use_native_machine_args\n-\t\tcandidate_machine_args = native_machine_args\n-\telse\n-\t\tcandidate_machine_args = part_number_config['machine_args']\n-\tendif\n-\tforeach flag: candidate_machine_args\n+\tforeach flag: part_number_config['machine_args']\n \t\tif cc.has_argument(flag)\n \t\t\tmachine_args += flag\n \t\tendif\n", "prefixes": [ "RFC", "v1" ] }