Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87583/?format=api
{ "id": 87583, "url": "http://patches.dpdk.org/api/patches/87583/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210201083012.28544-1-ido@cgstowernetworks.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210201083012.28544-1-ido@cgstowernetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210201083012.28544-1-ido@cgstowernetworks.com", "date": "2021-02-01T08:30:12", "name": "[v2] net/pcap: imissed stats support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f1f93f4f603a04214e23301e14a234aa0b3baf8", "submitter": { "id": 1047, "url": "http://patches.dpdk.org/api/people/1047/?format=api", "name": "Ido Goshen", "email": "ido@cgstowernetworks.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210201083012.28544-1-ido@cgstowernetworks.com/mbox/", "series": [ { "id": 15053, "url": "http://patches.dpdk.org/api/series/15053/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=15053", "date": "2021-02-01T08:30:12", "name": "[v2] net/pcap: imissed stats support", "version": 2, "mbox": "http://patches.dpdk.org/series/15053/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87583/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87583/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56575A0A0B;\n\tMon, 1 Feb 2021 09:31:16 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D080216064D;\n\tMon, 1 Feb 2021 09:31:15 +0100 (CET)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2119.outbound.protection.outlook.com [40.107.21.119])\n by mails.dpdk.org (Postfix) with ESMTP id D92CD40693\n for <dev@dpdk.org>; Mon, 1 Feb 2021 09:31:14 +0100 (CET)", "from DB7PR09MB2345.eurprd09.prod.outlook.com (2603:10a6:10:44::10)\n by DB6PR0902MB2037.eurprd09.prod.outlook.com (2603:10a6:6:8::24) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Mon, 1 Feb\n 2021 08:31:12 +0000", "from DB7PR09MB2345.eurprd09.prod.outlook.com\n ([fe80::fc34:cf58:29e8:932a]) by DB7PR09MB2345.eurprd09.prod.outlook.com\n ([fe80::fc34:cf58:29e8:932a%6]) with mapi id 15.20.3805.017; Mon, 1 Feb 2021\n 08:31:12 +0000", "from idog-ubuntu.localdomain (81.218.57.230) by\n ZR0P278CA0123.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::20) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.3805.18 via Frontend Transport; Mon, 1 Feb 2021 08:31:11 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=aW0idQ4y4mMcIy3nV4dS1kshs858X+v3JGQuofS0QOH2+bMUqkQKMbi9ku/BHYegR7B6wJRmen+gMeMndltkrmXQbD2gtiwMZLuTrTbdqPrtptYxUNbJKb+2ad2TLQNqNWVLKUK2OPgdpO8YdjPxud8rQ5XOv6a7SI9BFFH64zJy25ABdF5uPs9ibKZtH7HDsxzVFoqAa47ZcdrBe8JNkQ0/6A2nnHYATv7lNX1YAdrnsu4cPO51w6tVYCmuQsgC5H4042x+sEymxW69YasHT7cACayQW3qKHbYM18i48MDaIbZTmf0dwuw7pt890r5yx1Y1SAby02IEG1X596mBqQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DkUxuJdlO8FhK4rI843gK1kQOcCHUz8WO6cPp1fLCVI=;\n b=l1kXD633rZwODmSg3IJxRJijQi+AkbjKEQEMHIWoWNTEzjuun8QZN1JgEOYYuE7ZI+lGsX3ClnGyovzrE5z3yrYaZNHdxTEB1sKy4IaTI+fmD7WsvznQ0SbDE00mN0BtebJobch8XVcaz1CxTvJ2s7tP2OZBi4lCJToietVKexdpX1drId5KyonWo7IcGwzBWmGzcSTpHrhC6YMcmYhvmtdnc0rlH2dGkm94cQTf2rUdwkKhptFCNjv8hKngNsQbUAzTnkwdqdq1RHuGmrK1UuLE4TqHtF+j5242u2qrBFDdxka16h/X+UXC09qwM0baOickyDy/djHQrBQZDsNo6w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=cgstowernetworks.com; dmarc=pass action=none\n header.from=cgstowernetworks.com; dkim=pass header.d=cgstowernetworks.com;\n arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=cgstowernetworks.onmicrosoft.com;\n s=selector2-cgstowernetworks-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=DkUxuJdlO8FhK4rI843gK1kQOcCHUz8WO6cPp1fLCVI=;\n b=Wu6YrKQ6LOBdn4vSUKpjuOI4JcxCf3WkmCOSKQCY5qYvAvXE7020b+r5Etz0dZB233xvf2UidyKkpgBOOhpkpFyB1BUxY/+Rkx/RscPA1gNSdkcJeFAmhzAhrl5MFPwh6TzlNOaNJ55bO1aUJxx6V3K/twc4vGLrekOQoDovW34=", "Authentication-Results": "intel.com; dkim=none (message not signed)\n header.d=none;intel.com; dmarc=none action=none\n header.from=cgstowernetworks.com;", "From": "Ido Goshen <ido@cgstowernetworks.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tIdo Goshen <ido@cgstowernetworks.com>", "Date": "Mon, 1 Feb 2021 10:30:12 +0200", "Message-Id": "<20210201083012.28544-1-ido@cgstowernetworks.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<c6be02ad-5eae-505b-a849-3b20c622542e@intel.com>", "References": "<c6be02ad-5eae-505b-a849-3b20c622542e@intel.com>", "Content-Type": "text/plain", "X-Originating-IP": "[81.218.57.230]", "X-ClientProxiedBy": "ZR0P278CA0123.CHEP278.PROD.OUTLOOK.COM\n (2603:10a6:910:20::20) To DB7PR09MB2345.eurprd09.prod.outlook.com\n (2603:10a6:10:44::10)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "58ca4223-e20a-4e26-47bb-08d8c68bbb73", "X-MS-TrafficTypeDiagnostic": "DB6PR0902MB2037:", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <DB6PR0902MB20379D635B6E9E76AA8D8A38D6B69@DB6PR0902MB2037.eurprd09.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:175;", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xwPgFuTXdfRV8g8ct8Ig2F7waHiLe3ZPEb51/F77dW0v8L7m+o8w5nJK5fOEMVCKyeLiCp09odejrwcfwzeOko/A4t1j82+RtmdT/E+b3BDSz/qh1ObpPylKHxHImUX4KVxoRrVdz5qxYjg/JrRlpBGw33eX0qNwULpPV3/2bWUVSu6NyY47AyVP3vv1d0OCfBtaz6ih2vPz8BQTK2EmSd0uoUVic7DLAflcdI1FoeHRcW/cgXz6UXExFZ3LGhkXsuQJ4/TZ7nzqMrGVwUbprlN9dEUXNmqiR+2TzkPG4rgvFGVq/sOnonozfM0ZWhdGE5/a1uYRO0etVjJBH0/+nZaoDTdEfKvGXUibDlAyyVywY4nXR/aXSWQCSWogBidaEiPuJPJ6ZQS+BAzTqdpB7Dmh+Siw6HODkCgCwtsVS+slBA0V31gNi4EFN9bBdmJWW7PZ4WlLdEYaB0F+zYOQP61/22lE+2hoX9LwqqdK29CgkHi/o49YcNPXQfWvkxza6larzHWPDqblsLu3+kBa+w==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DB7PR09MB2345.eurprd09.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(366004)(346002)(6916009)(83380400001)(66556008)(66946007)(66476007)(956004)(26005)(2616005)(2906002)(5660300002)(1076003)(4326008)(86362001)(508600001)(52116002)(6486002)(107886003)(36756003)(186003)(8676002)(6506007)(8936002)(6512007)(16526019);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData": "\n Xm0O0Dt4BtbknvqkHvdo/CMCIMkWIxeo6ENgvOvF3IBH5Ykv9gEsiT0rPcIiM8HLMLQNkON/9ItVdqG7nBjp3UKNFRQ6YR6IE4kHaol72dXpUZHI1cvBQ44tYfmYX4eTw9yVhDmhkJzInf868mEFyKtUMjdP7Sbc+9nrTFjKjmu4nKKKyMF3CI6emBFvC1oyRwOFN1ujPdPnQC+mfySoqHPDfrzRoao7Qq3VBwtH9O4ejTZKcY2ABOSEeZEJiwwTrwVa3WBKB5A6mOIqhCaj8yLFeUX1VM6CwDmTli754+PZYKImulec/x829xHDOtbzZXcVkr5jylssDCLSNeijP6n0lMlsXMMCJm+1rM1khec1UoX71FTctq95So4U2i+taSFkaMc/kpvZRcDmuwa1JBjj4Bdy+nLq4xVGih/wXMI9TB3bzBJy6xyVtxpIIOr4PZXG382pJaBgZkTn93HnKjuIIowu9+kqgv1In2l8aRKSAJnFhPX5da4flPjMF78ed2aHS/KHObmmuw7eNMPqrSReTS0de2Vc48AQ58BsrtRQ8Yt+RrcdGWotzZ4fzIgeA4vSqrFBpSJ2JhWC0YHPdCqIG4LS5CB62GCHEOv2iFfMJKTD4izmbvtlZD2W/2Ku1+LOYkvhWwEauZFs+hQlDUi/7LYeDEO7/lW3JQ7agI51w7eeZzKmUKZiGRD1NyJckpITsXIvpbLJinIf9tS+t9wSaQx8XBykX4t8DHh49X/zwlrWUzVsdCQioju6DscKcRQfrNRYDLoWfD73Qx/1b4s3lsK1vht78sy7K5KOU7jY/gIYiHMqdVRI2D+mlNHHE31dGBmwSrW3eD6d9scP9Rj1Fe0GRWkoTuG29T0I11rA0F8TWA47vQYJaoh5DAiuOK9l9hwLPwmSmAuvT7N3io2RGS8qJivnbJKekRfZOvUUHM7okQRH9gHKI3QwtH/EfHn+jFY9xF8o1nRcW9Tg7Ma7aDUhvjfh/8+BkglQHU63i06wsaH4k/OulR9L4wlLe/R8UjpKJeYYlbKeU3XHLC60pX2F001fs/zzRoyH8j8AGLxCl3iJBbXYlxDVVb+H", "X-OriginatorOrg": "cgstowernetworks.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 58ca4223-e20a-4e26-47bb-08d8c68bbb73", "X-MS-Exchange-CrossTenant-AuthSource": "DB7PR09MB2345.eurprd09.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "01 Feb 2021 08:31:12.6270 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fc9e9498-07e8-4b82-b4cf-365bba23cbbf", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n reSNQy1okeJW30bD/m+haw8qGXFamn9hp0LBtgpfibiLoYbq+ZEDM3OSzRjaLdPk41PPE70CxDgo40XioVOYyvEaeTF8OxW2nNNI3ihMNEQ=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB6PR0902MB2037", "Subject": "[dpdk-dev] [PATCH v2] net/pcap: imissed stats support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Ido Goshen <ido@cgstowernetworks.com>\n---\nv2:\n* sum all queues (rx_missed_total += fix)\n* null pcap protection\n* inter stop/start persistancy (counter won't reset on stop)\n\n drivers/net/pcap/rte_eth_pcap.c | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex a32b1f3f3..18c59d61c 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -58,6 +58,8 @@ struct queue_stat {\n \tvolatile unsigned long pkts;\n \tvolatile unsigned long bytes;\n \tvolatile unsigned long err_pkts;\n+\tvolatile unsigned long missed_reset;\n+\tvolatile unsigned long missed_mnemonic;\n };\n \n struct pcap_rx_queue {\n@@ -144,6 +146,19 @@ RTE_LOG_REGISTER(eth_pcap_logtype, pmd.net.pcap, NOTICE);\n \trte_log(RTE_LOG_ ## level, eth_pcap_logtype, \\\n \t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n \n+static unsigned long\n+eth_pcap_stats_missed_get(struct rte_eth_dev *dev, unsigned int qid)\n+{\n+\tconst struct pmd_process_private *pp = dev->process_private;\n+\tpcap_t *pcap = pp->rx_pcap[qid];\n+\tif (!pcap)\n+\t\treturn 0;\n+\tstruct pcap_stat stat;\n+\tif (pcap_stats(pcap, &stat) != 0)\n+\t\treturn 0;\n+\treturn stat.ps_drop;\n+}\n+\n static int\n eth_pcap_rx_jumbo(struct rte_mempool *mb_pool, struct rte_mbuf *mbuf,\n \t\tconst u_char *data, uint16_t data_len)\n@@ -621,6 +636,8 @@ eth_dev_stop(struct rte_eth_dev *dev)\n \n \t/* Special iface case. Single pcap is open and shared between tx/rx. */\n \tif (internals->single_iface) {\n+\t\tinternals->rx_queue[0].rx_stat.missed_mnemonic =\n+\t\t\t\teth_pcap_stats_missed_get(dev, 0);\n \t\tpcap_close(pp->tx_pcap[0]);\n \t\tpp->tx_pcap[0] = NULL;\n \t\tpp->rx_pcap[0] = NULL;\n@@ -641,6 +658,8 @@ eth_dev_stop(struct rte_eth_dev *dev)\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\tif (pp->rx_pcap[i] != NULL) {\n+\t\t\tinternals->rx_queue[i].rx_stat.missed_mnemonic =\n+\t\t\t\t\teth_pcap_stats_missed_get(dev, i);\n \t\t\tpcap_close(pp->rx_pcap[i]);\n \t\t\tpp->rx_pcap[i] = NULL;\n \t\t}\n@@ -685,6 +704,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n \tunsigned int i;\n \tunsigned long rx_packets_total = 0, rx_bytes_total = 0;\n+\tunsigned long rx_missed_total = 0;\n \tunsigned long tx_packets_total = 0, tx_bytes_total = 0;\n \tunsigned long tx_packets_err_total = 0;\n \tconst struct pmd_internals *internal = dev->data->dev_private;\n@@ -695,6 +715,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \t\tstats->q_ibytes[i] = internal->rx_queue[i].rx_stat.bytes;\n \t\trx_packets_total += stats->q_ipackets[i];\n \t\trx_bytes_total += stats->q_ibytes[i];\n+\t\tunsigned long rx_missed = eth_pcap_stats_missed_get(dev, i) +\n+\t\t\t\tinternal->rx_queue[i].rx_stat.missed_mnemonic -\n+\t\t\t\tinternal->rx_queue[i].rx_stat.missed_reset;\n+\t\trx_missed_total += rx_missed;\n \t}\n \n \tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n@@ -708,6 +732,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \tstats->ipackets = rx_packets_total;\n \tstats->ibytes = rx_bytes_total;\n+\tstats->imissed = rx_missed_total;\n \tstats->opackets = tx_packets_total;\n \tstats->obytes = tx_bytes_total;\n \tstats->oerrors = tx_packets_err_total;\n@@ -724,6 +749,9 @@ eth_stats_reset(struct rte_eth_dev *dev)\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\tinternal->rx_queue[i].rx_stat.pkts = 0;\n \t\tinternal->rx_queue[i].rx_stat.bytes = 0;\n+\t\tinternal->rx_queue[i].rx_stat.missed_reset =\n+\t\t\t\teth_pcap_stats_missed_get(dev, i);\n+\t\tinternal->rx_queue[i].rx_stat.missed_mnemonic = 0;\n \t}\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n", "prefixes": [ "v2" ] }