Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87427/?format=api
{ "id": 87427, "url": "http://patches.dpdk.org/api/patches/87427/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-21-lironh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127160948.6008-21-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-21-lironh@marvell.com", "date": "2021-01-27T16:09:34", "name": "[v3,20/34] net/mvpp2: flow: add support for RAW type", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4af2a096cb89ebe091cc3999d004adeee0b2da11", "submitter": { "id": 996, "url": "http://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-21-lironh@marvell.com/mbox/", "series": [ { "id": 14976, "url": "http://patches.dpdk.org/api/series/14976/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14976", "date": "2021-01-27T16:09:14", "name": "net/mvpp2: misc updates", "version": 3, "mbox": "http://patches.dpdk.org/series/14976/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87427/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DDF4A052A;\n\tWed, 27 Jan 2021 17:14:17 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6B091140F3F;\n\tWed, 27 Jan 2021 17:10:46 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 4B0AB140F37\n for <dev@dpdk.org>; Wed, 27 Jan 2021 17:10:43 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG5dYm027128; Wed, 27 Jan 2021 08:10:42 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 368j1uc39g-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:10:42 -0800", "from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:41 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH01.marvell.com\n (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:40 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:10:39 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=YBvAKB+GWKp5n2/rsmS1bGu1mesxQZ7fFQlAsOstOQI=;\n b=AV0qhHUEkrL3tNHrdUP14dv/JPdZqsYbOyHVFpyMXGjTyD3sU4G1ThCbt7qqV0XbxKRs\n YVNFCmkZ8aYDHnalGvUnX14io3ZQPOo1Bgka6hABh2ymj9MNLvW3yYXCfuA3j3jQc+jH\n kaomtxmtinnk3YmvA0iJeqFFELSpprHxLhtm2neMubZFdzcuJ23VxUDOO+b/lleED/nQ\n 7DNrIhOgkP0Fj11xNucGbiypdznOprfWxlxJ/LM2fVu5b6qMnjYdVWJD2+M2WEjEYOZi\n WDP3MsoY6FRquiucH6QE5k+VtB795sS+UC7Y4pZ0iiFgJd9siKkE5/HCEV6B26p0KOIR PA==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Liron Himi <lironh@marvell.com>", "Date": "Wed, 27 Jan 2021 18:09:34 +0200", "Message-ID": "<20210127160948.6008-21-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>", "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 20/34] net/mvpp2: flow: add support for RAW\n type", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nAdd support for RAW type and connect it to MUSDK UDF\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.h | 1 +\n drivers/net/mvpp2/mrvl_flow.c | 141 ++++++++++++++++++++++++++++++++\n 2 files changed, 142 insertions(+)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h\nindex 8be7603d4a..27d34ecfe0 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.h\n+++ b/drivers/net/mvpp2/mrvl_ethdev.h\n@@ -92,6 +92,7 @@ struct rte_flow {\n \tstruct pp2_cls_tbl_rule rule;\n \tstruct pp2_cls_cos_desc cos;\n \tstruct pp2_cls_tbl_action action;\n+\tuint8_t next_udf_id;\n };\n \n struct mrvl_mtr_profile {\ndiff --git a/drivers/net/mvpp2/mrvl_flow.c b/drivers/net/mvpp2/mrvl_flow.c\nindex ffa47a12ec..3c8052f069 100644\n--- a/drivers/net/mvpp2/mrvl_flow.c\n+++ b/drivers/net/mvpp2/mrvl_flow.c\n@@ -1196,6 +1196,146 @@ mrvl_parse_udp(const struct rte_flow_item *item,\n \treturn -rte_errno;\n }\n \n+static int\n+mrvl_string_to_hex_values(const uint8_t *input_string,\n+\t\t\t uint8_t *hex_key,\n+\t\t\t uint8_t *length)\n+{\n+\tchar tmp_arr[3], tmp_string[MRVL_CLS_STR_SIZE_MAX], *string_iter;\n+\tint i;\n+\n+\tstrcpy(tmp_string, (const char *)input_string);\n+\tstring_iter = tmp_string;\n+\n+\tstring_iter += 2; /* skip the '0x' */\n+\t*length = ((*length - 2) + 1) / 2;\n+\n+\tfor (i = 0; i < *length; i++) {\n+\t\tstrncpy(tmp_arr, string_iter, 2);\n+\t\ttmp_arr[2] = '\\0';\n+\t\tif (get_val_securely8(tmp_arr, 16,\n+\t\t\t\t &hex_key[*length - 1 - i]) < 0)\n+\t\t\treturn -1;\n+\t\tstring_iter += 2;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * Parse raw flow item.\n+ *\n+ * @param item Pointer to the flow item.\n+ * @param flow Pointer to the flow.\n+ * @param error Pointer to the flow error.\n+ * @returns 0 on success, negative value otherwise.\n+ */\n+static int\n+mrvl_parse_raw(const struct rte_flow_item *item,\n+\t struct rte_flow *flow,\n+\t struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item_raw *spec = NULL, *mask = NULL;\n+\tstruct pp2_cls_rule_key_field *key_field;\n+\tstruct mv_net_udf *udf_params;\n+\tuint8_t length;\n+\tint ret;\n+\n+\tret = mrvl_parse_init(item, (const void **)&spec, (const void **)&mask,\n+\t\t\t &rte_flow_item_raw_mask,\n+\t\t\t sizeof(struct rte_flow_item_raw), error);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tif (!spec->pattern) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"pattern pointer MUST be given\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\t/* Only hex string is supported; so, it must start with '0x' */\n+\tif (strncmp((const char *)spec->pattern, \"0x\", 2) != 0) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'pattern' string must start with '0x'\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (mask->pattern &&\n+\t strncmp((const char *)mask->pattern, \"0x\", 2) != 0) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'mask-pattern' string must start with '0x'\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (mask->search && spec->search) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'search' option must be '0'\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (mask->offset && spec->offset != 0) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'offset' option must be '0'\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tif (!mask->relative || !spec->relative) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'relative' option must be given and enabled\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tlength = spec->length & mask->length;\n+\tif (!length) {\n+\t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL, \"'length' option must be given bigger than '0'\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\n+\tkey_field = &flow->rule.fields[flow->rule.num_fields];\n+\tmrvl_alloc_key_mask(key_field);\n+\n+\t/* pattern and length refer to string bytes. we need to convert it to\n+\t * values.\n+\t */\n+\tkey_field->size = length;\n+\tret = mrvl_string_to_hex_values(spec->pattern, key_field->key,\n+\t\t\t\t\t&key_field->size);\n+\tif (ret) {\n+\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t NULL,\n+\t\t\t\t \"can't convert pattern from string to hex\\n\");\n+\t\treturn -rte_errno;\n+\t}\n+\tif (mask->pattern) {\n+\t\tret = mrvl_string_to_hex_values(mask->pattern, key_field->mask,\n+\t\t\t\t\t\t&length);\n+\t\tif (ret) {\n+\t\t\trte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM_SPEC,\n+\t\t\t\t\t NULL,\n+\t\t\t\t\t \"can't convert mask-pattern from string to hex\\n\");\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t} else {\n+\t\trte_free(key_field->mask);\n+\t\tkey_field->mask = NULL;\n+\t}\n+\n+\tflow->table_key.proto_field[flow->rule.num_fields].proto =\n+\t\tMV_NET_UDF;\n+\tudf_params =\n+\t\t&flow->table_key.proto_field[flow->rule.num_fields].field.udf;\n+\tudf_params->id = flow->next_udf_id++;\n+\tudf_params->size = key_field->size;\n+\tflow->table_key.key_size += key_field->size;\n+\n+\tflow->rule.num_fields += 1;\n+\n+\treturn 0;\n+}\n+\n /**\n * Structure used to map specific flow pattern to the pattern parse callback\n * which will iterate over each pattern item and extract relevant data.\n@@ -1212,6 +1352,7 @@ static const struct {\n \t{ RTE_FLOW_ITEM_TYPE_IPV6, mrvl_parse_ip6 },\n \t{ RTE_FLOW_ITEM_TYPE_TCP, mrvl_parse_tcp },\n \t{ RTE_FLOW_ITEM_TYPE_UDP, mrvl_parse_udp },\n+\t{ RTE_FLOW_ITEM_TYPE_RAW, mrvl_parse_raw },\n \t{ RTE_FLOW_ITEM_TYPE_END, NULL }\n };\n \n", "prefixes": [ "v3", "20/34" ] }