Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 87416,
    "url": "http://patches.dpdk.org/api/patches/87416/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-10-lironh@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210127160948.6008-10-lironh@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-10-lironh@marvell.com",
    "date": "2021-01-27T16:09:23",
    "name": "[v3,09/34] net/mvpp2: save initial configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "bd06ff11f82fa450460fc00298171062cfda140c",
    "submitter": {
        "id": 996,
        "url": "http://patches.dpdk.org/api/people/996/?format=api",
        "name": "Liron Himi",
        "email": "lironh@marvell.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-10-lironh@marvell.com/mbox/",
    "series": [
        {
            "id": 14976,
            "url": "http://patches.dpdk.org/api/series/14976/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14976",
            "date": "2021-01-27T16:09:14",
            "name": "net/mvpp2: misc updates",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/14976/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/87416/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/87416/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 235B0A052A;\n\tWed, 27 Jan 2021 17:12:03 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 413C9140EF5;\n\tWed, 27 Jan 2021 17:10:24 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8185F140EED\n for <dev@dpdk.org>; Wed, 27 Jan 2021 17:10:21 +0100 (CET)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG62La017168; Wed, 27 Jan 2021 08:10:20 -0800",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 36b1xphfsp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:10:20 -0800",
            "from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:18 -0800",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:18 -0800",
            "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:10:16 -0800"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=tLMbT5NgQDhaE1jOjVaaNovDijCuYPcNqqe8VLYXm0Y=;\n b=ARt+3SWD4lIOY7GKIA0rxYAxw5MmeZCAYBSrhvAOLdX1OXsnN+yTvkP23FcrfiHE1Zb1\n yGareKSKRVEV4EOzFtkui1RvxlNaZcfIFiOO/qNfI1H6vTbVxsc8DCRHdo3eTYL8k5QS\n /+2rlwy8oVmxf0XuYoun1c4/7pPCOS7dVJjsEQ2lRV2HMmAhevP/U66Mk67lViFV62gm\n 5AhF4T72LrHnUDe29k16TSu3pa9iu7h183V4PTBacu2ALOec+cIizI3Zmf4O/HlY292v\n x+Z7U9FRkFu0fdINKXr8CBd7U++tACCTU4hOs+6UdmqcULFcob2TjfRD+nG288Np9zB0 dg==",
        "From": "<lironh@marvell.com>",
        "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>",
        "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>",
        "Date": "Wed, 27 Jan 2021 18:09:23 +0200",
        "Message-ID": "<20210127160948.6008-10-lironh@marvell.com>",
        "X-Mailer": "git-send-email 2.28.0",
        "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>",
        "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0",
        "Subject": "[dpdk-dev] [PATCH v3 09/34] net/mvpp2: save initial configuration",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nSave configuration that was done prior 'start' as\nonly then the ppio is being configured.\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 101 +++++++++++++++++++++++++++-----\n 1 file changed, 87 insertions(+), 14 deletions(-)",
    "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex a1a3c2301c..f079939d8c 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright(c) 2017 Marvell International Ltd.\n- * Copyright(c) 2017 Semihalf.\n+ * Copyright(c) 2017-2021 Marvell International Ltd.\n+ * Copyright(c) 2017-2021 Semihalf.\n  * All rights reserved.\n  */\n \n@@ -146,6 +146,15 @@ static int rte_pmd_mrvl_remove(struct rte_vdev_device *vdev);\n static void mrvl_deinit_pp2(void);\n static void mrvl_deinit_hifs(void);\n \n+static int\n+mrvl_mac_addr_add(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr,\n+\t\t  uint32_t index, uint32_t vmdq __rte_unused);\n+static int\n+mrvl_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr);\n+static int\n+mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on);\n+static int mrvl_promiscuous_enable(struct rte_eth_dev *dev);\n+static int mrvl_allmulticast_enable(struct rte_eth_dev *dev);\n \n #define MRVL_XSTATS_TBL_ENTRY(name) { \\\n \t#name, offsetof(struct pp2_ppio_statistics, name),\t\\\n@@ -403,7 +412,7 @@ mrvl_dev_configure(struct rte_eth_dev *dev)\n \t}\n \n \treturn mrvl_configure_rss(priv,\n-\t\t\t\t  &dev->data->dev_conf.rx_adv_conf.rss_conf);\n+\t\t\t&dev->data->dev_conf.rx_adv_conf.rss_conf);\n }\n \n /**\n@@ -490,8 +499,10 @@ mrvl_dev_set_link_up(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tint ret;\n \n-\tif (!priv->ppio)\n-\t\treturn -EPERM;\n+\tif (!priv->ppio) {\n+\t\tdev->data->dev_link.link_status = ETH_LINK_UP;\n+\t\treturn 0;\n+\t}\n \n \tret = pp2_ppio_enable(priv->ppio);\n \tif (ret)\n@@ -505,10 +516,13 @@ mrvl_dev_set_link_up(struct rte_eth_dev *dev)\n \t * Set mtu to default DPDK value here.\n \t */\n \tret = mrvl_mtu_set(dev, dev->data->mtu);\n-\tif (ret)\n+\tif (ret) {\n \t\tpp2_ppio_disable(priv->ppio);\n+\t\treturn ret;\n+\t}\n \n-\treturn ret;\n+\tdev->data->dev_link.link_status = ETH_LINK_UP;\n+\treturn 0;\n }\n \n /**\n@@ -524,11 +538,18 @@ static int\n mrvl_dev_set_link_down(struct rte_eth_dev *dev)\n {\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n+\tint ret;\n \n-\tif (!priv->ppio)\n-\t\treturn -EPERM;\n+\tif (!priv->ppio) {\n+\t\tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n+\t\treturn 0;\n+\t}\n+\tret = pp2_ppio_disable(priv->ppio);\n+\tif (ret)\n+\t\treturn ret;\n \n-\treturn pp2_ppio_disable(priv->ppio);\n+\tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n+\treturn 0;\n }\n \n /**\n@@ -610,6 +631,9 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tstruct mrvl_priv *priv = dev->data->dev_private;\n \tchar match[MRVL_MATCH_LEN];\n \tint ret = 0, i, def_init_size;\n+\tuint32_t j;\n+\tstruct rte_vlan_filter_conf *vfc;\n+\tstruct rte_ether_addr *mac_addr;\n \n \tif (priv->ppio)\n \t\treturn mrvl_dev_set_link_up(dev);\n@@ -675,6 +699,47 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \tif (ret)\n \t\tMRVL_LOG(ERR, \"Failed to set MTU to %d\", dev->data->mtu);\n \n+\tif (!rte_is_zero_ether_addr(&dev->data->mac_addrs[0]))\n+\t\tmrvl_mac_addr_set(dev, &dev->data->mac_addrs[0]);\n+\n+\tfor (i = 1; i < MRVL_MAC_ADDRS_MAX; i++) {\n+\t\tmac_addr = &dev->data->mac_addrs[i];\n+\n+\t\t/* skip zero address */\n+\t\tif (rte_is_zero_ether_addr(mac_addr))\n+\t\t\tcontinue;\n+\n+\t\tmrvl_mac_addr_add(dev, mac_addr, i, 0);\n+\t}\n+\n+\tif (dev->data->all_multicast == 1)\n+\t\tmrvl_allmulticast_enable(dev);\n+\n+\tvfc = &dev->data->vlan_filter_conf;\n+\tfor (j = 0; j < RTE_DIM(vfc->ids); j++) {\n+\t\tuint64_t vlan;\n+\t\tuint64_t vbit;\n+\t\tuint64_t ids = vfc->ids[j];\n+\n+\t\tif (ids == 0)\n+\t\t\tcontinue;\n+\n+\t\twhile (ids) {\n+\t\t\tvlan = 64 * j;\n+\t\t\t/* count trailing zeroes */\n+\t\t\tvbit = ~ids & (ids - 1);\n+\t\t\t/* clear least significant bit set */\n+\t\t\tids ^= (ids ^ (ids - 1)) ^ vbit;\n+\t\t\tfor (; vbit; vlan++)\n+\t\t\t\tvbit >>= 1;\n+\t\t\tret = mrvl_vlan_filter_set(dev, vlan, 1);\n+\t\t\tif (ret) {\n+\t\t\t\tMRVL_LOG(ERR, \"Failed to setup VLAN filter\\n\");\n+\t\t\t\tgoto out;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \t/* For default QoS config, don't start classifier. */\n \tif (mrvl_qos_cfg  &&\n \t    mrvl_qos_cfg->port[dev->data->port_id].use_global_defaults == 0) {\n@@ -685,10 +750,16 @@ mrvl_dev_start(struct rte_eth_dev *dev)\n \t\t}\n \t}\n \n-\tret = mrvl_dev_set_link_up(dev);\n-\tif (ret) {\n-\t\tMRVL_LOG(ERR, \"Failed to set link up\");\n-\t\tgoto out;\n+\tif (dev->data->promiscuous == 1)\n+\t\tmrvl_promiscuous_enable(dev);\n+\n+\tif (dev->data->dev_link.link_status == ETH_LINK_UP) {\n+\t\tret = mrvl_dev_set_link_up(dev);\n+\t\tif (ret) {\n+\t\t\tMRVL_LOG(ERR, \"Failed to set link up\");\n+\t\t\tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n+\t\t\tgoto out;\n+\t\t}\n \t}\n \n \t/* start tx queues */\n@@ -2844,6 +2915,8 @@ mrvl_eth_dev_create(struct rte_vdev_device *vdev, const char *name)\n \teth_dev->dev_ops = &mrvl_ops;\n \teth_dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;\n \n+\teth_dev->data->dev_link.link_status = ETH_LINK_UP;\n+\n \trte_eth_dev_probing_finish(eth_dev);\n \treturn 0;\n out_free:\n",
    "prefixes": [
        "v3",
        "09/34"
    ]
}