Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87414/?format=api
http://patches.dpdk.org/api/patches/87414/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-8-lironh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127160948.6008-8-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-8-lironh@marvell.com", "date": "2021-01-27T16:09:21", "name": "[v3,07/34] net/mvpp2: cosmetic changes to cookie usage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a9c270fb3c388ca4350dc21d122cdad8087fd5e0", "submitter": { "id": 996, "url": "http://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-8-lironh@marvell.com/mbox/", "series": [ { "id": 14976, "url": "http://patches.dpdk.org/api/series/14976/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14976", "date": "2021-01-27T16:09:14", "name": "net/mvpp2: misc updates", "version": 3, "mbox": "http://patches.dpdk.org/series/14976/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87414/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87414/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B6E9CA052A;\n\tWed, 27 Jan 2021 17:11:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C0CAB140EEB;\n\tWed, 27 Jan 2021 17:10:19 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 54362140EE7\n for <dev@dpdk.org>; Wed, 27 Jan 2021 17:10:18 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG69Rn017337; Wed, 27 Jan 2021 08:10:17 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 36b1xphfsc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:10:16 -0800", "from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:15 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com\n (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:14 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:10:12 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=GB69AnbNiV60YecJTvJ0IymUaNyB4wWLsRztQqirbwY=;\n b=kgEEQgVMqVLQCbfs1SgvPcQrWy2f3aRoBzyzSirhOiM5lWd+mczetm5+/AflIsjqn/aw\n pkquMGPR+M3y9F5F/jyhiUUuiI/QP2UZR1zHKsqqLH3hmE67M87x36g4f7YCpQV4MaQl\n 8CAD6/xHGC1zbt38YYVdKbFwcdnMeSrCiuN9hrV3ZB+mtBMwV8x7ZUPRqu3o48ktN6iL\n 9gayx0HXn1xTaYTw8ogcVZh7eCCT1JxM4lq0LVY1EP+pGRumoYKSYRSorO1gJHLRIT6e\n mrQH88ZVmlk10Kgm56+PwKe9+gU1HgqbvqXakQyWDg8uObq7Mr6lIgCAYoH0lP6S0Mnd bA==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>, Liron Himi\n <lironh@marvell.com>", "Date": "Wed, 27 Jan 2021 18:09:21 +0200", "Message-ID": "<20210127160948.6008-8-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>", "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 07/34] net/mvpp2: cosmetic changes to cookie\n usage", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yuri Chipchev <yuric@marvell.com>\n\nNo need to add high address to cookie on transmit side, as it has\nalready 64bit value\n\nSigned-off-by: Yuri Chipchev <yuric@marvell.com>\nReviewed-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex d5450d646e..68ad64cabc 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -1631,14 +1631,16 @@ mrvl_fill_bpool(struct mrvl_rxq *rxq, int num)\n \t\tif (((uint64_t)mbufs[i] & MRVL_COOKIE_HIGH_ADDR_MASK)\n \t\t\t!= cookie_addr_high) {\n \t\t\tMRVL_LOG(ERR,\n-\t\t\t\t\"mbuf virtual addr high 0x%lx out of range\",\n-\t\t\t\t(uint64_t)mbufs[i] >> 32);\n+\t\t\t\t\"mbuf virtual addr high is out of range \"\n+\t\t\t\t\"0x%x instead of 0x%x\\n\",\n+\t\t\t\t(uint32_t)((uint64_t)mbufs[i] >> 32),\n+\t\t\t\t(uint32_t)(cookie_addr_high >> 32));\n \t\t\tgoto out;\n \t\t}\n \n \t\tentries[i].buff.addr =\n \t\t\trte_mbuf_data_iova_default(mbufs[i]);\n-\t\tentries[i].buff.cookie = (uint64_t)mbufs[i];\n+\t\tentries[i].buff.cookie = (uintptr_t)mbufs[i];\n \t\tentries[i].bpool = bpool;\n \t}\n \n@@ -2438,8 +2440,7 @@ mrvl_free_sent_buffers(struct pp2_ppio *ppio, struct pp2_hif *hif,\n \t\tif (unlikely(!entry->bpool)) {\n \t\t\tstruct rte_mbuf *mbuf;\n \n-\t\t\tmbuf = (struct rte_mbuf *)\n-\t\t\t (cookie_addr_high | entry->buff.cookie);\n+\t\t\tmbuf = (struct rte_mbuf *)entry->buff.cookie;\n \t\t\trte_pktmbuf_free(mbuf);\n \t\t\tskip_bufs = 1;\n \t\t\tgoto skip;\n@@ -2548,7 +2549,7 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\tfor (i = nb_pkts; i < num; i++) {\n \t\t\tsq->head = (MRVL_PP2_TX_SHADOWQ_SIZE + sq->head - 1) &\n \t\t\t\tMRVL_PP2_TX_SHADOWQ_MASK;\n-\t\t\taddr = cookie_addr_high | sq->ent[sq->head].buff.cookie;\n+\t\t\taddr = sq->ent[sq->head].buff.cookie;\n \t\t\tbytes_sent -=\n \t\t\t\trte_pktmbuf_pkt_len((struct rte_mbuf *)addr);\n \t\t}\n", "prefixes": [ "v3", "07/34" ] }{ "id": 87414, "url": "