Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87409/?format=api
{ "id": 87409, "url": "http://patches.dpdk.org/api/patches/87409/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-3-lironh@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210127160948.6008-3-lironh@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210127160948.6008-3-lironh@marvell.com", "date": "2021-01-27T16:09:16", "name": "[v3,02/34] net/mvpp2: remove debug log on fast-path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7858bc2b0382e5bf221d6b857ec604f9166ace30", "submitter": { "id": 996, "url": "http://patches.dpdk.org/api/people/996/?format=api", "name": "Liron Himi", "email": "lironh@marvell.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210127160948.6008-3-lironh@marvell.com/mbox/", "series": [ { "id": 14976, "url": "http://patches.dpdk.org/api/series/14976/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14976", "date": "2021-01-27T16:09:14", "name": "net/mvpp2: misc updates", "version": 3, "mbox": "http://patches.dpdk.org/series/14976/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87409/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/87409/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A8AC4A052A;\n\tWed, 27 Jan 2021 17:10:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 391B6140EBF;\n\tWed, 27 Jan 2021 17:10:07 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 7800A140EB7;\n Wed, 27 Jan 2021 17:10:05 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 10RG62kg017155; Wed, 27 Jan 2021 08:10:04 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com with ESMTP id 36b1xphfrd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Wed, 27 Jan 2021 08:10:04 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 27 Jan 2021 08:10:02 -0800", "from pt-lxl0023.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 27 Jan 2021 08:10:00 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=r854GVyimH8HgitMkAFQdFqcigTy2A2zBwHPNqg4Qfo=;\n b=lQW4BliYR+krn05nw6IrKCct+00RmM3VqvHImb069FlFQoFjBiv0ih03tWZkCDyczX8N\n CVInaod+5NmxEDHa/IXsF9aNEECCiAGJ7MSH44ebV9Fdhd3kjbZwkCVtuDNJAz4UWNSD\n 6Iju3s0p9JgC9k6Gv23VUCX9p4UkJZ5Mau6hJOypGwYQwJhZdp4f7cIupYZbstgyPCEx\n dnQAni/HMSKq9cv4O6wR8f5JCMtl3b9Kf32hqVpM/vEnebOdD7r/J2AH9BqwGlFizRV5\n GNV3lD+4sKnEmuyNGE5QE5dSu7f0FN1LKFKzXjBruPuN9T7dg4fPSTVkpa4zPPIu0c8/ JQ==", "From": "<lironh@marvell.com>", "To": "<jerinj@marvell.com>, <ferruh.yigit@intel.com>", "CC": "<dev@dpdk.org>, Liron Himi <lironh@marvell.com>, <stable@dpdk.org>", "Date": "Wed, 27 Jan 2021 18:09:16 +0200", "Message-ID": "<20210127160948.6008-3-lironh@marvell.com>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20210127160948.6008-1-lironh@marvell.com>", "References": "<20210122191925.24308-1-lironh@marvell.com>\n <20210127160948.6008-1-lironh@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737\n definitions=2021-01-27_05:2021-01-27,\n 2021-01-27 signatures=0", "Subject": "[dpdk-dev] [PATCH v3 02/34] net/mvpp2: remove debug log on fast-path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Liron Himi <lironh@marvell.com>\n\nIn case of non-ip frame the current code reached the 'default'\ncase which result with function call to log a msg.\nthose kind of calls should not be performed on fast-path.\n\nThe performance for this kind of frames increased by 50%\n\nFixes: acab7d58c (\"net/mvpp2: convert to dynamic logging\")\nCc: stable@dpdk.org\n\nSigned-off-by: Liron Himi <lironh@marvell.com>\n---\n drivers/net/mvpp2/mrvl_ethdev.c | 27 ++++-----------------------\n 1 file changed, 4 insertions(+), 23 deletions(-)", "diff": "diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c\nindex 93fb30cdb8..bfe496ff74 100644\n--- a/drivers/net/mvpp2/mrvl_ethdev.c\n+++ b/drivers/net/mvpp2/mrvl_ethdev.c\n@@ -2171,7 +2171,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc,\n \t\t*l4_offset = *l3_offset + MRVL_ARP_LENGTH;\n \t\tbreak;\n \tdefault:\n-\t\tMRVL_LOG(DEBUG, \"Failed to recognise l3 packet type\");\n \t\tbreak;\n \t}\n \n@@ -2183,7 +2182,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_desc *desc,\n \t\tpacket_type |= RTE_PTYPE_L4_UDP;\n \t\tbreak;\n \tdefault:\n-\t\tMRVL_LOG(DEBUG, \"Failed to recognise l4 packet type\");\n \t\tbreak;\n \t}\n \n@@ -2253,10 +2251,9 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \n \tret = pp2_ppio_recv(q->priv->ppio, q->priv->rxq_map[q->queue_id].tc,\n \t\t\t q->priv->rxq_map[q->queue_id].inq, descs, &nb_pkts);\n-\tif (unlikely(ret < 0)) {\n-\t\tMRVL_LOG(ERR, \"Failed to receive packets\");\n+\tif (unlikely(ret < 0))\n \t\treturn 0;\n-\t}\n+\n \tmrvl_port_bpool_size[bpool->pp2_id][bpool->id][core_id] -= nb_pkts;\n \n \tfor (i = 0; i < nb_pkts; i++) {\n@@ -2319,21 +2316,13 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \n \t\tif (unlikely(num <= q->priv->bpool_min_size ||\n \t\t\t (!rx_done && num < q->priv->bpool_init_size))) {\n-\t\t\tret = mrvl_fill_bpool(q, MRVL_BURST_SIZE);\n-\t\t\tif (ret)\n-\t\t\t\tMRVL_LOG(ERR, \"Failed to fill bpool\");\n+\t\t\tmrvl_fill_bpool(q, MRVL_BURST_SIZE);\n \t\t} else if (unlikely(num > q->priv->bpool_max_size)) {\n \t\t\tint i;\n \t\t\tint pkt_to_remove = num - q->priv->bpool_init_size;\n \t\t\tstruct rte_mbuf *mbuf;\n \t\t\tstruct pp2_buff_inf buff;\n \n-\t\t\tMRVL_LOG(DEBUG,\n-\t\t\t\t\"port-%d:%d: bpool %d oversize - remove %d buffers (pool size: %d -> %d)\",\n-\t\t\t\tbpool->pp2_id, q->priv->ppio->port_id,\n-\t\t\t\tbpool->id, pkt_to_remove, num,\n-\t\t\t\tq->priv->bpool_init_size);\n-\n \t\t\tfor (i = 0; i < pkt_to_remove; i++) {\n \t\t\t\tret = pp2_bpool_get_buff(hif, bpool, &buff);\n \t\t\t\tif (ret)\n@@ -2526,12 +2515,8 @@ mrvl_tx_pkt_burst(void *txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\t sq, q->queue_id, 0);\n \n \tsq_free_size = MRVL_PP2_TX_SHADOWQ_SIZE - sq->size - 1;\n-\tif (unlikely(nb_pkts > sq_free_size)) {\n-\t\tMRVL_LOG(DEBUG,\n-\t\t\t\"No room in shadow queue for %d packets! %d packets will be sent.\",\n-\t\t\tnb_pkts, sq_free_size);\n+\tif (unlikely(nb_pkts > sq_free_size))\n \t\tnb_pkts = sq_free_size;\n-\t}\n \n \tfor (i = 0; i < nb_pkts; i++) {\n \t\tstruct rte_mbuf *mbuf = tx_pkts[i];\n@@ -2648,10 +2633,6 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx_pkts,\n \t\t */\n \t\tif (unlikely(total_descs > sq_free_size)) {\n \t\t\ttotal_descs -= nb_segs;\n-\t\t\tRTE_LOG(DEBUG, PMD,\n-\t\t\t\t\"No room in shadow queue for %d packets! \"\n-\t\t\t\t\"%d packets will be sent.\\n\",\n-\t\t\t\tnb_pkts, i);\n \t\t\tbreak;\n \t\t}\n \n", "prefixes": [ "v3", "02/34" ] }