Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/87077/?format=api
{ "id": 87077, "url": "http://patches.dpdk.org/api/patches/87077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-19-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210122094800.197748-19-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210122094800.197748-19-jiawenwu@trustnetic.com", "date": "2021-01-22T09:47:58", "name": "[v1,18/20] net/txgbe: hardware support for VF representor", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9803bee5c192f8cc5e7e671fe19031721ecf87cf", "submitter": { "id": 1932, "url": "http://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210122094800.197748-19-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 14902, "url": "http://patches.dpdk.org/api/series/14902/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14902", "date": "2021-01-22T09:47:41", "name": "net/txgbe: add VF driver support", "version": 1, "mbox": "http://patches.dpdk.org/series/14902/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/87077/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/87077/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11438A0A0A;\n\tFri, 22 Jan 2021 10:50:50 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5D478140EE7;\n\tFri, 22 Jan 2021 10:48:27 +0100 (CET)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id D1133140EC9\n for <dev@dpdk.org>; Fri, 22 Jan 2021 10:48:22 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Fri, 22 Jan 2021 17:48:17 +0800 (CST)" ], "X-QQ-mid": "bizesmtp9t1611308897t8qrdp9ww", "X-QQ-SSF": "01400000002000C0D000B00A0000000", "X-QQ-FEAT": "e/yCVNqw6UK62VcFqQta3Qi6PN/DJ9d13MwBYxDuLoz6Ds5vwnOlR4rQHXZyH\n OX5GhXsoKpK/gF9b11ED6E5gOyyW4YaSh6/CX0JfLK0m3TLpYNNkYa1Q4JWhymXcgE+f83y\n UJoDS/9iBr7juQ/iJvNlxr2I73aUdKU3wP2RfSnZVWVSvC4wzHfa370ZLdBNYmbBXyg6xYj\n XYxIrGS9wYLx7IGfT9l6DjIAT0ogy6V+s/uFl8fgXUWZt4EK8n6HqoKvVIa8M2Q1sRg1wgJ\n 4Hobq6eUCXn1U9bJU3ke6sFoNHC23mEhnRpasuCk8jg4Odh4xoOpqsOJ9dc2eLUcPVYi3la\n pdAqrRtAdbehyNRJS+v9VHtjXkgZJK6vqv5EDLC", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Fri, 22 Jan 2021 17:47:58 +0800", "Message-Id": "<20210122094800.197748-19-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "References": "<20210122094800.197748-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v1 18/20] net/txgbe: hardware support for VF\n representor", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to get link status and set mac address for VF representor.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/meson.build | 1 +\n drivers/net/txgbe/rte_pmd_txgbe.c | 45 ++++++++++++++++++++++++\n drivers/net/txgbe/rte_pmd_txgbe.h | 17 +++++++++\n drivers/net/txgbe/txgbe_ethdev.c | 9 +++++\n drivers/net/txgbe/txgbe_ethdev.h | 2 ++\n drivers/net/txgbe/txgbe_vf_representor.c | 26 ++++++++++++++\n 6 files changed, 100 insertions(+)\n create mode 100644 drivers/net/txgbe/rte_pmd_txgbe.c", "diff": "diff --git a/drivers/net/txgbe/meson.build b/drivers/net/txgbe/meson.build\nindex f5391076e..142d47df2 100644\n--- a/drivers/net/txgbe/meson.build\n+++ b/drivers/net/txgbe/meson.build\n@@ -21,6 +21,7 @@ sources = files(\n \t'txgbe_rxtx.c',\n \t'txgbe_tm.c',\n \t'txgbe_vf_representor.c',\n+\t'rte_pmd_txgbe.c'\n )\n \n deps += ['hash', 'security']\ndiff --git a/drivers/net/txgbe/rte_pmd_txgbe.c b/drivers/net/txgbe/rte_pmd_txgbe.c\nnew file mode 100644\nindex 000000000..c84233bd6\n--- /dev/null\n+++ b/drivers/net/txgbe/rte_pmd_txgbe.c\n@@ -0,0 +1,45 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2015-2020\n+ */\n+\n+#include <rte_ethdev_driver.h>\n+\n+#include \"base/txgbe.h\"\n+#include \"txgbe_ethdev.h\"\n+#include \"rte_pmd_txgbe.h\"\n+\n+int\n+rte_pmd_txgbe_set_vf_mac_addr(uint16_t port, uint16_t vf,\n+\t\t\t struct rte_ether_addr *mac_addr)\n+{\n+\tstruct txgbe_hw *hw;\n+\tstruct txgbe_vf_info *vfinfo;\n+\tint rar_entry;\n+\tstruct rte_ether_addr *new_mac = mac_addr;\n+\tstruct rte_eth_dev *dev;\n+\tstruct rte_pci_device *pci_dev;\n+\n+\tRTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);\n+\n+\tdev = &rte_eth_devices[port];\n+\tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\n+\tif (!is_txgbe_supported(dev))\n+\t\treturn -ENOTSUP;\n+\n+\tif (vf >= pci_dev->max_vfs)\n+\t\treturn -EINVAL;\n+\n+\thw = TXGBE_DEV_HW(dev);\n+\tvfinfo = *(TXGBE_DEV_VFDATA(dev));\n+\trar_entry = hw->mac.num_rar_entries - (vf + 1);\n+\n+\tif (rte_is_valid_assigned_ether_addr(new_mac)) {\n+\t\trte_memcpy(vfinfo[vf].vf_mac_addresses, (uint8_t *)new_mac,\n+\t\t\t RTE_ETHER_ADDR_LEN);\n+\t\treturn hw->mac.set_rar(hw, rar_entry, (uint8_t *)new_mac, vf,\n+\t\t\t\t\t true);\n+\t}\n+\treturn -EINVAL;\n+}\n+\ndiff --git a/drivers/net/txgbe/rte_pmd_txgbe.h b/drivers/net/txgbe/rte_pmd_txgbe.h\nindex 51a316f6f..b994b476e 100644\n--- a/drivers/net/txgbe/rte_pmd_txgbe.h\n+++ b/drivers/net/txgbe/rte_pmd_txgbe.h\n@@ -15,6 +15,23 @@\n #include <rte_ethdev.h>\n #include <rte_ether.h>\n \n+/**\n+ * Set the VF MAC address.\n+ *\n+ * @param port\n+ * The port identifier of the Ethernet device.\n+ * @param vf\n+ * VF id.\n+ * @param mac_addr\n+ * VF MAC address.\n+ * @return\n+ * - (0) if successful.\n+ * - (-ENODEV) if *port* invalid.\n+ * - (-EINVAL) if *vf* or *mac_addr* is invalid.\n+ */\n+int rte_pmd_txgbe_set_vf_mac_addr(uint16_t port, uint16_t vf,\n+\t\tstruct rte_ether_addr *mac_addr);\n+\n /**\n * Response sent back to txgbe driver from user app after callback\n */\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex fb2ffb0e1..0fe8e3415 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -5186,6 +5186,15 @@ txgbe_clear_all_l2_tn_filter(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+bool\n+is_txgbe_supported(struct rte_eth_dev *dev)\n+{\n+\tif (strcmp(dev->device->driver->name, rte_txgbe_pmd.driver.name))\n+\t\treturn false;\n+\telse\n+\t\treturn true;\n+}\n+\n static const struct eth_dev_ops txgbe_eth_dev_ops = {\n \t.dev_configure = txgbe_dev_configure,\n \t.dev_infos_get = txgbe_dev_info_get,\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h\nindex a6fd39b7b..73ca975e7 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.h\n+++ b/drivers/net/txgbe/txgbe_ethdev.h\n@@ -723,6 +723,8 @@ void txgbe_dev_setup_link_alarm_handler(void *param);\n void txgbe_read_stats_registers(struct txgbe_hw *hw,\n \t\t\t struct txgbe_hw_stats *hw_stats);\n \n+bool is_txgbe_supported(struct rte_eth_dev *dev);\n+\n void txgbe_vlan_hw_filter_enable(struct rte_eth_dev *dev);\n void txgbe_vlan_hw_filter_disable(struct rte_eth_dev *dev);\n void txgbe_vlan_hw_strip_config(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/txgbe/txgbe_vf_representor.c b/drivers/net/txgbe/txgbe_vf_representor.c\nindex bee4957c4..87af9b34b 100644\n--- a/drivers/net/txgbe/txgbe_vf_representor.c\n+++ b/drivers/net/txgbe/txgbe_vf_representor.c\n@@ -10,6 +10,30 @@\n #include \"base/txgbe_vf.h\"\n #include \"txgbe_ethdev.h\"\n #include \"txgbe_rxtx.h\"\n+#include \"rte_pmd_txgbe.h\"\n+\n+static int\n+txgbe_vf_representor_link_update(struct rte_eth_dev *ethdev,\n+\tint wait_to_complete)\n+{\n+\tstruct txgbe_vf_representor *representor =\n+\t\t\tTXGBE_DEV_REPRESENTOR(ethdev);\n+\n+\treturn txgbe_dev_link_update_share(representor->pf_ethdev,\n+\t\twait_to_complete);\n+}\n+\n+static int\n+txgbe_vf_representor_mac_addr_set(struct rte_eth_dev *ethdev,\n+\tstruct rte_ether_addr *mac_addr)\n+{\n+\tstruct txgbe_vf_representor *representor =\n+\t\t\tTXGBE_DEV_REPRESENTOR(ethdev);\n+\n+\treturn rte_pmd_txgbe_set_vf_mac_addr(\n+\t\trepresentor->pf_ethdev->data->port_id,\n+\t\trepresentor->vf_id, mac_addr);\n+}\n \n static int\n txgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,\n@@ -59,6 +83,8 @@ txgbe_vf_representor_dev_infos_get(struct rte_eth_dev *ethdev,\n \n static const struct eth_dev_ops txgbe_vf_representor_dev_ops = {\n \t.dev_infos_get\t\t= txgbe_vf_representor_dev_infos_get,\n+\t.link_update\t\t= txgbe_vf_representor_link_update,\n+\t.mac_addr_set\t\t= txgbe_vf_representor_mac_addr_set,\n };\n \n static uint16_t\n", "prefixes": [ "v1", "18/20" ] }