Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86833/?format=api
{ "id": 86833, "url": "http://patches.dpdk.org/api/patches/86833/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-14-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118203508.1332-14-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118203508.1332-14-aboyer@pensando.io", "date": "2021-01-18T20:35:08", "name": "[13/13] net/ionic: fix address handling in transmit code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "26ac574b4b1b98f9bc125f57ef605a4df7b5d211", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-14-aboyer@pensando.io/mbox/", "series": [ { "id": 14820, "url": "http://patches.dpdk.org/api/series/14820/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14820", "date": "2021-01-18T20:34:55", "name": "net/ionic: fixes and optimizations", "version": 1, "mbox": "http://patches.dpdk.org/series/14820/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/86833/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/86833/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CD090A0A03;\n\tMon, 18 Jan 2021 21:37:07 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DDA93140EA6;\n\tMon, 18 Jan 2021 21:36:00 +0100 (CET)", "from mail-pj1-f53.google.com (mail-pj1-f53.google.com\n [209.85.216.53])\n by mails.dpdk.org (Postfix) with ESMTP id 8BC51140EBD\n for <dev@dpdk.org>; Mon, 18 Jan 2021 21:35:57 +0100 (CET)", "by mail-pj1-f53.google.com with SMTP id cq1so10289568pjb.4\n for <dev@dpdk.org>; Mon, 18 Jan 2021 12:35:57 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id g201sm795160pfb.81.2021.01.18.12.35.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Jan 2021 12:35:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=g3NiWdwLg9vTUwSHmEQgrP78GNOtC7XVo7532k4wI0Y=;\n b=UBzDW58uqEJtYt1FGcHAUbWd8cMAjRYTkL1boxiYFRRKe6BVPqWxz5A2YX0CVkHgzP\n pmER+NECaG5siudMOfFFvVOIyukDKuPLfhrFnVSZ7zcQjQIfPs3IpCb+AQXrQJqNAUmx\n 5w3LpjNlw8FSf51LFim/BFf4GmPRIdVwPWiuvYfcOMIqp2jzduiW8xEYTglrIEhLoqIx\n tNGD+pBu9ELOtqhkVwBdu2smz9Bn7zIbHYMhtdj6KQpYcr7Bj23FUhQtmYMJuEJgZTB9\n 8LVglLgiWLUX6wB546Rrck2xT6ZwXl+cL4GhoYVpfFkL5bleB7HVCAX5Rivm0tib3jTH\n OWoA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=g3NiWdwLg9vTUwSHmEQgrP78GNOtC7XVo7532k4wI0Y=;\n b=iDCGqcKzQ4pzVM7e95ClgRE9H4Es3aBRfBq4VP0BoBmV9v/n7f5cdfOnI03dCINyXx\n nem7fRmNgzOp+RcU/Rb8izCZjsbjyduiNjFvGvU8xS0kWsofeBKwOv3+VmXRzqTv94gS\n uKQysWBbk4JLQFiXC/O6Ir6cse8x7Zu3abDP0CtjqY4re7mjc8OPJ/F+CQAvsuEc23x9\n R1DyiKMPr7+a3FZEAm9xVUEeHEjax6Tx6pMchdVq6f7ZZYMqzv/OD2iWlOL8GyvzK7MQ\n WKhXXQ7mdqgtXSG1mFB48ycSicsXG6f/jqdGbUIGXREG3Vxyp89UvFztEoWz1C2O4lHe\n +reg==", "X-Gm-Message-State": "AOAM530HT2WM822WPbs1VQbbtl1k2b2f9lFWCKglsLFbxvL9DSymFH8Z\n p0J4LxXZ8qXnh68M8boEWQY4Ilut8lwMSg==", "X-Google-Smtp-Source": "\n ABdhPJw2D8WT5erjx4Xqu8AuhmJgrqFk88X1Bhh6FrNQNg7c8SpaOXWmkC7LCvEeneUUImYIcUFSbA==", "X-Received": "by 2002:a17:90b:513:: with SMTP id\n r19mr1192547pjz.38.1611002156614;\n Mon, 18 Jan 2021 12:35:56 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>, stable@dpdk.org", "Date": "Mon, 18 Jan 2021 12:35:08 -0800", "Message-Id": "<20210118203508.1332-14-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118203508.1332-1-aboyer@pensando.io>", "References": "<20210118203508.1332-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 13/13] net/ionic: fix address handling in\n transmit code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Don't assume standard headroom.\nUse helper variables to improve readability.\n\nFixes: a27d901331da (\"net/ionic: add Rx and Tx handling\")\nCc: stable@dpdk.org\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_rxtx.c | 20 ++++++++++++--------\n 1 file changed, 12 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex f49a7cdb0e..b8b3364d11 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -334,7 +334,8 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \tstruct ionic_txq_desc *desc;\n \tstruct ionic_txq_sg_elem *elem;\n \tstruct rte_mbuf *txm_seg;\n-\tuint64_t desc_addr = 0;\n+\trte_iova_t data_iova;\n+\tuint64_t desc_addr = 0, next_addr;\n \tuint16_t desc_len = 0;\n \tuint8_t desc_nsge;\n \tuint32_t hdrlen;\n@@ -371,6 +372,7 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \n \tseglen = hdrlen + mss;\n \tleft = txm->data_len;\n+\tdata_iova = rte_mbuf_data_iova(txm);\n \n \tdesc = ionic_tx_tso_next(q, &elem);\n \tstart = true;\n@@ -380,7 +382,7 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \twhile (left > 0) {\n \t\tlen = RTE_MIN(seglen, left);\n \t\tfrag_left = seglen - len;\n-\t\tdesc_addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(txm));\n+\t\tdesc_addr = rte_cpu_to_le_64(data_iova + offset);\n \t\tdesc_len = len;\n \t\tdesc_nsge = 0;\n \t\tleft -= len;\n@@ -404,24 +406,23 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \ttxm_seg = txm->next;\n \twhile (txm_seg != NULL) {\n \t\toffset = 0;\n+\t\tdata_iova = rte_mbuf_data_iova(txm_seg);\n \t\tleft = txm_seg->data_len;\n \t\tstats->frags++;\n \n \t\twhile (left > 0) {\n-\t\t\trte_iova_t data_iova;\n-\t\t\tdata_iova = rte_mbuf_data_iova(txm_seg);\n-\t\t\telem->addr = rte_cpu_to_le_64(data_iova) + offset;\n+\t\t\tnext_addr = rte_cpu_to_le_64(data_iova + offset);\n \t\t\tif (frag_left > 0) {\n \t\t\t\tlen = RTE_MIN(frag_left, left);\n \t\t\t\tfrag_left -= len;\n+\t\t\t\telem->addr = next_addr;\n \t\t\t\telem->len = len;\n \t\t\t\telem++;\n \t\t\t\tdesc_nsge++;\n \t\t\t} else {\n \t\t\t\tlen = RTE_MIN(mss, left);\n \t\t\t\tfrag_left = mss - len;\n-\t\t\t\tdata_iova = rte_mbuf_data_iova(txm_seg);\n-\t\t\t\tdesc_addr = rte_cpu_to_le_64(data_iova);\n+\t\t\t\tdesc_addr = next_addr;\n \t\t\t\tdesc_len = len;\n \t\t\t\tdesc_nsge = 0;\n \t\t\t}\n@@ -429,6 +430,7 @@ ionic_tx_tso(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \t\t\toffset += len;\n \t\t\tif (txm_seg->next != NULL && frag_left > 0)\n \t\t\t\tcontinue;\n+\n \t\t\tdone = (txm_seg->next == NULL && left == 0);\n \t\t\tionic_tx_tso_post(q, desc, txm_seg,\n \t\t\t\tdesc_addr, desc_nsge, desc_len,\n@@ -463,7 +465,7 @@ ionic_tx(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \tbool encap;\n \tbool has_vlan;\n \tuint64_t ol_flags = txm->ol_flags;\n-\tuint64_t addr = rte_cpu_to_le_64(rte_mbuf_data_iova_default(txm));\n+\tuint64_t addr;\n \tuint8_t opcode = IONIC_TXQ_DESC_OPCODE_CSUM_NONE;\n \tuint8_t flags = 0;\n \n@@ -493,6 +495,8 @@ ionic_tx(struct ionic_qcq *txq, struct rte_mbuf *txm,\n \tflags |= has_vlan ? IONIC_TXQ_DESC_FLAG_VLAN : 0;\n \tflags |= encap ? IONIC_TXQ_DESC_FLAG_ENCAP : 0;\n \n+\taddr = rte_cpu_to_le_64(rte_mbuf_data_iova(txm));\n+\n \tdesc->cmd = encode_txq_desc_cmd(opcode, flags, txm->nb_segs - 1, addr);\n \tdesc->len = txm->data_len;\n \tdesc->vlan_tci = txm->vlan_tci;\n", "prefixes": [ "13/13" ] }