Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86828/?format=api
{ "id": 86828, "url": "http://patches.dpdk.org/api/patches/86828/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-9-aboyer@pensando.io/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210118203508.1332-9-aboyer@pensando.io>", "list_archive_url": "https://inbox.dpdk.org/dev/20210118203508.1332-9-aboyer@pensando.io", "date": "2021-01-18T20:35:03", "name": "[08/13] net/ionic: inline queue space function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9bb52f1142858df5708a6daf8dade07f25693474", "submitter": { "id": 2036, "url": "http://patches.dpdk.org/api/people/2036/?format=api", "name": "Andrew Boyer", "email": "aboyer@pensando.io" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210118203508.1332-9-aboyer@pensando.io/mbox/", "series": [ { "id": 14820, "url": "http://patches.dpdk.org/api/series/14820/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14820", "date": "2021-01-18T20:34:55", "name": "net/ionic: fixes and optimizations", "version": 1, "mbox": "http://patches.dpdk.org/series/14820/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/86828/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/86828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F2038A0A03;\n\tMon, 18 Jan 2021 21:36:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F2D80140E72;\n\tMon, 18 Jan 2021 21:35:49 +0100 (CET)", "from mail-pj1-f44.google.com (mail-pj1-f44.google.com\n [209.85.216.44])\n by mails.dpdk.org (Postfix) with ESMTP id 7525D140E6B\n for <dev@dpdk.org>; Mon, 18 Jan 2021 21:35:48 +0100 (CET)", "by mail-pj1-f44.google.com with SMTP id l23so10619146pjg.1\n for <dev@dpdk.org>; Mon, 18 Jan 2021 12:35:48 -0800 (PST)", "from driver-dev1.pensando.io ([12.226.153.42])\n by smtp.gmail.com with ESMTPSA id g201sm795160pfb.81.2021.01.18.12.35.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 18 Jan 2021 12:35:47 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=24BP+Q67kN0eDqxDt+Vaw15W8iDoxXsAhj9vupDR0os=;\n b=No08ayfaC/Dzq0KrUvynPlEojm1pGI0tZgE4akuL58N5lhexos8qWIKEVhFym7L9a4\n iMsUrMmjoCNItHRe4+mMSiEqV2As+4P3+jVkNEUEEefcS7qtChhAtqdl7J/E2TYD44uw\n CRlOrUbu8PIC/Eex2rtQ7fozhowIMM3aZED0YKEG5bHSGTrboMP20o82UQAM9lpYlE3/\n GLdUMqTB/k1Hwr4jrg/g4hHkV816sUhmLfjoqA7BfWaqKpuvU1zYrzGBCWo+bZAHKPeg\n yRuBR1bH28W0cqWnxIFXh/606ncS0PDEIuqBLo+6bDW6PTv0eAzbSdxwF16Ib5G15trG\n K1Jg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=24BP+Q67kN0eDqxDt+Vaw15W8iDoxXsAhj9vupDR0os=;\n b=EJJNrBkw/In8pAMGKqUbjFeeKC0NBkg2gSH/xvyo4ryz6wU6ITvNkl8aridE15z5NZ\n pPE4XjNUHOf2DFyxxVlqP9ykpKZKLopXUKhBqW8Hzro4W22QS3o23NGSPhjxi10u+hP7\n AMYWCweUk4fk2xcyprBAyHmIcm2yloY5/dmsGwEBShV6ee0esHzc8Kkj+bJy7QTxoTiY\n ZYSes1btPk0RkGaF5/kJOmp8SopJZXpcRIuDQlGIwR0OmIgl4ggLk1b5yPdpID/OQvfW\n tWnaU94V+zgSpZuwnpKvwdF0EeStxS0tPbHNb1JUl0wPQCcnNKANiRgPDdqG1aSYE2Xf\n Q/XA==", "X-Gm-Message-State": "AOAM533RONevHNXvjTKfy3Ppr5CNVbugG7GryJxkL5QoNWryq+mdcss9\n G7I+t9cxgQJJNAQseVbOhutk+z7AjObh/g==", "X-Google-Smtp-Source": "\n ABdhPJzj49OrvZYUWhyrs/TYS4t5yLn5kZ4fZENhCgjtCYLgAIqJsmybFRmbg518Ux3ZR9YY/Z2ENg==", "X-Received": "by 2002:a17:90a:12c4:: with SMTP id\n b4mr1126827pjg.98.1611002147507;\n Mon, 18 Jan 2021 12:35:47 -0800 (PST)", "From": "Andrew Boyer <aboyer@pensando.io>", "To": "dev@dpdk.org", "Cc": "Alfredo Cardigliano <cardigliano@ntop.org>,\n Andrew Boyer <aboyer@pensando.io>", "Date": "Mon, 18 Jan 2021 12:35:03 -0800", "Message-Id": "<20210118203508.1332-9-aboyer@pensando.io>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210118203508.1332-1-aboyer@pensando.io>", "References": "<20210118203508.1332-1-aboyer@pensando.io>", "Subject": "[dpdk-dev] [PATCH 08/13] net/ionic: inline queue space function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is a hot-path function.\nRemove ionic_q_has_space() while here.\n\nSigned-off-by: Andrew Boyer <aboyer@pensando.io>\n---\n drivers/net/ionic/ionic_dev.c | 21 +--------------------\n drivers/net/ionic/ionic_dev.h | 15 +++++++++++++--\n 2 files changed, 14 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/ionic/ionic_dev.c b/drivers/net/ionic/ionic_dev.c\nindex fcb3df482a..e847741632 100644\n--- a/drivers/net/ionic/ionic_dev.c\n+++ b/drivers/net/ionic/ionic_dev.c\n@@ -474,25 +474,6 @@ ionic_q_post(struct ionic_queue *q, bool ring_doorbell, desc_cb cb,\n \t\tionic_q_flush(q);\n }\n \n-uint32_t\n-ionic_q_space_avail(struct ionic_queue *q)\n-{\n-\tuint32_t avail = q->tail_idx;\n-\n-\tif (q->head_idx >= avail)\n-\t\tavail += q->num_descs - q->head_idx - 1;\n-\telse\n-\t\tavail -= q->head_idx + 1;\n-\n-\treturn avail;\n-}\n-\n-bool\n-ionic_q_has_space(struct ionic_queue *q, uint32_t want)\n-{\n-\treturn ionic_q_space_avail(q) >= want;\n-}\n-\n void\n ionic_q_service(struct ionic_queue *q, uint32_t cq_desc_index,\n \t\tuint32_t stop_index, void *service_cb_arg)\n@@ -561,7 +542,7 @@ ionic_adminq_post(struct ionic_lif *lif, struct ionic_admin_ctx *ctx)\n \n \trte_spinlock_lock(&lif->adminq_lock);\n \n-\tif (!ionic_q_has_space(adminq, 1)) {\n+\tif (ionic_q_space_avail(adminq) < 1) {\n \t\terr = -ENOSPC;\n \t\tgoto err_out;\n \t}\ndiff --git a/drivers/net/ionic/ionic_dev.h b/drivers/net/ionic/ionic_dev.h\nindex 55a56434fd..8847d6cad4 100644\n--- a/drivers/net/ionic/ionic_dev.h\n+++ b/drivers/net/ionic/ionic_dev.h\n@@ -256,11 +256,22 @@ void ionic_q_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n void ionic_q_sg_map(struct ionic_queue *q, void *base, rte_iova_t base_pa);\n void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, desc_cb cb,\n \tvoid *cb_arg);\n-uint32_t ionic_q_space_avail(struct ionic_queue *q);\n-bool ionic_q_has_space(struct ionic_queue *q, uint32_t want);\n void ionic_q_service(struct ionic_queue *q, uint32_t cq_desc_index,\n \tuint32_t stop_index, void *service_cb_arg);\n \n+static inline uint32_t\n+ionic_q_space_avail(struct ionic_queue *q)\n+{\n+\tuint32_t avail = q->tail_idx;\n+\n+\tif (q->head_idx >= avail)\n+\t\tavail += q->num_descs - q->head_idx - 1;\n+\telse\n+\t\tavail -= q->head_idx + 1;\n+\n+\treturn avail;\n+}\n+\n static inline void\n ionic_q_flush(struct ionic_queue *q)\n {\n", "prefixes": [ "08/13" ] }