Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86605/?format=api
{ "id": 86605, "url": "http://patches.dpdk.org/api/patches/86605/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210114110606.21142-15-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114110606.21142-15-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114110606.21142-15-bruce.richardson@intel.com", "date": "2021-01-14T11:06:00", "name": "[14/20] metrics: fix variable declaration in header", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e3ec14b12106e0437ec5f57024d44c1b2c11bbad", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210114110606.21142-15-bruce.richardson@intel.com/mbox/", "series": [ { "id": 14751, "url": "http://patches.dpdk.org/api/series/14751/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14751", "date": "2021-01-14T11:05:46", "name": "ensure headers have correct includes", "version": 1, "mbox": "http://patches.dpdk.org/series/14751/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/86605/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/86605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1ABA2A0A02;\n\tThu, 14 Jan 2021 12:08:22 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B7BD1411B9;\n\tThu, 14 Jan 2021 12:06:39 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 24E75141180;\n Thu, 14 Jan 2021 12:06:29 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 03:06:29 -0800", "from silpixa00399126.ir.intel.com ([10.237.222.4])\n by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:28 -0800" ], "IronPort-SDR": [ "\n HiYcWhFpO/xmwkdO69XStex8ejRW09ZWtf5qrvlhYPXiBVmxSGF0M/PhBGUONb9yHRO53Vy+65\n FGh9rXWFLHFw==", "\n 1Hhw7rM5V9xO1jQ0bGz6LRq/gtSgUrL8Vb/1XObo5au5CTMw/GFTwQg47zMUVA3dTfJCTY4bdy\n ANpH7ZzQ/J4Q==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9863\"; a=\"178498545\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"178498545\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"568139882\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tstable@dpdk.org", "Date": "Thu, 14 Jan 2021 11:06:00 +0000", "Message-Id": "<20210114110606.21142-15-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210114110606.21142-1-bruce.richardson@intel.com>", "References": "<20210114110606.21142-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 14/20] metrics: fix variable declaration in header", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The global variable \"tel_met_data\" was declared in a header file, rather\nthan in a C file, leading to duplicate definitions if more than one C\nfile included the header.\n\nFixes: c5b7197f662e (\"telemetry: move some functions to metrics library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_metrics/rte_metrics_telemetry.c | 2 ++\n lib/librte_metrics/rte_metrics_telemetry.h | 2 --\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c\nindex 901cbeb0a3..b8ee56ef01 100644\n--- a/lib/librte_metrics/rte_metrics_telemetry.c\n+++ b/lib/librte_metrics/rte_metrics_telemetry.c\n@@ -13,6 +13,8 @@\n #include \"rte_metrics.h\"\n #include \"rte_metrics_telemetry.h\"\n \n+struct telemetry_metrics_data tel_met_data;\n+\n int metrics_log_level;\n \n /* Logging Macros */\ndiff --git a/lib/librte_metrics/rte_metrics_telemetry.h b/lib/librte_metrics/rte_metrics_telemetry.h\nindex 3435a55425..5dbb32ca0c 100644\n--- a/lib/librte_metrics/rte_metrics_telemetry.h\n+++ b/lib/librte_metrics/rte_metrics_telemetry.h\n@@ -34,8 +34,6 @@ struct telemetry_metrics_data {\n \tint metrics_register_done;\n };\n \n-struct telemetry_metrics_data tel_met_data;\n-\n __rte_experimental\n int32_t rte_metrics_tel_reg_all_ethdev(int *metrics_register_done,\n \t\tint *reg_index_list);\n", "prefixes": [ "14/20" ] }