Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/86567/?format=api
{ "id": 86567, "url": "http://patches.dpdk.org/api/patches/86567/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20210114094627.13994-1-stevex.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210114094627.13994-1-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210114094627.13994-1-stevex.yang@intel.com", "date": "2021-01-14T09:46:27", "name": "[v3,08/22] net/iavf: fix the jumbo frame flag condition", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ff9ac1350205d51bf148c19883bab39bb1806aaf", "submitter": { "id": 1883, "url": "http://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20210114094627.13994-1-stevex.yang@intel.com/mbox/", "series": [ { "id": 14734, "url": "http://patches.dpdk.org/api/series/14734/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14734", "date": "2021-01-14T09:46:27", "name": null, "version": 3, "mbox": "http://patches.dpdk.org/series/14734/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/86567/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/86567/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DA81AA0A02;\n\tThu, 14 Jan 2021 10:50:02 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC92814106E;\n\tThu, 14 Jan 2021 10:49:50 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 68B95141065\n for <dev@dpdk.org>; Thu, 14 Jan 2021 10:49:49 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 01:49:40 -0800", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Jan 2021 01:49:39 -0800" ], "IronPort-SDR": [ "\n KgmSWY2tljQZiH599jCljaBTTlXb+Cg+PfNHybMnZ6wBbqfvqjY5xhWLl7aoat4ray6ZhVx97K\n gD9KC09Afrrw==", "\n fJHE/Wiu18fdwfmXb8HA1C4bK/FYsqtdIwxLkl5PsHMkbnX4ROn1ctOdpi8LfQMgyMyWF8Yspf\n rXfnfM/gaVcw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9863\"; a=\"157518786\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"157518786\"", "E=Sophos;i=\"5.79,347,1602572400\"; d=\"scan'208\";a=\"572283760\"" ], "From": "Steve Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "jingjing.wu@intel.com, beilei.xing@intel.com,\n Steve Yang <stevex.yang@intel.com>", "Date": "Thu, 14 Jan 2021 09:46:27 +0000", "Message-Id": "<20210114094627.13994-1-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20201217092312.27033-1-stevex.yang@intel.com>", "References": "<20201217092312.27033-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/22] net/iavf: fix the jumbo frame flag\n condition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition,\nbut the Ether overhead is larger than 18 when it supports dual VLAN tags.\nThat will cause the jumbo flag rx offload is wrong when MTU size is\n'RTE_ETHER_MTU'.\n\nThis fix will change the boundary condition with 'RTE_ETHER_MTU' and\noverhead, that perhaps impacts the cases of the jumbo frame related.\n\nFixes: 3fd7a3719c66 (\"net/avf: enable ops for MTU setting\")\nFixes: 69dd4c3d0898 (\"net/avf: enable queue and device\")\n\nSigned-off-by: Steve Yang <stevex.yang@intel.com>\n---\n drivers/net/iavf/iavf.h | 1 +\n drivers/net/iavf/iavf_ethdev.c | 10 +++++-----\n 2 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h\nindex af11268fe3..c934d2e614 100644\n--- a/drivers/net/iavf/iavf.h\n+++ b/drivers/net/iavf/iavf.h\n@@ -73,6 +73,7 @@\n #define IAVF_VLAN_TAG_SIZE 4\n #define IAVF_ETH_OVERHEAD \\\n \t(RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + IAVF_VLAN_TAG_SIZE * 2)\n+#define IAVF_ETH_MAX_LEN (RTE_ETHER_MTU + IAVF_ETH_OVERHEAD)\n \n #define IAVF_32_BIT_WIDTH (CHAR_BIT * 4)\n #define IAVF_48_BIT_WIDTH (CHAR_BIT * 6)\ndiff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex e22c62ed00..250ef6fc9a 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -460,23 +460,23 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct iavf_rx_queue *rxq)\n \t * correctly.\n \t */\n \tif (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n-\t\tif (max_pkt_len <= RTE_ETHER_MAX_LEN ||\n+\t\tif (max_pkt_len <= IAVF_ETH_MAX_LEN ||\n \t\t max_pkt_len > IAVF_FRAME_SIZE_MAX) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must be \"\n \t\t\t\t \"larger than %u and smaller than %u, \"\n \t\t\t\t \"as jumbo frame is enabled\",\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN,\n+\t\t\t\t (uint32_t)IAVF_ETH_MAX_LEN,\n \t\t\t\t (uint32_t)IAVF_FRAME_SIZE_MAX);\n \t\t\treturn -EINVAL;\n \t\t}\n \t} else {\n \t\tif (max_pkt_len < RTE_ETHER_MIN_LEN ||\n-\t\t max_pkt_len > RTE_ETHER_MAX_LEN) {\n+\t\t max_pkt_len > IAVF_ETH_MAX_LEN) {\n \t\t\tPMD_DRV_LOG(ERR, \"maximum packet length must be \"\n \t\t\t\t \"larger than %u and smaller than %u, \"\n \t\t\t\t \"as jumbo frame is disabled\",\n \t\t\t\t (uint32_t)RTE_ETHER_MIN_LEN,\n-\t\t\t\t (uint32_t)RTE_ETHER_MAX_LEN);\n+\t\t\t\t (uint32_t)IAVF_ETH_MAX_LEN);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n@@ -1303,7 +1303,7 @@ iavf_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \t\treturn -EBUSY;\n \t}\n \n-\tif (frame_size > RTE_ETHER_MAX_LEN)\n+\tif (frame_size > IAVF_ETH_MAX_LEN)\n \t\tdev->data->dev_conf.rxmode.offloads |=\n \t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n \telse\n", "prefixes": [ "v3", "08/22" ] }