Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/85880/?format=api
{ "id": 85880, "url": "http://patches.dpdk.org/api/patches/85880/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20201229200901.101171-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201229200901.101171-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20201229200901.101171-2-stephen@networkplumber.org", "date": "2020-12-29T20:08:59", "name": "[v2,1/3] pdump: use rte_pktmbuf_free bulk", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6dd771ce7825ca87c5af4b8f13d375f859477070", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20201229200901.101171-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 14492, "url": "http://patches.dpdk.org/api/series/14492/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=14492", "date": "2020-12-29T20:08:58", "name": "pdump: small enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/14492/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/85880/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/85880/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D09FCA09FF;\n\tTue, 29 Dec 2020 21:09:37 +0100 (CET)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 91AA12BB8;\n\tTue, 29 Dec 2020 21:09:20 +0100 (CET)", "from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id 9014C2B8E\n for <dev@dpdk.org>; Tue, 29 Dec 2020 21:09:18 +0100 (CET)", "by mail-pl1-f171.google.com with SMTP id be12so7630812plb.4\n for <dev@dpdk.org>; Tue, 29 Dec 2020 12:09:18 -0800 (PST)", "from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127])\n by smtp.gmail.com with ESMTPSA id r14sm37763237pgi.27.2020.12.29.12.09.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 29 Dec 2020 12:09:15 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=+wz0cuFsr/Sdgpfo0HmuQYmPhRYvVLn8AMgzq82kvaM=;\n b=kIyf/NTMwBt0o5pcc2nA033OFonxvYKcmVypMZgTt/wyiqZ+m9jai++/OpaAxjmNpX\n r8EeA1tx5Es07HMMHRDqeTHyZ20ogEQpcSgKySyabrJbFatk5mM4RzqN/kXSWgeSc0TZ\n NI2e3P5UsXdCROpRp6HtJiljGpp44IWL2emjw7MRv80hlBzkhuHNDwweBI0SDqaJdiJn\n F6NbUCjsmouDQbsmxfA/l2Rk8M3DuaixoerCLrNmI8I8ohIhRT18dszEPTrrIEmgkRyq\n MbukCNn/DCKrS4hTODObhG2NXlK4keynRDjeBIULZsXcLLltrcNcFdgXPSp5LSi4gDND\n 2dpw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=+wz0cuFsr/Sdgpfo0HmuQYmPhRYvVLn8AMgzq82kvaM=;\n b=MCSHo9S8JCrHcH4Ek9FNvBsynTsrFLEIDfCaHVY3784R1DK5FoiL+6zB7M39S+toZ1\n bpK3QR047n2yYCkwtapNhd6eimqbpjSsJa8trRDyXx1NIWQ583pMwrWHZCEl9AdRHnD/\n Lk2D2VaxrNIa3JtMk685v6hlw6VBrpzx4OfdBSTT/6LTpWHJyGQzODCUop0AONqeU4ay\n G0o+okMqEe3gRd77Y68s/wClGu52+6WT5vxAvjZM19rJcCzi3+gH+wJtnS6noW06QyXd\n 676WlLW1/QamC936O12QIyKCA+NE/YEbdZKo/BhRK0rKwuX5lPTcTlbN9vJG0QOSr0ss\n xTOw==", "X-Gm-Message-State": "AOAM532I4Na1D3zZ24e4PAutwC9asUKgaZ+Z64Z6I+znX/0udjyvkxTJ\n +mWbDQWEcf748vkOqGAc/AAhWsjB/n5IRQ==", "X-Google-Smtp-Source": "\n ABdhPJzDQ5gWlLe3arP9XExM7lhFg//68ixJJaWNgVrOu/nMKTv+jIQ4XzUeuz7MuvCt4GS9Z3jJwA==", "X-Received": "by 2002:a17:90a:a781:: with SMTP id\n f1mr5423056pjq.111.1609272556444;\n Tue, 29 Dec 2020 12:09:16 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 29 Dec 2020 12:08:59 -0800", "Message-Id": "<20201229200901.101171-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20201229200901.101171-1-stephen@networkplumber.org>", "References": "<20201227033335.85145-1-stephen@networkplumber.org>\n <20201229200901.101171-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/3] pdump: use rte_pktmbuf_free bulk", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_pktmbuf_free_bulk instead of loop when freeing\npackets.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/pdump/main.c | 8 ++++----\n lib/librte_pdump/rte_pdump.c | 6 +++---\n 2 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/pdump/main.c b/app/pdump/main.c\nindex b34bf335317b..63bbe65cd843 100644\n--- a/app/pdump/main.c\n+++ b/app/pdump/main.c\n@@ -477,10 +477,10 @@ pdump_rxtx(struct rte_ring *ring, uint16_t vdev_id, struct pdump_stats *stats)\n \t\tstats->tx_pkts += nb_in_txd;\n \n \t\tif (unlikely(nb_in_txd < nb_in_deq)) {\n-\t\t\tdo {\n-\t\t\t\trte_pktmbuf_free(rxtx_bufs[nb_in_txd]);\n-\t\t\t\tstats->freed_pkts++;\n-\t\t\t} while (++nb_in_txd < nb_in_deq);\n+\t\t\tunsigned int drops = nb_in_deq - nb_in_txd;\n+\n+\t\t\trte_pktmbuf_free_bulk(&rxtx_bufs[nb_in_txd], drops);\n+\t\t\tstats->freed_pkts += drops;\n \t\t}\n \t}\n }\ndiff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex b3c8d5ce4384..3c11bd795bc1 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -93,11 +93,11 @@ pdump_copy(struct rte_mbuf **pkts, uint16_t nb_pkts, void *user_params)\n \n \tring_enq = rte_ring_enqueue_burst(ring, (void *)dup_bufs, d_pkts, NULL);\n \tif (unlikely(ring_enq < d_pkts)) {\n+\t\tunsigned int drops = d_pkts - ring_enq;\n+\n \t\tPDUMP_LOG(DEBUG,\n \t\t\t\"only %d of packets enqueued to ring\\n\", ring_enq);\n-\t\tdo {\n-\t\t\trte_pktmbuf_free(dup_bufs[ring_enq]);\n-\t\t} while (++ring_enq < d_pkts);\n+\t\trte_pktmbuf_free_bulk(&dup_bufs[ring_enq], drops);\n \t}\n }\n \n", "prefixes": [ "v2", "1/3" ] }